On Tue, Oct 14, 2008 at 10:39:03AM +0200, Martin Mares wrote:
Hi!
Fixes are attached as patch following bird-md5.diff . Or should i send corrected original patches?
Please send corrected original patches, it will be easier to follow in the history.
OK, here they are.
BTW, in bgp_rte_better() we compare MEDs between routes from different ASes, although RFC says that MED is only comparable between routes learned from the same neighboring AS. Is this bug or some cleverness?
The same-AS rule has been introduced in RFC 4271, which is much newer than the BGP code in BIRD. The tie breaking algorithm in RFC 1771 compares MEDs even for different ASes.
Thank you for explanation, i will fix it. -- Elen sila lumenn' omentielvo Ondrej 'SanTiago' Zajicek (email: santiago@crfreenet.org) OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net) "To err is human -- to blame it on a computer is even more so."