On Mon, Nov 25, 2019 at 04:26:45PM +0000, Kenth Eriksson wrote:
On Mon, 2019-11-25 at 16:02 +0000, Kenth Eriksson wrote:
On Wed, 2019-06-12 at 17:26 +0200, Ondrej Zajicek wrote:
CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.
Therefore, i just finished it [*]. Also, i did not use messages from cmd_reconfig_msg(), as these are appropriate as answers to requests, but not as status reports. But used the same reply codes, to ease parsing.
[*] see commit 9106a750cd76d4a76c7a60294ce3a43eede166c9
Noticed an issue with the code in this commit; it omits the reply code if it was preceded by a configure command. Consider the following;
bird> configure 0002-Reading configuration from /usr/local/src/BUILD/HOST/x86/etc/bird.conf 0003 Reconfigured bird> configure status Daemon is up and running bird> configure status 0003-Daemon is up and running bird>
I believe reply code issue is caused by the following lines since reply code 3 is used twice...
if (cd == c->last_reply) size = bsprintf(buf, " "); else size = bsprintf(buf, "%04d-", cd);
Thanks, you are right. I will check this. -- Elen sila lumenn' omentielvo Ondrej 'Santiago' Zajicek (email: santiago@crfreenet.org) OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net) "To err is human -- to blame it on a computer is even more so."