On Tue, Jan 07, 2025 at 03:07:33PM +0000, Job Snijders wrote:
RFC 8203 was replaced by RFC 9003; BIRD supports 9003 since 2019. While there add Send Hold Timer to the list.
Whoops, mangled the diff, the below applies cleanly to HEAD. diff --git doc/bird.sgml doc/bird.sgml index bafe0445..8420a66d 100644 --- doc/bird.sgml +++ doc/bird.sgml @@ -2837,15 +2837,15 @@ avoid routing loops. <item> <rfc id="7911"> - Advertisement of Multiple Paths in BGP <item> <rfc id="7947"> - Internet Exchange BGP Route Server <item> <rfc id="8092"> - BGP Large Communities Attribute -<item> <rfc id="8203"> - BGP Administrative Shutdown Communication <item> <rfc id="8212"> - Default EBGP Route Propagation Behavior without Policies <item> <rfc id="8654"> - Extended Message Support for BGP <item> <rfc id="8950"> - Advertising IPv4 NLRI with an IPv6 Next Hop +<item> <rfc id="9003"> - Extended BGP Administrative Shutdown Communication <item> <rfc id="9072"> - Extended Optional Parameters Length for BGP OPEN Message <item> <rfc id="9117"> - Revised Validation Procedure for BGP Flow Specifications <item> <rfc id="9234"> - Route Leak Prevention and Detection Using Roles <item> <rfc id="9494"> - Long-Lived Graceful Restart for BGP -<item> <rfc id="9687"> - Send Hold Timer +<item> <rfc id="9687"> - BGP Send Hold Timer </itemize> <sect1>Route selection rules diff --git proto/bgp/bgp.c proto/bgp/bgp.c index c18a73fe..df4c1f0f 100644 --- proto/bgp/bgp.c +++ proto/bgp/bgp.c @@ -97,10 +97,10 @@ * RFC 7911 - Advertisement of Multiple Paths in BGP * RFC 7947 - Internet Exchange BGP Route Server * RFC 8092 - BGP Large Communities Attribute - * RFC 8203 - BGP Administrative Shutdown Communication * RFC 8212 - Default EBGP Route Propagation Behavior without Policies * RFC 8654 - Extended Message Support for BGP * RFC 8950 - Advertising IPv4 NLRI with an IPv6 Next Hop + * RFC 9003 - Extended BGP Administrative Shutdown Communication * RFC 9072 - Extended Optional Parameters Length for BGP OPEN Message * RFC 9117 - Revised Validation Procedure for BGP Flow Specifications * RFC 9234 - Route Leak Prevention and Detection Using Roles @@ -1709,7 +1709,7 @@ bgp_shutdown(struct proto *P) bgp_store_error(p, NULL, BE_MAN_DOWN, 0); p->startup_delay = 0; - /* RFC 8203 - shutdown communication */ + /* RFC 9003 - shutdown communication */ if (message) { uint msg_len = strlen(message); diff --git proto/bgp/packets.c proto/bgp/packets.c index 8b78cc13..37fe3cd6 100644 --- proto/bgp/packets.c +++ proto/bgp/packets.c @@ -3296,7 +3296,7 @@ bgp_error_dsc(uint code, uint subcode) return buff; } -/* RFC 8203 - shutdown communication message */ +/* RFC 9003 - shutdown communication message */ static int bgp_handle_message(struct bgp_proto *p, byte *data, uint len, byte **bp) { @@ -3351,7 +3351,7 @@ bgp_log_error(struct bgp_proto *p, u8 class, char *msg, uint code, uint subcode, goto done; } - /* RFC 8203 - shutdown communication */ + /* RFC 9003 - shutdown communication */ if (((code == 6) && ((subcode == 2) || (subcode == 4)))) if (bgp_handle_message(p, data, len, &t)) goto done;