On Mon, Oct 03, 2011 at 10:43:12AM +0200, Martin Mares wrote:
Better let the caller supply an appropriate buffer. The number of direct callers is going to be low anyway, since almost everybody will use bprintf().
| --- /dev/null | +++ b/lib/addrs.h [...] | +typedef uint64_t u64;
Huh? It should be already defined in sysdep/config.h.
Already fixed in later commits.
| +#ifndef IPV6 | +typedef vpn4_addr vpn_addr; | +#else | +typedef vpn6_addr vpn_addr; | +#endif
Calling this beast "vpn" without further clarification is going to be confusing -- people (even those experienced in networking) usually do not associate "vpn" with "MPLS" implicitly. Better choose a more descriptive name.
These vpnX_addrs are not directly related to MPLS. They are just pairs (address_space, IPvX address), where address_spaces (RD, route distinguisher) are 8B identifiers specifying different VPNs. These are often implemented using MPLS (and that is probably a reason why the are implemented here), but they may be implemented in different ways (not related to MPLS). Therefore, i think that vpnX_addr is a descriptive name. Although the GIT branch is named mpls, nothing currently merged is directly related to MPLS (just multiprotocol stuff and these VPN addresses). -- Elen sila lumenn' omentielvo Ondrej 'SanTiago' Zajicek (email: santiago@crfreenet.org) OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net) "To err is human -- to blame it on a computer is even more so."