February 2014 - Bird-users

OSFP LSA_MAXSEQNO problems
by Alexander V. Chernikov 23 Feb '14

23 Feb '14

Hello list! Currently bird performs LSA premature aging in very strange way which sometimes upsets quagga (up to SIGSEGV) and Cisco. Every time aging is done via setting seq number to LSA_MAXSEQNO. RFC 2328, on the opposite, shows us only 2 cases where MaxSequenceNumber is used in outgoing LSAs: 1) Self LSA originating with given seq num (very rare event) 2) [Premature] Aging of LSA from 1) because a) disappeared net and b) seq number increase (12.1.6) For all other cases seq number should be either increased or left intact. Bird, however, insist on setting LSA_MAXSEQNO while: 1) Receiving self-originating LSA which is not in local LSDB ( ospf_lsupd_receive ) which is not a special case according to 14.1 2) In all other places like handling if-down, external route disappear, etc... ( ospf_lsupd_flush_nlsa ) IT takes noticeable time (sometimes up to 5 seconds) for Cisco 65XX with ~40 neighbors to age given LSA (however it seems that problem is repeatable for ASR9k, too). And while such LSA is in database, every new update is ignored due to 13 step (8). (I've got full logs and pcap for given situation). Can we please consider applying attached patch to make it more compliant?

2 3

[PATCH 2/2] Remember sequence number for LSAs.
by Alexander V. Chernikov 23 Feb '14

23 Feb '14

--- proto/ospf/iface.c | 2 +- proto/ospf/lsalib.c | 5 +- proto/ospf/lsupd.c | 15 +-- proto/ospf/lsupd.h | 2 +- proto/ospf/ospf.c | 8 ++ proto/ospf/ospf.h | 4 + proto/ospf/topology.c | 306 +++++++++++++++++++++++++++++++++++++++++++------- proto/ospf/topology.h | 17 +++ 8 files changed, 301 insertions(+), 58 deletions(-) diff --git a/proto/ospf/iface.c b/proto/ospf/iface.c index f4d9be5..171cf7e 100644 --- a/proto/ospf/iface.c +++ b/proto/ospf/iface.c @@ -318,7 +318,7 @@ ospf_iface_chstate(struct ospf_iface *ifa, u8 state) { ifa->net_lsa->lsa.age = LSA_MAXAGE; if (state >= OSPF_IS_WAITING) - ospf_lsupd_flush_nlsa(po, ifa->net_lsa); + ospf_lsupd_flush_nlsa(po, ifa->oa, ifa->net_lsa); if (can_flush_lsa(po)) flush_lsa(ifa->net_lsa, po); diff --git a/proto/ospf/lsalib.c b/proto/ospf/lsalib.c index bcf7bcd..2b238e3 100644 --- a/proto/ospf/lsalib.c +++ b/proto/ospf/lsalib.c @@ -69,10 +69,7 @@ ospf_age(struct proto_ospf *po) { OSPF_TRACE(D_EVENTS, "Refreshing my LSA: Type: %u, Id: %R, Rt: %R", en->lsa.type, en->lsa.id, en->lsa.rt); - en->lsa.sn++; - en->lsa.age = 0; - en->inst_t = now; - en->ini_age = 0; + update_lsa_seq(po, en, en->lsa.sn + 1); /* XXX: LSA_MAXSEQNO */ lsasum_calculate(&en->lsa, en->lsa_body); ospf_lsupd_flood(po, NULL, NULL, &en->lsa, en->domain, 1); continue; diff --git a/proto/ospf/lsupd.c b/proto/ospf/lsupd.c index 8f65c53..65c9ae4 100644 --- a/proto/ospf/lsupd.c +++ b/proto/ospf/lsupd.c @@ -600,20 +600,14 @@ ospf_lsupd_receive(struct ospf_packet *ps_i, struct ospf_iface *ifa, if (lsadb) { OSPF_TRACE(D_EVENTS, "Reflooding new self-originated LSA with newer sequence number"); - lsadb->lsa.sn = lsatmp.sn + 1; - lsadb->lsa.age = 0; - lsadb->inst_t = now; - lsadb->ini_age = 0; - lsasum_calculate(&lsadb->lsa, lsadb->lsa_body); + update_lsa_seq(po, lsadb, lsatmp.sn + 1); /* XXX: lsatmp.sn == LSA_MAXSEQNO - 1 */ ospf_lsupd_flood(po, NULL, NULL, &lsadb->lsa, domain, 1); } else { OSPF_TRACE(D_EVENTS, "Premature aging it"); lsatmp.age = LSA_MAXAGE; - lsatmp.sn = LSA_MAXSEQNO; lsa->age = htons(LSA_MAXAGE); - lsa->sn = htonl(LSA_MAXSEQNO); lsasum_check(lsa, (lsa + 1)); /* It also calculates chsum! */ lsatmp.checksum = ntohs(lsa->checksum); ospf_lsupd_flood(po, NULL, lsa, &lsatmp, domain, 0); @@ -749,14 +743,13 @@ ospf_lsupd_receive(struct ospf_packet *ps_i, struct ospf_iface *ifa, } void -ospf_lsupd_flush_nlsa(struct proto_ospf *po, struct top_hash_entry *en) +ospf_lsupd_flush_nlsa(struct proto_ospf *po, struct ospf_area *oa, struct top_hash_entry *en) { struct ospf_lsa_header *lsa = &en->lsa; struct proto *p = &po->proto; - lsa->age = LSA_MAXAGE; - lsa->sn = LSA_MAXSEQNO; - lsasum_calculate(lsa, en->lsa_body); + flush_lsa_seq(po, oa, en); + OSPF_TRACE(D_EVENTS, "Premature aging self originated lsa!"); OSPF_TRACE(D_EVENTS, "Type: %04x, Id: %R, Rt: %R", lsa->type, lsa->id, lsa->rt); ospf_lsupd_flood(po, NULL, NULL, lsa, en->domain, 0); diff --git a/proto/ospf/lsupd.h b/proto/ospf/lsupd.h index 8bacfe6..780ba9d 100644 --- a/proto/ospf/lsupd.h +++ b/proto/ospf/lsupd.h @@ -18,7 +18,7 @@ void ospf_lsupd_receive(struct ospf_packet *ps_i, int ospf_lsupd_flood(struct proto_ospf *po, struct ospf_neighbor *n, struct ospf_lsa_header *hn, struct ospf_lsa_header *hh, u32 domain, int rtl); -void ospf_lsupd_flush_nlsa(struct proto_ospf *po, struct top_hash_entry *en); +void ospf_lsupd_flush_nlsa(struct proto_ospf *po, struct ospf_area *oa, struct top_hash_entry *en); int ospf_lsa_flooding_allowed(struct ospf_lsa_header *lsa, u32 domain, struct ospf_iface *ifa); diff --git a/proto/ospf/ospf.c b/proto/ospf/ospf.c index e751f7c..0684de9 100644 --- a/proto/ospf/ospf.c +++ b/proto/ospf/ospf.c @@ -178,6 +178,8 @@ ospf_area_add(struct proto_ospf *po, struct ospf_area_config *ac, int reconf) if (oa_is_nssa(oa) && ((struct ospf_config *) (p->cf))->abr) po->ebit = 1; + init_seq_fib(po, oa); + if (reconf) ospf_ifaces_reconfigure(oa, ac); } @@ -198,6 +200,8 @@ ospf_area_remove(struct ospf_area *oa) if (oa->translator_timer) rfree(oa->translator_timer); + free_seq_fib(oa->po, oa); + oa->po->areano--; rem_node(NODE oa); mb_free(oa); @@ -265,6 +269,8 @@ ospf_start(struct proto *p) WALK_LIST(ic, c->vlink_list) ospf_iface_new_vlink(po, ic); + init_seq_fib(po, NULL); + return PS_UP; } @@ -563,6 +569,8 @@ ospf_shutdown(struct proto *p) } FIB_WALK_END; + free_seq_fib(po, NULL); + return PS_DOWN; } diff --git a/proto/ospf/ospf.h b/proto/ospf/ospf.h index 66719e3..44b3344 100644 --- a/proto/ospf/ospf.h +++ b/proto/ospf/ospf.h @@ -756,6 +756,8 @@ struct ospf_area timer *translator_timer; /* For NSSA translator switch */ struct proto_ospf *po; struct fib rtr; /* Routing tables for routers */ + struct fib seq_fib; /* Sequence number storage for LSAs */ + timer *seq_timer; /* Timer for seq_fib pruning */ }; #define TRANS_OFF 0 @@ -786,6 +788,8 @@ struct proto_ospf sock *vlink_sk; /* IP socket used for vlink TX */ u32 router_id; u32 last_vlink_id; /* Interface IDs for vlinks (starts at 0x80000000) */ + struct fib seq_fib; /* Sequence number storage for external LSAs */ + timer *seq_timer; /* Timer for seq_fib pruning */ }; struct ospf_iface_patt diff --git a/proto/ospf/topology.c b/proto/ospf/topology.c index 6498585..cc4c97a 100644 --- a/proto/ospf/topology.c +++ b/proto/ospf/topology.c @@ -27,6 +27,9 @@ void flush_prefix_net_lsa(struct ospf_iface *ifa); static void fill_lsa_header(struct proto_ospf *po, struct ospf_area *oa, struct ospf_lsa_header *lsa, struct fib_node *fn, struct ospf_iface *ifa); +static s32 get_lsa_seq(struct proto_ospf *po, struct ospf_area *oa, struct ospf_lsa_header *lsa); +static void check_seq_fibs(struct timer *timer); + #ifdef OSPFv2 #define ipa_to_rid(x) _I(x) #else /* OSPFv3 */ @@ -141,23 +144,6 @@ lsab_end(struct proto_ospf *po) return ((byte *) po->lsab) + po->lsab_used; } -static s32 -get_seqnum(struct top_hash_entry *en) -{ - if (!en) - return LSA_INITSEQNO; - - if (en->lsa.sn == LSA_MAXSEQNO) - { - log(L_WARN "OSPF: Premature origination of LSA (Type: %04x, Id: %R, Rt: %R)", - en->lsa.type, en->lsa.id, en->lsa.rt); - return LSA_INITSEQNO; - } - - return en->lsa.sn + 1; -} - - static int configured_stubnet(struct ospf_area *oa, struct ifa *a) { @@ -490,7 +476,7 @@ originate_rt_lsa(struct ospf_area *oa) lsa.type = LSA_T_RT; fill_lsa_header(po, oa, &lsa, NULL, NULL); - lsa.sn = get_seqnum(oa->rt); + lsa.sn = get_lsa_seq(po, oa, &lsa); u32 dom = oa->areaid; body = originate_rt_lsa_body(oa, &lsa.length); @@ -594,7 +580,7 @@ originate_net_lsa(struct ospf_iface *ifa) lsa.type = LSA_T_NET; fill_lsa_header(po, ifa->oa, &lsa, NULL, ifa); - lsa.sn = get_seqnum(ifa->net_lsa); + lsa.sn = get_lsa_seq(po, ifa->oa, &lsa); body = originate_net_lsa_body(ifa, &lsa.length, po); lsasum_calculate(&lsa, body); @@ -613,9 +599,7 @@ flush_net_lsa(struct ospf_iface *ifa) return; OSPF_TRACE(D_EVENTS, "Flushing network-LSA for iface %s", ifa->ifname); - ifa->net_lsa->lsa.sn += 1; - ifa->net_lsa->lsa.age = LSA_MAXAGE; - lsasum_calculate(&ifa->net_lsa->lsa, ifa->net_lsa->lsa_body); + flush_lsa_seq(po, ifa->oa, ifa->net_lsa); ospf_lsupd_flood(po, NULL, NULL, &ifa->net_lsa->lsa, dom, 0); flush_lsa(ifa->net_lsa, po); ifa->net_lsa = NULL; @@ -684,7 +668,7 @@ check_sum_lsa_same(struct top_hash_entry *en, u32 metric) { /* Netmask already checked in check_sum_net_lsaid_collision() */ struct ospf_lsa_sum *sum = en->lsa_body; - return (en->lsa.sn != LSA_MAXSEQNO) && (sum->metric == metric); + return (en->lsa.age != LSA_MAXAGE) && (sum->metric == metric); } #define check_sum_net_lsa_same(en,metric) \ @@ -727,7 +711,7 @@ check_sum_net_lsa_same(struct top_hash_entry *en, u32 metric) { /* Prefix already checked in check_sum_net_lsaid_collision() */ struct ospf_lsa_sum_net *sum = en->lsa_body; - return (en->lsa.sn != LSA_MAXSEQNO) && (sum->metric == metric); + return (en->lsa.age != LSA_MAXAGE) && (sum->metric == metric); } static inline void * @@ -747,7 +731,7 @@ static inline int check_sum_rt_lsa_same(struct top_hash_entry *en, u32 drid, u32 metric, u32 options) { struct ospf_lsa_sum_rt *sum = en->lsa_body; - return (en->lsa.sn != LSA_MAXSEQNO) && (sum->options == options) && + return (en->lsa.age != LSA_MAXAGE) && (sum->options == options) && (sum->metric == metric) && (sum->drid == drid); } @@ -781,7 +765,7 @@ originate_sum_net_lsa(struct ospf_area *oa, struct fib_node *fn, int metric) if (check_sum_net_lsa_same(en, metric)) return; } - lsa.sn = get_seqnum(en); + lsa.sn = get_lsa_seq(po, oa, &lsa); body = originate_sum_net_lsa_body(po, &lsa.length, fn, metric); lsasum_calculate(&lsa, body); @@ -813,7 +797,7 @@ originate_sum_rt_lsa(struct ospf_area *oa, struct fib_node *fn, int metric, u32 if (check_sum_rt_lsa_same(en, lsa.id, metric, options)) return; } - lsa.sn = get_seqnum(en); + lsa.sn = get_lsa_seq(po, oa, &lsa); body = originate_sum_rt_lsa_body(po, &lsa.length, lsa.id, metric, options); lsasum_calculate(&lsa, body); @@ -844,10 +828,7 @@ flush_sum_lsa(struct ospf_area *oa, struct fib_node *fn, int type) return; } - struct ospf_lsa_sum *sum = en->lsa_body; - en->lsa.age = LSA_MAXAGE; - en->lsa.sn = LSA_MAXSEQNO; - lsasum_calculate(&en->lsa, sum); + flush_lsa_seq(po, oa, en); ospf_lsupd_flood(po, NULL, NULL, &en->lsa, oa->areaid, 1); if (can_flush_lsa(po)) flush_lsa(en, po); } @@ -893,7 +874,7 @@ check_ext_lsa(struct top_hash_entry *en, struct fib_node *fn, u32 metric, ip_add if (fn->pxlen != ipa_mklen(ext->netmask)) return -1; - return (en->lsa.sn != LSA_MAXSEQNO) && (ext->metric == metric) && + return (en->lsa.age != LSA_MAXAGE) && (ext->metric == metric) && (ext->tag == tag) && ipa_equal(ext->fwaddr,fwaddr); } @@ -946,7 +927,7 @@ check_ext_lsa(struct top_hash_entry *en, struct fib_node *fn, u32 metric, ip_add if ((fn->pxlen != pxlen) || !ipa_equal(fn->prefix, prefix)) return -1; - if (en->lsa.sn == LSA_MAXSEQNO) + if (en->lsa.age == LSA_MAXAGE) return 0; u32 rt_metric = ext->metric & METRIC_MASK; @@ -1081,7 +1062,7 @@ originate_ext_lsa(struct ospf_area *oa, struct fib_node *fn, int src, if (rv > 0) return; } - lsa.sn = get_seqnum(en); + lsa.sn = get_lsa_seq(po, NULL, &lsa); body = originate_ext_lsa_body(po, &lsa.length, fn, metric, fwaddr, tag, pbit); lsasum_calculate(&lsa, body); @@ -1126,7 +1107,7 @@ flush_ext_lsa(struct ospf_area *oa, struct fib_node *fn, int nssa) } fn->x1 = 0; - ospf_lsupd_flush_nlsa(po, en); + ospf_lsupd_flush_nlsa(po, NULL, en); } } @@ -1216,6 +1197,251 @@ fill_lsa_header(struct proto_ospf *po, struct ospf_area *oa, struct ospf_lsa_hea lsa->id = lsid; } +static struct seq_data * +find_seq(struct proto_ospf *po, struct ospf_area *oa, struct ospf_lsa_header *lsa, int create) +{ + struct seq_fib_data *sfd; + struct fib *seq_fib; + ip_addr addr; + + memset(&addr, 0, sizeof(addr)); +#ifdef IPV6 + _I3(addr) = lsa->id; +#else + addr = _I(lsa->id); +#endif + + if (oa != NULL) + seq_fib = &oa->seq_fib; + else + seq_fib = &po->seq_fib; + + if (create != 0) + sfd = (struct seq_fib_data *)fib_get(seq_fib, &addr, BITS_PER_IP_ADDRESS); + else + sfd = (struct seq_fib_data *)fib_find(seq_fib, &addr, BITS_PER_IP_ADDRESS); + + if (sfd == NULL) + return NULL; + + return &sfd->type[lsa->type % SEQ_DATA_MAX]; +} + +static s32 +get_lsa_seq(struct proto_ospf *po, struct ospf_area *oa, struct ospf_lsa_header *lsa) +{ + struct seq_data *sd; + + sd = find_seq(po, oa, lsa, 1); + + if (sd->active == 0) + { + /* New entry */ + sd->seq = LSA_INITSEQNO; + } + else + { + if (++sd->seq == LSA_MAXSEQNO) + { + /* + * According to 12.1.6 in 2338 RFC + * we need to ensure that previous version + * is flushed: + * + * 'As soon as this flood has been acknowledged by + * all adjacent neighbors, a new instance can be + * originated with sequence number of InitialSequenceNumber.' + * + * XXX: We're currently not controlling if our adjacent neighbors + * acknowledge LSA flush. However, since this is VERY rare case, + * simply set seq to InitialSequenceNumber. + */ + sd->seq = LSA_INITSEQNO; + } + } + + sd->active = 1; + sd->last = now; + + return sd->seq; +} + +/** + * update_lsa_seq - updates age/seq/checksum for given LSA. + * @po: OSPF protocol + * @oa: OSPF area + * @en: LSA base + * @sn: new checksum + */ +void +update_lsa_seq(struct proto_ospf *po, struct top_hash_entry *en, s32 sn) +{ + struct ospf_lsa_header *lsa = &en->lsa; + struct ospf_area *oa = NULL; + struct seq_data *sd; + + lsa->sn = sn; + lsa->age = 0; + en->inst_t = now; + en->ini_age = 0; + lsasum_calculate(lsa, en->lsa_body); + + /* + * Get area to search into. + * Treat LSA_SCOPE_LINK as AREA and + * LSA_SCOPE_RES (if any) as AS + */ + switch (LSA_SCOPE(lsa)) + { +#ifndef OSPFv2 + case LSA_SCOPE_LINK: +#endif + case LSA_SCOPE_AREA: + oa = ospf_find_area(po, en->domain); + break; + } + + if ((sd = find_seq(po, oa, lsa, 0)) == NULL) + { + log(L_WARN "Unable to find LSA sequence for LSA (id=%R type %d)", lsa->id, lsa->type); + return; + } + + sd->seq = lsa->sn; + sd->last = now; +} + +/** + * flush_lsa_seq - notify we're not using given LSA anymore. Updates LSA age/checksum. + * @po: OSPF protocol + * @oa: OSPF area + * @en: LSA base + */ +void +flush_lsa_seq(struct proto_ospf *po, struct ospf_area *oa, struct top_hash_entry *en) +{ + struct ospf_lsa_header *lsa = &en->lsa; + struct seq_data *sd; + + lsa->age = LSA_MAXAGE; + lsasum_calculate(lsa, en->lsa_body); + + if ((sd = find_seq(po, oa, lsa, 0)) == NULL) + { + log(L_WARN "Unable to flush LSA sequence for LSA (id=%R type %d)", lsa->id, lsa->type); + return; + } + + sd->active = -1; + sd->last = now; +} + +/** + * check_seq_fib - remove unused prefixes from fib + * @po: OSPF protocol + * @seq_fib: fib put prune + */ +static void +check_seq_fib(struct proto_ospf *po, struct fib *seq_fib) +{ + struct fib_iterator fit; + struct seq_fib_data *sfd; + struct seq_data *sd; + int i, keep; + + FIB_ITERATE_INIT(&fit, seq_fib); +again: + FIB_ITERATE_START(seq_fib, &fit, nftmp) + { + sfd = (struct seq_fib_data *) nftmp; + + /* + * Check if we need purge "old" prefixes. + * + * RFC 2328, 14 tells us: + * + * A MaxAge LSA must be removed immediately from the router's link + * state database as soon as both a) it is no longer contained on any + * neighbor Link state retransmission lists and b) none of the router's + * neighbors are in states Exchange or Loading. + * + * This basically means we have no guaranteed timing on MaxAge LSA + * removal, so we keep entries for considerably long amount of time. + */ + keep = 0; + for (i = 0; i < SEQ_DATA_MAX; i++) + { + sd = &sfd->type[i]; + if (sd->active == 1 || sd->last + 3600 >= now) + keep = 1; + } + if (keep == 0) + { + FIB_ITERATE_PUT(&fit, nftmp); + fib_delete(seq_fib, nftmp); + goto again; + } + } + FIB_ITERATE_END(nftmp); +} + +/** + * check_seq_fib - remove unused prefixes from fib + * @timer: timer + */ +static void +check_seq_fibs(timer *timer) +{ + struct proto_ospf *po = timer->data; + struct ospf_area *oa; + + /* Check protocol fib first */ + check_seq_fib(po, &po->seq_fib); + + WALK_LIST(oa, po->area_list) + check_seq_fib(po, &oa->seq_fib); +} + + +/** + * init_seq_fib - Initialize fib for sequence storage + * @po: OSPF protocol + * @oa: OSPF area, if set + */ +void +init_seq_fib(struct proto_ospf *po, struct ospf_area *oa) +{ + timer *t; + struct fib *seq_fib = (oa == NULL) ? &po->seq_fib : &oa->seq_fib; + + fib_init(seq_fib, po->proto.pool, sizeof(struct seq_fib_data), 0, NULL); + + if (oa == NULL) + { + t = tm_new(po->proto.pool); + t->data = po; + t->randomize = 0; + t->hook = check_seq_fibs; + t->recurrent = 3600 / 3; + po->seq_timer = t; + tm_start(t, t->recurrent); + } +} + +/** + * free_seq_fib - iFree sequence storage fib + * @po: OSPF protocol + */ +void +free_seq_fib(struct proto_ospf *po, struct ospf_area *oa) +{ + struct fib *seq_fib = (oa == NULL) ? &po->seq_fib : &oa->seq_fib; + + fib_free(seq_fib); + if (oa != NULL) + rfree(oa->seq_timer); +} + #ifdef OSPFv3 static void * @@ -1267,7 +1493,7 @@ originate_link_lsa(struct ospf_iface *ifa) lsa.type = LSA_T_LINK; fill_lsa_header(po, ifa->oa, &lsa, NULL, ifa); - lsa.sn = get_seqnum(ifa->link_lsa); + lsa.sn = get_lsa_seq(po, ifa->oa, &lsa); u32 dom = ifa->iface_id; body = originate_link_lsa_body(ifa, &lsa.length); @@ -1411,7 +1637,7 @@ originate_prefix_rt_lsa(struct ospf_area *oa) lsa.type = LSA_T_PREFIX; fill_lsa_header(po, oa, &lsa, NULL, NULL); - lsa.sn = get_seqnum(oa->pxr_lsa); + lsa.sn = get_lsa_seq(po, oa, &lsa); u32 dom = oa->areaid; body = originate_prefix_rt_lsa_body(oa, &lsa.length); @@ -1548,7 +1774,7 @@ originate_prefix_net_lsa(struct ospf_iface *ifa) lsa.type = LSA_T_PREFIX; fill_lsa_header(po, ifa->oa, &lsa, NULL, ifa); - lsa.sn = get_seqnum(ifa->pxn_lsa); + lsa.sn = get_lsa_seq(po, ifa->oa, &lsa); u32 dom = ifa->oa->areaid; body = originate_prefix_net_lsa_body(ifa, &lsa.length); @@ -1570,9 +1796,7 @@ flush_prefix_net_lsa(struct ospf_iface *ifa) OSPF_TRACE(D_EVENTS, "Flushing network prefix-LSA for iface %s", ifa->ifname); - en->lsa.sn += 1; - en->lsa.age = LSA_MAXAGE; - lsasum_calculate(&en->lsa, en->lsa_body); + flush_lsa_seq(po, ifa->oa, en); ospf_lsupd_flood(po, NULL, NULL, &en->lsa, dom, 0); flush_lsa(en, po); ifa->pxn_lsa = NULL; diff --git a/proto/ospf/topology.h b/proto/ospf/topology.h index cb87648..5cc64c9 100644 --- a/proto/ospf/topology.h +++ b/proto/ospf/topology.h @@ -47,6 +47,19 @@ struct top_graph unsigned int hash_entries_min, hash_entries_max; }; +struct seq_data { + int active; + s32 seq; + bird_clock_t last; +}; +#define SEQ_DATA_MAX 16 + +struct seq_fib_data +{ + struct fib_node fn; + struct seq_data type[SEQ_DATA_MAX]; /* One for each possible LSA types */ +}; + struct top_graph *ospf_top_new(pool *); void ospf_top_free(struct top_graph *); void ospf_top_dump(struct top_graph *, struct proto *); @@ -73,6 +86,10 @@ void originate_sum_rt_lsa(struct ospf_area *oa, struct fib_node *fn, int metric, void flush_sum_lsa(struct ospf_area *oa, struct fib_node *fn, int type); void originate_ext_lsa(struct ospf_area *oa, struct fib_node *fn, int src, u32 metric, ip_addr fwaddr, u32 tag, int pbit); void flush_ext_lsa(struct ospf_area *oa, struct fib_node *fn, int nssa); +void flush_lsa_seq(struct proto_ospf *po, struct ospf_area *oa, struct top_hash_entry *en); +void update_lsa_seq(struct proto_ospf *po, struct top_hash_entry *en, s32 sn); +void init_seq_fib(struct proto_ospf *po, struct ospf_area *oa); +void free_seq_fib(struct proto_ospf *po, struct ospf_area *oa); #ifdef OSPFv2 -- 1.7.11.5 --------------000206050504040902070200--

1 0

[PATCH 1/2] Unify filling LSA header.
by Alexander V. Chernikov 23 Feb '14

23 Feb '14

--- proto/ospf/topology.c | 165 +++++++++++++++++++++++++++++++------------------- 1 file changed, 104 insertions(+), 61 deletions(-) diff --git a/proto/ospf/topology.c b/proto/ospf/topology.c index 4af5afa..6498585 100644 --- a/proto/ospf/topology.c +++ b/proto/ospf/topology.c @@ -24,6 +24,9 @@ void originate_prefix_rt_lsa(struct ospf_area *oa); void originate_prefix_net_lsa(struct ospf_iface *ifa); void flush_prefix_net_lsa(struct ospf_iface *ifa); +static void fill_lsa_header(struct proto_ospf *po, struct ospf_area *oa, + struct ospf_lsa_header *lsa, struct fib_node *fn, struct ospf_iface *ifa); + #ifdef OSPFv2 #define ipa_to_rid(x) _I(x) #else /* OSPFv3 */ @@ -485,17 +488,8 @@ originate_rt_lsa(struct ospf_area *oa) OSPF_TRACE(D_EVENTS, "Originating router-LSA for area %R", oa->areaid); - lsa.age = 0; lsa.type = LSA_T_RT; - -#ifdef OSPFv2 - lsa.options = oa->options; - lsa.id = po->router_id; -#else /* OSPFv3 */ - lsa.id = 0; -#endif - - lsa.rt = po->router_id; + fill_lsa_header(po, oa, &lsa, NULL, NULL); lsa.sn = get_seqnum(oa->rt); u32 dom = oa->areaid; @@ -598,17 +592,8 @@ originate_net_lsa(struct ospf_iface *ifa) OSPF_TRACE(D_EVENTS, "Originating network-LSA for iface %s", ifa->ifname); - lsa.age = 0; lsa.type = LSA_T_NET; - -#ifdef OSPFv2 - lsa.options = ifa->oa->options; - lsa.id = ipa_to_u32(ifa->addr->ip); -#else /* OSPFv3 */ - lsa.id = ifa->iface_id; -#endif - - lsa.rt = po->router_id; + fill_lsa_header(po, ifa->oa, &lsa, NULL, ifa); lsa.sn = get_seqnum(ifa->net_lsa); body = originate_net_lsa_body(ifa, &lsa.length, po); @@ -781,14 +766,8 @@ originate_sum_net_lsa(struct ospf_area *oa, struct fib_node *fn, int metric) OSPF_TRACE(D_EVENTS, "Originating net-summary-LSA for %I/%d (metric %d)", fn->prefix, fn->pxlen, metric); - /* options argument is used in ORT_NET and OSPFv3 only */ - lsa.age = 0; -#ifdef OSPFv2 - lsa.options = oa->options; -#endif lsa.type = LSA_T_SUM_NET; - lsa.id = fibnode_to_lsaid(po, fn); - lsa.rt = po->router_id; + fill_lsa_header(po, oa, &lsa, fn, NULL); if ((en = ospf_hash_find_header(po->gr, dom, &lsa)) != NULL) { @@ -824,16 +803,11 @@ originate_sum_rt_lsa(struct ospf_area *oa, struct fib_node *fn, int metric, u32 OSPF_TRACE(D_EVENTS, "Originating rt-summary-LSA for %R (metric %d)", rid, metric); - lsa.age = 0; -#ifdef OSPFv2 - lsa.options = oa->options; -#endif lsa.type = LSA_T_SUM_RT; - /* In OSPFv3, LSA ID is meaningless, but we still use Router ID of ASBR */ - lsa.id = rid; - lsa.rt = po->router_id; + fill_lsa_header(po, oa, &lsa, fn, NULL); options &= OPTIONS_MASK; + if ((en = ospf_hash_find_header(po->gr, dom, &lsa)) != NULL) { if (check_sum_rt_lsa_same(en, lsa.id, metric, options)) @@ -855,18 +829,8 @@ flush_sum_lsa(struct ospf_area *oa, struct fib_node *fn, int type) struct top_hash_entry *en; struct ospf_lsa_header lsa; - lsa.rt = po->router_id; - if (type == ORT_NET) - { - lsa.id = fibnode_to_lsaid(po, fn); - lsa.type = LSA_T_SUM_NET; - } - else - { - /* In OSPFv3, LSA ID is meaningless, but we still use Router ID of ASBR */ - lsa.id = ipa_to_rid(fn->prefix); - lsa.type = LSA_T_SUM_RT; - } + lsa.type = (type == ORT_NET) ? LSA_T_SUM_NET : LSA_T_SUM_RT; + fill_lsa_header(po, oa, &lsa, fn, NULL); if ((en = ospf_hash_find_header(po->gr, oa->areaid, &lsa)) != NULL) { @@ -1083,13 +1047,9 @@ originate_ext_lsa(struct ospf_area *oa, struct fib_node *fn, int src, OSPF_TRACE(D_EVENTS, "Originating %s-LSA for %I/%d", nssa ? "NSSA" : "AS-external", fn->prefix, fn->pxlen); - lsa.age = 0; -#ifdef OSPFv2 - lsa.options = nssa ? (pbit ? OPT_P : 0) : OPT_E; -#endif + lsa.type = nssa ? LSA_T_NSSA : LSA_T_EXT; - lsa.id = fibnode_to_lsaid(po, fn); - lsa.rt = po->router_id; + fill_lsa_header(po, oa, &lsa, fn, NULL); if (nssa && pbit && ipa_zero(fwaddr)) { @@ -1104,6 +1064,10 @@ originate_ext_lsa(struct ospf_area *oa, struct fib_node *fn, int src, } } +#ifdef OSPFv2 + lsa.options = nssa ? (pbit ? OPT_P : 0) : OPT_E; +#endif + if ((en = ospf_hash_find_header(po->gr, dom, &lsa)) != NULL) { int rv = check_ext_lsa(en, fn, metric, fwaddr, tag); @@ -1167,6 +1131,91 @@ flush_ext_lsa(struct ospf_area *oa, struct fib_node *fn, int nssa) } +/** + * fill_lsa_header - fills in initial values for an LSA + * @po: OSPF protocol + * @oa: Area + * @lsa: LSA header pointer + * @fn: prefix if any + * @ida: OSPF interface if any + */ +static void +fill_lsa_header(struct proto_ospf *po, struct ospf_area *oa, struct ospf_lsa_header *lsa, + struct fib_node *fn, struct ospf_iface *ifa) +{ + u32 lsid = 0; + + /* + * Determine LSID for given LSA + * + * LSType#, used, scope, key identifier[, used identifier] + * + * OSPFv2: RFC2328 (A4.2+, 12.4.1+) + * + * Type1: singleton, area: [0001][RTRID], + * Type2: per-prefix, area: [0002][prefix][/cidr], [iface IP] + * Type3: per-prefix, area: [0003][prefix][/cidr], fibnode_to_lsaid() + * Type4: per-ASBR, area: [0004][ASBRID][/32], fibnode_to_lsaid() + * Type5: per-prefix, AS: [0005][prefix][/cidr], fibnode_to_lsaid() + * Type7: per-prefix, NSSA: [0007][prefix][/cidr], fibnode_to_lsaid() + * + * OSPFv3 mappings: RFC 5340 (4.4.3+) + * 0x2001: one/many, area: [0x2001][RTRID][/128], [0.0.0.0] + * 0x2002: per-link, area: [0x2002][link#][/128] + * 0x2003: per-prefix, area: [0x2003][prefix][/cidr], hash(prefix) + * 0x2004: per-ASBR, area: [0x2004][ASBRID][/128], RID(/128 route) + * 0x4005: per-prefix, AS: [0x4005][prefix][/cidr], hash(prefix) + * 0x2007: per-prefix, NSSA: [0x2007][prefix][/cidr], hash(prefix) + * 0x0008: per-link, link: [0x0008][iface#] + * 0x2009: one/many(RTR), area: [0x2009][??], [0.0.0.0] + * 0x2009: one/many(PX), area: [0x2009][iface#] + */ + + lsa->age = 0; +#ifdef OSPFv2 + lsa->options = oa->options; +#endif + lsa->rt = po->router_id; + + switch (lsa->type) + { +#ifdef OSPFv2 + case LSA_T_RT: + /* Singleton, LS id is router ID */ + lsid = po->router_id; + break; + case LSA_T_NET: + lsid = ipa_to_u32(ifa->addr->ip); + break; +#else + case LSA_T_RT: + lsid = 0; + break; + case LSA_T_PREFIX: + if (ifa != NULL) + lsid = ifa->iface_id; /* network prefix-LSA */ + else + lsid = 0; /* router prefix-LSA */ + break; + case LSA_T_NET: + case LSA_T_LINK: + lsid = ifa->iface_id; + break; +#endif + case LSA_T_SUM_NET: + case LSA_T_EXT: + case LSA_T_NSSA: + lsid = fibnode_to_lsaid(po, fn); + break; + case LSA_T_SUM_RT: + /* In OSPFv3, LSA ID is meaningless, but we still use Router ID of ASBR */ + lsid = ipa_to_rid(fn->prefix); + break; + } + + lsa->id = lsid; +} + #ifdef OSPFv3 static void * @@ -1216,10 +1265,8 @@ originate_link_lsa(struct ospf_iface *ifa) OSPF_TRACE(D_EVENTS, "Originating link-LSA for iface %s", ifa->ifname); - lsa.age = 0; lsa.type = LSA_T_LINK; - lsa.id = ifa->iface_id; - lsa.rt = po->router_id; + fill_lsa_header(po, ifa->oa, &lsa, NULL, ifa); lsa.sn = get_seqnum(ifa->link_lsa); u32 dom = ifa->iface_id; @@ -1362,10 +1409,8 @@ originate_prefix_rt_lsa(struct ospf_area *oa) OSPF_TRACE(D_EVENTS, "Originating router prefix-LSA for area %R", oa->areaid); - lsa.age = 0; lsa.type = LSA_T_PREFIX; - lsa.id = 0; - lsa.rt = po->router_id; + fill_lsa_header(po, oa, &lsa, NULL, NULL); lsa.sn = get_seqnum(oa->pxr_lsa); u32 dom = oa->areaid; @@ -1501,10 +1546,8 @@ originate_prefix_net_lsa(struct ospf_iface *ifa) OSPF_TRACE(D_EVENTS, "Originating network prefix-LSA for iface %s", ifa->ifname); - lsa.age = 0; lsa.type = LSA_T_PREFIX; - lsa.id = ifa->iface_id; - lsa.rt = po->router_id; + fill_lsa_header(po, ifa->oa, &lsa, NULL, ifa); lsa.sn = get_seqnum(ifa->pxn_lsa); u32 dom = ifa->oa->areaid; -- 1.7.11.5 --------------000206050504040902070200 Content-Type: text/x-patch; name="0002-Remember-sequence-number-for-LSAs.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0002-Remember-sequence-number-for-LSAs.patch"

1 0

newbie bird ospf question
by Vasiliy Tolstov 21 Feb '14

21 Feb '14

Hi all. I'm try to understand bird and bird config file and have troubles. Main question is - how can i get bird routes in specific table? For example i have ip rules: 0: from all lookup local 32763: from 10.220.0.0/16 lookup 20 32764: from 192.168.25.0/24 lookup 10 32766: from all lookup main 32767: from all lookup default How can i get bird routes in table 20 ? -- Vasiliy Tolstov,

1 0

BIRD/OSPF HUB and Spoke topology (IPv6)
by arno.odermatt＠ch.schindler.com 19 Feb '14

19 Feb '14

Dear all, I am using Bird6 (rel. 1.3.11) on Fedora20 and try to build up a HUB and Spoke topology with IPv6: we want to have 60-70 spokes, all in area 0, to propagate their /dev/eth0's IPv6 address (eg.:fed0:1:e005::1/64 -> eg.:fed0:1:e0xy::1/64 ->) through an GRE-tunnel (IPv6-address fed0:1:ffff:ffff:ffff:ffff:x:0/124 ) to the HUB, but the HUB must not propagate any such spokes IPv6 address to any other Spoke. HUB-IPv6 address: on dev/eth0 fed0:1:a001::1 Spoke1-IPv6 address: on dev/eth0 fed0:1:e005::1 Spoke2-IPv6 address: on dev/eth0 fed0:1:e006::1 Spokex-IPv6 address: on dev/eth0 fed0:1:e0xy::1 In order to full-fil this citerias, I tried to only export "directly connected" IPv6 addresses out of the HUB, but failed completely. Pls. find 2 tested configuration alternatives of the HUB below: Any idea or working config-examples, how a HUBnSpoke topology with BIRD can be implemented, is very much appreciated thx Ar Config-alternative 1) # Configure logging log syslog { debug, trace, info, remote, warning, error, auth, fatal, bug }; # Override router ID router id 172.16.128.10; # Define a route filter... filter ospf_rt_export { if net = fed0:1:a001::/64 then accept; else reject; } # The direct protocol automatically generates device routes to # all network interfaces. Can exist in as many instances as you wish # if you want to populate multiple routing tables with device routes. protocol direct { interface "GRE*-ETH6", "tap*"; # Restrict network interfaces it works with } # This pseudo-protocol performs synchronization between BIRD's routing # tables and the kernel. If your kernel supports multiple routing tables # (as Linux 2.2.x does), you can run multiple instances of the kernel # protocol and synchronize different kernel tables with different BIRD tables. protocol kernel { learn; # Learn all alien routes from the kernel persist; # Don't remove routes on bird shutdown scan time 20; # Scan kernel routing table every 20 seconds # import none; # Default is import all export all; # Default is export none # kernel table 5; # Kernel table to synchronize with (default: main) } # This pseudo-protocol watches all interface up/down events. protocol device { scan time 10; # Scan interfaces every 10 seconds } # Static routes (again, there can be multiple instances, so that you # can disable/enable various groups of static routes on the fly). protocol static { # disabled; # Disable by default # table testable; # Connect to a non-default table } protocol ospf OIPv6 { tick 2; # rfc1583compat yes; export filter ospf_rt_export; import all; area 0.0.0.0 { # stub no; interface "GRE*-ETH6" { hello 9; retransmit 6; cost 10; transmit delay 5; dead count 5; wait 50; type broadcast; # authentication simple; # password "pass"; }; }; }; Config-alternative 2) # Configure logging log syslog { debug, trace, info, remote, warning, error, auth, fatal, bug }; # Override router ID router id 172.16.128.10; # Define a route filter... filter ospf_redistconn_export { # redistribute connected if ( source = RTS_DEVICE ) then { print "net accepted:", net; ospf_metric2 = 20; accept; } else reject; } #filter sink { reject; } #filter okay { accept; } # The direct protocol automatically generates device routes to # all network interfaces. Can exist in as many instances as you wish # if you want to populate multiple routing tables with device routes. protocol direct { interface "GRE*-ETH6", "tap*"; # Restrict network interfaces it works with } # This pseudo-protocol performs synchronization between BIRD's routing # tables and the kernel. If your kernel supports multiple routing tables # (as Linux 2.2.x does), you can run multiple instances of the kernel # protocol and synchronize different kernel tables with different BIRD tables. protocol kernel { learn; # Learn all alien routes from the kernel persist; # Don't remove routes on bird shutdown scan time 20; # Scan kernel routing table every 20 seconds # import none; # Default is import all export all; # Default is export none # kernel table 5; # Kernel table to synchronize with (default: main) } # This pseudo-protocol watches all interface up/down events. protocol device { scan time 10; # Scan interfaces every 10 seconds } # Static routes (again, there can be multiple instances, so that you # can disable/enable various groups of static routes on the fly). protocol static { # disabled; # Disable by default } protocol ospf OIPv6 { tick 2; # rfc1583compat yes; export filter ospf_redistconn_export; import all; area 0.0.0.0 { # stub no; interface "GRE*-ETH6" { hello 9; retransmit 6; cost 10; transmit delay 5; dead count 5; wait 50; type broadcast; # authentication simple; # password "pass"; }; }; }; ****************************************************** Notice: The information contained in this message is intended only for use of the individual(s) named above and may contain confidential, proprietary or legally privileged information. No confidentiality or privilege is waived or lost by any mistransmission. If you are not the intended recipient of this message you are hereby notified that you must not use, disseminate , copy it in any form or take any action in reliance of it. If you have received this message in error please delete it and any copies of it and notify the sender immediately. *******************************************************

1 0

Protocols device and direct getting out of sync
by Tore Anderson 18 Feb '14

18 Feb '14

Hi, I've noticed that when adding addresses, BIRD will notice (i.e. "birdc show interface" will immediately show the newly-added address) but the direct protocol isn't notified until the periodic device scan triggers. The below console log with embedded comments shows what's happening. I'm running BIRD 1.4.0 and the config file contains simply: debug protocols all; protocol device {} protocol direct {} $ bird -d & [1] 22511 bird: device1: Initializing bird: direct1: Initializing bird: device1: Starting bird: device1: Scanning interfaces bird: device1: Connected to table master bird: device1: State changed to feed bird: Chosen router ID 87.238.42.150 according to interface em1 bird: direct1: Starting bird: direct1: Connected to table master bird: direct1: State changed to feed bird: Started bird: device1: State changed to up bird: direct1 < primary address 127.0.0.0/8 on interface lo added bird: direct1 < primary address 87.238.42.128/25 on interface em1 added bird: direct1 > added [best] 87.238.42.128/25 dev em1 bird: direct1 < primary address 100.66.7.5/32 on interface tun0 added bird: direct1 > added [best] 100.66.7.5/32 dev tun0 bird: direct1: State changed to up $ birdc show route; birdc show interface BIRD 1.4.0 ready. 100.66.7.5/32 dev tun0 [direct1 13:23:04] * (240) 87.238.42.128/25 dev em1 [direct1 13:23:04] * (240) BIRD 1.4.0 ready. lo up (index=1) MultiAccess AdminUp LinkUp Loopback Ignored MTU=65536 127.0.0.1/8 (Primary, scope host) em1 up (index=2) MultiAccess Broadcast Multicast AdminUp LinkUp MTU=1500 87.238.42.150/25 (Primary, scope univ) tun0 up (index=5) PtP Multicast AdminUp LinkUp MTU=1500 100.66.7.6/32 (Primary, opposite 100.66.7.5, scope univ) $ ip address add 192.0.2.1/32 dev lo bird: direct1 < primary address 192.0.2.1/32 on interface lo removed bird: direct1 < secondary address 127.0.0.0/8 on interface lo removed The debug messages from BIRD show up instantly. Not sure why why they say «removed», as 127.0.0.1 is unchanged, while 192.0.2.1 was *added*. $ birdc show route; birdc show interface BIRD 1.4.0 ready. 100.66.7.5/32 dev tun0 [direct1 13:23:04] * (240) 87.238.42.128/25 dev em1 [direct1 13:23:04] * (240) BIRD 1.4.0 ready. lo DOWN (index=1) MultiAccess AdminUp LinkUp Loopback Ignored MTU=65536 192.0.2.1/32 (Primary, scope univ) 127.0.0.1/8 (Unselected, scope host) em1 up (index=2) MultiAccess Broadcast Multicast AdminUp LinkUp MTU=1500 87.238.42.150/25 (Primary, scope univ) tun0 up (index=5) PtP Multicast AdminUp LinkUp MTU=1500 100.66.7.6/32 (Primary, opposite 100.66.7.5, scope univ) So here it has clearly noticed that there's an new address on lo, but for some reason it's not showing up in BIRD's routing table. Also, for some reason "lo" is now marked DOWN? bird: device1: Scanning interfaces bird: direct1 < primary address 192.0.2.1/32 on interface lo added bird: direct1 > added [best] 192.0.2.1/32 dev lo bird: direct1 < secondary address 127.0.0.0/8 on interface lo added $ birdc show route; birdc show interface BIRD 1.4.0 ready. 100.66.7.5/32 dev tun0 [direct1 13:23:05] * (240) 87.238.42.128/25 dev em1 [direct1 13:23:05] * (240) 192.0.2.1/32 dev lo [direct1 13:24:05] * (240) BIRD 1.4.0 ready. lo up (index=1) MultiAccess AdminUp LinkUp Loopback Ignored MTU=65536 192.0.2.1/32 (Primary, scope univ) 127.0.0.1/8 (Unselected, scope host) em1 up (index=2) MultiAccess Broadcast Multicast AdminUp LinkUp MTU=1500 87.238.42.150/25 (Primary, scope univ) tun0 up (index=5) PtP Multicast AdminUp LinkUp MTU=1500 So after the device scan, things look OK again. If I now proceed to add another address, it will instantly show up in the routing table, so this problem only appears to happen with the first address(es) I add (until the first time the device scan has been done after adding addresses), afterwards it seems to work fine. The impact of this behaviour is that it takes much longer than necessary for newly-added addresses to be advertised to the rest of the network (using RIP or OSPF or whatever). I can reduce the impact of the problem with using "protocol device { scan time 1; }" but it does seem a bit wasteful to poll the interfaces that often. Tore

2 2

ospf check link doesn't detect link up for vlan interfaces protocol
by Martin Kraus 17 Feb '14

17 Feb '14

Hi. I'm using a fairly standard setup on debian wheezy with bird 1.4.0 where ospf is connected to area 0 on the wan interface and I have a stub interface on a vlan interface to the local lan. interface "eth5.2001" { cost 10; stub yes; check link yes; } When I boot the router, bird doesn't detect that the vlan interface comes up and stays in the down state. I have to restart the ospf protocol so that bird rescans the interface and start propagating connected networks. During boot kernel logs that the link becomes ready ADDRCONF(NETDEV_CHANGE): eth5.2001: link becomes ready when I remove the "check link yes" parameter, it works correctly. Is this a bug or the problem is that vlan interfaces are not supported? thanks martin

1 0

Merge of bird and bird6
by Mathias Wolkert 13 Feb '14

13 Feb '14

Hello What is the status of the merging of bird and bird6? It is happening, right? /Tias

3 3

OSPF neighbor in PTMP network not removed on reloading configuration
by Cyrill Gössi 13 Feb '14

13 Feb '14

Hy BIRD community. I have a fairly simple setup of 3 routers connected in a "triangle-shape" through an ethernet network. The routers have IPs 15.0.0.1, 15.0.0.2 and 15.0.0.3. The essential part of the configuration files look as follows: // Router 15.0.0.1 protocol ospf { table baseTable; area 0.0.0.0 { interface "eth1" { type pointomultipoint; strict nonbroadcast yes; neighbors { 15.0.0.2; }; }; }; } // Router 15.0.0.2 protocol ospf { table baseTable; area 0.0.0.0 { interface "eth2" { type pointomultipoint; strict nonbroadcast yes; neighbors { 15.0.0.1; 15.0.0.3 }; }; }; } // Router 15.0.0.3 protocol ospf { table baseTable; area 0.0.0.0 { interface "eth3" { type pointomultipoint; strict nonbroadcast yes; neighbors { 15.0.0.2; }; }; }; } If I start the routers like this and sniff the traffic on "eth3" is see router 15.0.0.2 sending Hello-packets to both other routers. Routers 15.0.0.1 and 15.0.0.3 send their Hello-packets only to 15.0.0.2. So far so good! If I add the neighbor 15.0.0.1 to router 15.0.0.3 and also add neighbor 15.0.0.3 to router 15.0.0.1 and issue a "configure" to reload the configuration I see that all routers now issue 2 Hello packets - one for each of their neighbors listed in the neighbors {} section. Still - so far so good! However, if I now undo the last step (adding the neighbors to router 15.0.0.1 and 15.0.0.3) and issue the "configure" command again to let BIRD adopt to the new setting, all routers still keep on issuing exactly as before 2 Hello packets - one for each of their former neighbors. Why is that? How could I make BIRD aware that the neighbor-relationship has to be undone after having removed the neighbors from the list again? I'm sure I miss the obvious here. I will be glad about any help in this matter! Thanks in advance. Best, Cyrill

2 1

Compile error on ARM/Synology DS212+
by Michael 12 Feb '14

12 Feb '14

Hi, I am successfully using bird for OSPFv2 and OSPFv3 in a mixed network of FreeBSD, OpenBSD and Linux. Yesterday I wanted to add a Synology DS212+ to the network but it fails to compile. It seems to be some bison language issue. Maybe someone can help? Thanks in advance. Best regards, Michael DiskStation> make clean; ./configure --sysconfdir /etc --localstatedir /var/run --prefix=/usr/local --exec-prefix=/usr/local make -C obj clean make[1]: Entering directory `/usr/local/src/bird-1.4.0/obj' find . -name "*.[oa]" -o -name core -o -name depend -o -name "*.html" | xargs rm -f rm -f conf/cf-lex.c conf/cf-parse.* conf/commands.h conf/keywords.h rm -f ../bird ../birdcl ../birdc ../bird.ctl ../bird6.ctl .dep-stamp make[1]: Leaving directory `/usr/local/src/bird-1.4.0/obj' find . -name "*~" -or -name "*.[oa]" -or -name "\#*\#" -or -name TAGS -or -name core -or -name depend -or -name ".#*" | xargs rm -f checking for gcc... gcc checking whether the C compiler works... yes checking for C compiler default output file name... a.out checking for suffix of executables... checking whether we are cross compiling... no checking for suffix of object files... o checking whether we are using the GNU C compiler... yes checking whether gcc accepts -g... yes checking for gcc option to accept ISO C89... none needed checking for library containing clock_gettime... no checking build system type... armv5tel-unknown-linux-gnueabi checking host system type... armv5tel-unknown-linux-gnueabi checking for gcc... (cached) gcc checking whether we are using the GNU C compiler... (cached) yes checking whether gcc accepts -g... (cached) yes checking for gcc option to accept ISO C89... (cached) none needed checking whether POSIX threads are available... no checking whether CC supports -Wno-pointer-sign... yes checking whether CC supports -fno-strict-aliasing... yes checking whether CC supports -fno-strict-overflow... yes checking CFLAGS... -g -O2 -Wall -Wstrict-prototypes -Wno-parentheses -Wno-pointer-sign -fno-strict-aliasing -fno-strict-overflow checking how to run the C preprocessor... gcc -E checking for a BSD-compatible install... tools/install-sh -c checking for ranlib... ranlib checking for flex... flex checking for bison... bison checking for gm4... no checking for m4... m4 checking which OS configuration should we use... ./sysdep/cf/linux.h checking system-dependent directories... sysdep/linux sysdep/unix lib checking protocols... ok checking for linux/rtnetlink.h... yes checking for grep that handles long lines and -e... /bin/grep checking for egrep... /bin/grep -E checking for ANSI C header files... yes checking for sys/types.h... yes checking for sys/stat.h... yes checking for stdlib.h... yes checking for string.h... yes checking for memory.h... yes checking for strings.h... yes checking for inttypes.h... yes checking for stdint.h... yes checking for unistd.h... yes checking syslog.h usability... yes checking syslog.h presence... yes checking for syslog.h... yes checking alloca.h usability... yes checking alloca.h presence... yes checking for alloca.h... yes checking whether 'struct sockaddr' has sa_len... no checking whether byte ordering is bigendian... no checking size of char... 1 checking size of short int... 2 checking size of int... 4 checking size of long int... 4 checking size of long long int... 8 checking for 8-bit type... char checking for 16-bit type... short int checking for 32-bit type... int checking for 64-bit type... long long int checking usual alignment of structures... 8 checking characteristics of time_t... 32-bit signed checking for struct ip_mreqn... yes checking for add_history in -lhistory... yes checking for tgetent in -lncurses... yes checking for rl_callback_read_char in -lreadline... yes checking for rl_crlf in -lreadline... yes checking for rl_ding in -lreadline... yes configure: creating ./config.status config.status: creating Makefile config.status: creating obj/Makefile config.status: creating obj/Rules config.status: creating obj/sysdep/autoconf.h config.status: obj/sysdep/autoconf.h is unchanged config.status: executing merge commands Merging system-dependent modules (sysdep/linux sysdep/unix lib) BIRD was configured with the following options: Source directory: . Object directory: obj Iproute2 directory: /etc/iproute2 System configuration: ./sysdep/cf/linux.h Debugging: no POSIX threads: no Routing protocols: bgp ospf pipe rip static Client: yes DiskStation> make make -C obj all make[1]: Entering directory `/usr/local/src/bird-1.4.0/obj' echo >sysdep/paths.h "/* Generated by Makefile, don't edit manually! */" echo >>sysdep/paths.h "#define PATH_CONFIG_FILE \"/etc/bird.conf\"" echo >>sysdep/paths.h "#define PATH_CONTROL_SOCKET \"/var/run/run/bird.ctl\"" if test -n "/etc/iproute2" ; then echo >>sysdep/paths.h "#define PATH_IPROUTE_DIR \"/etc/iproute2\"" ; fi make depend make[2]: Entering directory `/usr/local/src/bird-1.4.0/obj' mkdir -p nest filter proto/bgp proto/ospf proto/pipe proto/rip proto/static client doc touch .dir-stamp set -e ; for a in lib conf ; do make -C $a depend ; done make[3]: Entering directory `/usr/local/src/bird-1.4.0/obj/lib' gcc -I../ -I../.. -MM bitops.c checksum.c event.c io.c ip.c ipv4.c krt.c lists.c log.c main.c md5.c mempool.c netlink.c patmatch.c printf.c random.c resource.c slab.c slists.c xmalloc.c >depend make[3]: Leaving directory `/usr/local/src/bird-1.4.0/obj/lib' make[3]: Entering directory `/usr/local/src/bird-1.4.0/obj/conf' m4 -P ../../conf/gen_keywords.m4 ../../conf/confbase.Y ../../sysdep/unix/config.Y ../../sysdep/unix/krt.Y ../../sysdep/linux/netlink.Y ../../nest/config.Y ../../filter/config.Y ../../proto/bgp/config.Y ../../proto/ospf/config.Y ../../proto/pipe/config.Y ../../proto/rip/config.Y ../../proto/static/config.Y >keywords.h m4 -P ../../conf/gen_commands.m4 ../../client/cmds.m4 ../../conf/confbase.Y ../../sysdep/unix/config.Y ../../sysdep/unix/krt.Y ../../sysdep/linux/netlink.Y ../../nest/config.Y ../../filter/config.Y ../../proto/bgp/config.Y ../../proto/ospf/config.Y ../../proto/pipe/config.Y ../../proto/rip/config.Y ../../proto/static/config.Y | sort >commands.h m4 -P ../../conf/gen_parser.m4 ../../conf/confbase.Y ../../sysdep/unix/config.Y ../../sysdep/unix/krt.Y ../../sysdep/linux/netlink.Y ../../nest/config.Y ../../filter/config.Y ../../proto/bgp/config.Y ../../proto/ospf/config.Y ../../proto/pipe/config.Y ../../proto/rip/config.Y ../../proto/static/config.Y >cf-parse.y bison -bcf-parse -dv -pcf_ cf-parse.y cf-parse.y: warning: 1 nonterminal useless in grammar cf-parse.y: warning: 3 rules useless in grammar cf-parse.y:521.13-19: warning: nonterminal useless in grammar: expr_us cf-parse.y:692.4-39: warning: rule useless in grammar: expr_us: expr S cf-parse.y:693.4-36: warning: rule useless in grammar: expr_us: expr MS cf-parse.y:694.4-33: warning: rule useless in grammar: expr_us: expr US make[3]: *** [cf-parse.tab.c] Broken pipe make[3]: Leaving directory `/usr/local/src/bird-1.4.0/obj/conf' make[2]: *** [depend] Error 2 make[2]: Leaving directory `/usr/local/src/bird-1.4.0/obj' make[1]: *** [.dep-stamp] Error 2 make[1]: Leaving directory `/usr/local/src/bird-1.4.0/obj' make: *** [all] Error 2 DiskStation> cd obj/conf/ DiskStation> bison -bcf-parse -dv -pcf_ cf-parse.y cf-parse.y: warning: 1 nonterminal useless in grammar cf-parse.y: warning: 3 rules useless in grammar cf-parse.y:521.13-19: warning: nonterminal useless in grammar: expr_us cf-parse.y:692.4-39: warning: rule useless in grammar: expr_us: expr S cf-parse.y:693.4-36: warning: rule useless in grammar: expr_us: expr MS cf-parse.y:694.4-33: warning: rule useless in grammar: expr_us: expr US DiskStation> cat /proc/cpuinfo Processor : Feroceon 88FR131 rev 1 (v5l) BogoMIPS : 1985.74 Features : swp half thumb fastmult edsp CPU implementer : 0x56 CPU architecture: 5TE CPU variant : 0x2 CPU part : 0x131 CPU revision : 1 Hardware : Synology 6282 board Revision : 0000 Serial : 0000000000000000 DiskStation> gcc -v Using built-in specs. Target: arm-none-linux-gnueabi Configured with: ../gcc-4.2/configure --build=i386-pc-linux-gnu --host=arm-none-linux-gnueabi --target=arm-none-linux-gnueabi --prefix=/opt --disable-nls --disable-static --with-as=/home/slug/optware/cs08q1armel/toolchain/arm-2008q1/bin/arm-none-linux-gnueabi-as --with-ld=/home/slug/optware/cs08q1armel/toolchain/arm-2008q1/bin/arm-none-linux-gnueabi-ld --enable-languages=c,c++ --disable-multilib --enable-threads --disable-libmudflap --disable-libssp --disable-libgomp --disable-libstdcxx-pch --enable-shared --enable-symvers=gnu --enable-__cxa_atexit Thread model: posix gcc version 4.2.3 DiskStation> bison -V bison (GNU Bison) 2.5.1 Written by Robert Corbett and Richard Stallman. Copyright (C) 2012 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. DiskStation> make -v GNU Make 3.82 Built for arm-none-linux-gnueabi Copyright (C) 2010 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html> This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law.

3 2