June 2022 - Bird-users - Mailing Lists

[PATCH] Bus error on ARMv7 when using OSPF
by Matthew Reeve 18 Dec '24

18 Dec '24

Hi, when using bird 2.0.8 on openwrt 21.02 (and other versions) on a Netgear R7800 router, if the OSPF protocol is used, either v2 or v3, bird immediately crashes on startup with: Fri Jun 11 14:41:11 2021 daemon.info bird: Started Fri Jun 11 14:41:11 2021 kern.err kernel: [ 3500.853248] Alignment trap: not handling instruction f44c0a1f at [<00035848>] Fri Jun 11 14:41:11 2021 kern.alert kernel: [ 3500.853283] 8<--- cut here --- Fri Jun 11 14:41:11 2021 kern.alert kernel: [ 3500.859363] Unhandled fault: alignment exception (0x801) at 0x007e0624 Fri Jun 11 14:41:11 2021 kern.alert kernel: [ 3500.862443] pgd = 0bbef4fd Fri Jun 11 14:41:11 2021 kern.alert kernel: [ 3500.868821] [007e0624] *pgd=5d6ca835, *pte=5c40b75f, *ppte=5c40bc7f This router uses an ARMv7 processor and the issue seems to be to do with memory alignment issues. I've debugged it and traced it to an access to the top_hash_entry struct. I've found that if I add the PACKED macro to the struct definition then it fixes the problem, as per this patch: --- a/proto/ospf/topology.h +++ b/proto/ospf/topology.h @@ -41,7 +41,7 @@ struct top_hash_entry u8 mode; /* LSA generated during RT calculation (LSA_RTCALC or LSA_STALE)*/ u8 nhs_reuse; /* Whether nhs nodes can be reused during merging. See a note in rt.c:add_cand() */ -}; +} PACKED; /* Prevents ospf_hash_find() to ignore the entry, for p->lsrqh and p->lsrth */ Thanks.

4 11

logging via udp
by Alexander Zubkov 13 Dec '23

13 Dec '23

Hello, Made some dirty patch for myself to allow bird to send logs via udp. But it may be useful not only for me, so posting it here. It could be useful when server experiencing high IO-load. As syslog and file operations in bird are blocking, it can be blocked on writing to it for indefinite time, which could lead to various problems like protocol timeouts. So udp logging comes in handy here. The tradeoff is that we can miss some logs if they are not processed in time. You can specify udp log destination like that: log udp [host IP|"hostname"] [port NUMBER|"portname"] ... By default it uses destination ip 127.0.0.1 and port 514. There are some constraints like not much error handling. And this destination replaces file destination, i.e. you can not use those simultaneously and it may leak descriptors and some memory probably if both are specified. It also makes a new socket every time configuration is reloaded even if there is no change in options, but this is not a great deal.

2 9

BIRD show bgp summary for cli
by Roman Bulakh 14 Jun '23

14 Jun '23

Hi, we use BIRD in our environment, and it would be very nice to have some command like `show bgp summary` in juniper. This command show information about peer IP, peer AS, last update, prefixes received/best/exported and last state. Example: bird> show bgp summary Peer AS Last state change Prfx rcvd/best/export State X.X.X.X asXXXX 2021-01-27 6786/6785/109000 Established Y.Y.Y.Y asYYYY 2020-12-16 0/0/0 Passive BGP Error: Hold timer expired The are patch created for BIRD 1.3.4 and 1.3.6, but it would be good to have this in upstream software, without rebuilding and patching. as I understand it, no functionality should be affected by these changes, this is only a visual update for cli. Old patches describes at pages: https://marc.info/?l=bird-users&m=132155489919052&w=2 http://trubka.network.cz/pipermail/bird-users/attachments/20120228/a1499be7… https://bird-users.network.narkive.com/Px6EH3yl/bird-1-3-6-show-bgp-summary…

4 3

Adding more then one bgp community at once
by Борис Коваленко 05 May '23

05 May '23

Hello! Is this possible to add many communites at once? bgp_community.add([(1,1), (1,2)]) is wrong "Setting clist attribute to non-clist value" Regards, Boris -- С уважением, Борис Коваленко

4 5

Expiration for ROA tables until when the VRP is valid?
by Robert Scheck 07 Mar '23

07 Mar '23

Hello all, rpki-client recently implemented the "expires" instruction for roa-sets that OpenBGPD provides [1][2]. As of writing, BIRD does not seem to have something similar...any chance for it? From my understanding this only applies to included ROA files with VRP, not to RTR. [1] https://man.openbsd.org/bgpd.conf#roa-set [2] https://github.com/rpki-client/rpki-client-openbsd/commit/7bf63da6ec80f37bd… Kind regards Robert Scheck

3 7

[PATCH] feature to keep protocol's state while configuring
by Alexander Zubkov 29 Jan '23

29 Jan '23

Hello. I have created a patch (attached) with new protocol option: disabled keep on|off. To keep the protocol's state while loading new config. It is useful when protocols disabled manually in the runtime, but we want to keep that state when loading new config. Patch is attached. I have made it against the current int-new branch.

3 16

[PATCH] Netlink: Propagate ecmp nexthop weight to kernel for inet6 routes
by Daniel Gröber 24 Jul '22

24 Jul '22

Previously nl_send_route would use plain nl_add_nexthop for ecmp ipv6 routes instead of adding RTA_MULTIPATH objects via nl_add_multipath. The former lacks support for the rtnh_hops field needed for setting the nexthop weight though. On the kernel side support for nexthop weights was introduced by commit 398958ae48 ("ipv6: Add support for non-equal-cost multipath") which landed in 4.16. Before this the weight will simply be ignored. Support for the ipv6 RTA_MULTIPATH attribute was added in 51ebd31815 ("ipv6: add support of equal cost multipath (ECMP)") which landed in 3.10. If this version bound isn't met installing the route will fail. --- sysdep/linux/netlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sysdep/linux/netlink.c b/sysdep/linux/netlink.c index 29b744cb..5e0b036d 100644 --- a/sysdep/linux/netlink.c +++ b/sysdep/linux/netlink.c @@ -1446,7 +1446,7 @@ dest: { case RTD_UNICAST: r->r.rtm_type = RTN_UNICAST; - if (nh->next && !krt_ecmp6(p)) + if (nh->next) nl_add_multipath(&r->h, rsize, nh, p->af, eattrs); else { -- 2.30.2

3 7

[PATCH] krt: Dump routing tables separetely on linux to avoid congestion
by Daniel Gröber 24 Jul '22

24 Jul '22

When dumping the routing table bird currently doesn't set the rtm_table netlink field to select any particular one but rather wants to get all at once. This can be problematic when multiple routing daemons are running on a system as the kernel's route modification performance goes down drasticly (by a factor of 20-200ish) when the table is being modified while it's being dumped. To avoid this situation we make bird do dumps on a per-kernel-table basis. This then allows the administrator to have multiple routing daemons use different kernel tables which sidesteps the problem. See also this discussion on the babel-users mailing list: https://alioth-lists.debian.net/pipermail/babel-users/2022-April/003902.html --- sysdep/cf/linux.h | 2 +- sysdep/linux/netlink.c | 7 ++++--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/sysdep/cf/linux.h b/sysdep/cf/linux.h index 047d3764..d6211d16 100644 --- a/sysdep/cf/linux.h +++ b/sysdep/cf/linux.h @@ -9,7 +9,7 @@ #define CONFIG_AUTO_ROUTES #define CONFIG_SELF_CONSCIOUS #define CONFIG_MULTIPLE_TABLES -#define CONFIG_ALL_TABLES_AT_ONCE +#undef CONFIG_ALL_TABLES_AT_ONCE #define CONFIG_IP6_SADR_KERNEL #define CONFIG_MC_PROPER_SRC diff --git a/sysdep/linux/netlink.c b/sysdep/linux/netlink.c index 29b744cb..003b7939 100644 --- a/sysdep/linux/netlink.c +++ b/sysdep/linux/netlink.c @@ -256,7 +256,7 @@ nl_request_dump_addr(int af) } static void -nl_request_dump_route(int af) +nl_request_dump_route(int af, int table_id) { struct { struct nlmsghdr nh; @@ -267,6 +267,7 @@ nl_request_dump_route(int af) .nh.nlmsg_flags = NLM_F_REQUEST | NLM_F_DUMP, .nh.nlmsg_seq = ++(nl_scan.seq), .rtm.rtm_family = af, + .rtm.rtm_table = table_id, }; send(nl_scan.fd, &req, sizeof(req), 0); @@ -1976,13 +1977,13 @@ nl_parse_route(struct nl_parse_state *s, struct nlmsghdr *h) } void -krt_do_scan(struct krt_proto *p UNUSED) /* CONFIG_ALL_TABLES_AT_ONCE => p is NULL */ +krt_do_scan(struct krt_proto *p) { struct nlmsghdr *h; struct nl_parse_state s; nl_parse_begin(&s, 1); - nl_request_dump_route(AF_UNSPEC); + nl_request_dump_route(AF_UNSPEC, KRT_CF->sys.table_id); while (h = nl_get_scan()) if (h->nlmsg_type == RTM_NEWROUTE || h->nlmsg_type == RTM_DELROUTE) nl_parse_route(&s, h); -- 2.30.2

3 4

[PATCH] bgp: Implement RFC 9234
by Eugene Bogomazov 12 Jul '22

12 Jul '22

Hello, RFC 9234 provides a new mechanism for route leak detection and prevention. In the attachment you can find a patch which introduces this functionality for BIRD 2.0.9.

4 12

BIRD 3.0-alpha0
by Ondrej Filip 11 Jul '22

11 Jul '22

Dear BURD users, We have something special for you today. We're releasing a multi-threaded BIRD version 3.0-alpha0 for public testing. Protocols BGP, RPKI and Pipe got their own channels which promises faster convergence and better usage of system resources. Version 3.0-alpha0 is based on the previous 2.0.8 version and some enhancements from 2.0.9 will make it into the multi-threaded branch later on. There is also a blogpost about performance comparison we have recently done between 3.0-alpha0 and 2.0.8 (the previous single-threaded version) and you can read there also other articles about the multi-threaded version. We do not recommend running this version in production setups, yet we deeply appreciate any bugreports, including memory footprint problems. You can download the tgz package at the following URLs: https://bird.network.cz/?download&tdir=3.0pre/ ftp://bird.network.cz/pub/bird/3.0pre/ Main credits goes to Maria! Thank you! Ondrej Version 3.0-alpha0 (2022-02-07) o Removal of fixed protocol-specific route attributes o Asynchronous route export o Explicit table import / export hooks o Partially lockless route attribute cache o Thread-safe resource management o Thread-safe interface notifications o Thread-safe protocol API o Adoption of BFD IO loop for general use o Parallel Pipe protocol o Parallel RPKI protocol o Parallel BGP protocol o Lots of refactoring o Bugfixes and improvements as they came along

8 17