January 2023 - Bird-users

[PATCH] Log message before aborting
by Mike Crute 12 Jan '23

12 Jan '23

Signed-off-by: Mike Crute <mike(a)crute.us> --- This is a really tiny patch but the behavior of aborting was very confusing to one of the Alpine Linux users and caused them to spend a lot of time creating and installing debug builds and tracing the BIRD process only to find a configuration error. Hopefully this patch will help to prevent such issues for future users while still providing proper debug info for developers. Original Alpine Issue: https://gitlab.alpinelinux.org/alpine/aports/-/issues/14408 Thanks! sysdep/unix/io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sysdep/unix/io.c b/sysdep/unix/io.c index 810e782d..57bed092 100644 --- a/sysdep/unix/io.c +++ b/sysdep/unix/io.c @@ -2129,7 +2129,7 @@ watchdog_sigalrm(int sig UNUSED) io_update_time(); /* We want core dump */ - abort(); + bug("Watchdog timer timed out."); } static inline void -- 2.39.0

3 5

Segfault on eval of case expression
by Jiten Kumar Pathy 07 Jan '23

07 Jan '23

Hello, The following filter causes bird2 to segfault: ```` filter test { case 2 { 1: accept; else: reject; } } ```` I have locally added `NEVER_CONSTANT` to `FI_SWITCH` instruction as a temporary workaround.

2 1

Fwd: SO_BINDTODEVICE: No such device for BGP with VRF configuration
by Ramanathan Selvamani 03 Jan '23

03 Jan '23

Hi all, I am using linux kernel 4.14.188. While i'm trying to configure VRF for BGP, i observed the below error and BGP session is not established. Kindly let me know if i am missing anything. At R1 ==== B_VRF_RED: Socket error: SO_BINDTODEVICE: No such device B_VRF_RED: Connection closed At R2 ==== B_VRF_RED: Socket error: SO_BINDTODEVICE: No such device R1 Configuration ============= function oro_set_bgp_local_as() { bgp_path.prepend(100); return true; } function bgp_aggr_nets() { } function redistribute_proto() { if ((source = RTS_BGP)) then { return true; } if (net=0.0.0.0/0) then { return false;} if ((source = RTS_DEVICE)) then { return false; } if (source = RTS_STATIC) then { if(net=0.0.0.0/0) then { return false;} if (ifname = "lo") then { return false; } else { return false; } } if ((source = RTS_CFGSET)) then { return false; } if ((source = RTS_IAPVPN)) then { return false; } if ((source = RTS_OAP)) then { return false; } if (source = RTS_OSPF) then { return false; } if (source = RTS_OSPF_IA) then { return false; } if (source = RTS_OSPF_EXT1) then { return false; } if (source = RTS_OSPF_EXT2) then { return false; } if ((source = RTS_OSPF) || (source = RTS_OSPF_IA) || (source = RTS_OSPF_EXT1) || (source = RTS_OSPF_EXT2)) then { return false; } return false; } filter export_BGP_50_0_0_2 { if ((scope = SCOPE_HOST) && (dest != RTD_BLACKHOLE)) then { reject; } if (source = RTS_APP) then { reject; } if (source = RTS_REDIRECT) then { reject; } if (source = RTS_INHERIT) then { reject; } if ((source = RTS_OAP) && defined(oap_metric)) then { bgp_med = oap_metric; } if !redistribute_proto() then {reject;} if( rmap_r1(bgp_proto)) then {accept;} else{reject;} accept; } filter import_BGP_50_0_0_2 { if((source = RTS_BGP) && rmap_r1(bgp_proto)) then { accept; } else { reject; } } protocol bgp BGP_50_0_0_2 { router id 1.1.1.1; local as 100; neighbor 50.0.0.2 as 100; graceful restart off; graceful restart time 90; enable as4 on; hold time 90; keepalive time 30; prefer older on; ipv4 { preference 56; import table on; export table on; import filter import_BGP_50_0_0_2; export filter export_BGP_50_0_0_2; }; } R2 Configuration ============= ipv4 table T_VRF_RED; function oro_set_bgp_local_as() { bgp_path.prepend(100); return true; } function redistribute_proto() { if ((source = RTS_BGP)) then { return true; } if (net=0.0.0.0/0) then { return false;} if ((source = RTS_DEVICE)) then { return false; } if (source = RTS_STATIC) then { if(net=0.0.0.0/0) then { return false;} if (ifname = "lo") then { return false; } else { return false; } } if ((source = RTS_CFGSET)) then { return false; } if ((source = RTS_IAPVPN)) then { return false; } if ((source = RTS_OAP)) then { return false; } if (source = RTS_OSPF) then { return false; } if (source = RTS_OSPF_IA) then { return false; } if (source = RTS_OSPF_EXT1) then { return false; } if (source = RTS_OSPF_EXT2) then { return false; } if ((source = RTS_OSPF) || (source = RTS_OSPF_IA) || (source = RTS_OSPF_EXT1) || (source = RTS_OSPF_EXT2)) then { return false; } return false; } protocol kernel K_VRF_RED { vrf "red"; kernel table 100; scan time 20; ipv4 { table T_VRF_RED; import all; export all; }; } protocol direct C_VRF_RED { vrf "red"; ipv4 { table T_VRF_RED; }; interface "red"; } protocol static S_VRF_RED { vrf "red"; ipv4 { table T_VRF_RED; }; route 10.10.1.0/24 blackhole; } protocol bgp B_VRF_RED { vrf "red"; router id 2.2.2.2; local 50.0.0.2 as 100; neighbor 50.0.0.1 as 100; enable as4 on; hold time 90; keepalive time 30; multihop; strict bind yes; # regular IPv4 unicast (1/1) ipv4 { table T_VRF_RED; import all; export all; }; } Thanks, Ramanathan

2 1

[PATCH] Don't treat 0/8 and 240/4 specially in IPv4 classification
by Seth David Schoen 01 Jan '23

01 Jan '23

With the exception of 0.0.0.0 and 255.255.255.255, which have additional special meanings, treat 0/8 and 240/4 as normal unicast addresses by default. This is because some people are experimenting with using these addresses as regular unicast (either for private addresses or for potential future public addresses). On the public Internet, they would still currently be regarded as bogons and one could make (maybe by default) a bogon-filtering rule in bird.conf that would not permit these addresses to be routed, e.g. with a pair of static routes route 0.0.0.0/8 prohibit; route 240.0.0.0/4 prohibit; or simply route 0.0.0.0/8 blackhole; route 240.0.0.0/4 blackhole; Dave Taht, who wrote a prior version of this patch, suggested that in any case it is better to have bogons defined in a configuration file than hard-coded in software. --- lib/ip.c | 7 +++++-- lib/ip.h | 2 +- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/lib/ip.c b/lib/ip.c index 4c5fa47f..e13bbce0 100644 --- a/lib/ip.c +++ b/lib/ip.c @@ -87,8 +87,10 @@ ip4_classify(ip4_addr ad) if (b < 0xe0) { - if (b == 0x00) /* 0.0.0.0/8 This network */ + if (a == 0x00000000) /* 0.0.0.0/32 Unset address */ return IADDR_INVALID; + /* 0.0.0.0/8 is otherwise reserved, but + * some people are using it or trying to */ if (b == 0x7f) /* 127.0.0.0/8 Loopback address */ return IADDR_HOST | SCOPE_HOST; @@ -107,7 +109,8 @@ ip4_classify(ip4_addr ad) if (a == 0xffffffff) /* 255.255.255.255 Broadcast address */ return IADDR_BROADCAST | SCOPE_LINK; - return IADDR_HOST | SCOPE_SITE; /* 240.0.0.0/4 Reserved / private */ + return IADDR_HOST | SCOPE_UNIVERSE; /* 240.0.0.0/4 Reserved / private, but + * some people are using it or trying to */ } int diff --git a/lib/ip.h b/lib/ip.h index 9eef2e16..875b9f5e 100644 --- a/lib/ip.h +++ b/lib/ip.h @@ -245,7 +245,7 @@ static inline int ip6_is_v4mapped(ip6_addr a) #define ipa_is_link_local(x) ip6_is_link_local(x) static inline int ip4_is_unicast(ip4_addr a) -{ return _I(a) < 0xe0000000; } +{ return _I(a) < 0xe0000000 || (_I(a) >= 0xf0000000 && _I(a) != 0xffffffff); } /* XXXX remove */ static inline int ipa_classify_net(ip_addr a) -- 2.25.1

8 12