February 2024 - Bird-users

point to point connection but no routes imported.
by Benoit Chesneau 18 Feb '24

18 Feb '24

Hi all, I have an issue witth the route import onbetween two machine. They are connected to each others by a vlan and at each end ana /31 is setup. I can ping between each end. R1: VLAN330(1.1.1.1) ----> R2 : VLAN330(1.1.1.2) R2( 1.1.1.2) is connected to upstreams transit and collect correctly the routes. But when I do the following config on this rouyer (R2): R2 is showing some exported routes but R1 received nothing: ``` Route change stats: received rejected filtered ignored accepted Import updates: 1 0 0 0 1 Import withdraws: 0 0 --- 0 0 Export updates: 934590 27 0 --- 934563 Export withdraws: 18 --- --- --- 18 ``` What could be the issue ? I have the following configuratiosn: R1: ``` define AS65001_IPV4 = [ 1.1.1.184/29{29,32} ]; filter ebgp_home_as65001_import { if (net.type = NET_IP4 && ! (net ~ AS65001_IPV4)) then reject; accept; } filter ebgp_home_as65001_export { protocol bgp home_65001_ipv4 { local 1.1.1.2 as 209823; neighbor 1.1.1.1 as 65001; default bgp_med 0; default bgp_local_pref 400; ipv4 { import keep filtered; import filter ebgp_home_as65001_import; export all; next hop self on; }; }; ``` R2: ``` router id 1.1.1.1; log syslog all; log "/var/log/bird.log" all; debug protocols all; watchdog warning 5 s; watchdog timeout 30 s; protocol device { scan time 30; } protocol direct { ipv4; ipv6; check link yes; } protocol kernel kernel4 { ipv4 { import all; export where source != RTS_DEVICE; }; learn off; scan time 300; } protocol kernel kernel6 { ipv6 { import all; export where source != RTS_DEVICE; }; learn off; scan time 300; } protocol static static4 { ipv4 { export all; }; # Reject default route route 0.0.0.0/0 unreachable; # main route route 1.1.1.184/29 blackhole; } filter bgp_export { if (net.type = NET_IP4 && ! (net ~ [ 1.1.1.184/29 ])) then reject; accept; } template bgp T_GW4 { local 1.1.1.1 as 65001; default bgp_med 0; default bgp_local_pref 400; multihop; ipv4 { import keep filtered; import all; export filter bgp_export; next hop self on; }; } protocol bgp ccre1_ipv4_1 from T_GW4 { neighbor 1.1.1.2 as <PUBLIC AS >; }; ``` Benoît Chesneau, Enki Multimedia — t. +33608655490 Sent with Proton Mail secure email.

2 3

[patch] SendHoldTimer BGP Error code
by Job Snijders 18 Feb '24

18 Feb '24

Dear all, IANA registered an "Early Allocation" BGP Error code for draft-ietf-idr-bgp-sendholdtimer, see https://www.iana.org/assignments/bgp-parameters/bgp-parameters.xhtml#bgp-pa… The below changeset aligns bird with IANA's Border Gateway Protocol (BGP) Parameters registry. Kind regards, Job diff --git proto/bgp/bgp.c proto/bgp/bgp.c index e97b45e6..bd6e90d6 100644 --- proto/bgp/bgp.c +++ proto/bgp/bgp.c @@ -1059,12 +1059,13 @@ bgp_send_hold_timeout(timer *t) struct bgp_conn *conn = t->data; struct bgp_proto *p = conn->bgp; + DBG("BGP: Send hold timeout\n"); + if (conn->state == BS_CLOSE) return; - /* Error codes not yet assigned by IANA */ - uint code = 4; - uint subcode = 1; + uint code = 8; + uint subcode = 0; /* Like bgp_error() but without NOTIFICATION */ bgp_log_error(p, BE_BGP_TX, "Error", code, subcode, NULL, 0); diff --git proto/bgp/packets.c proto/bgp/packets.c index 18a226fb..8320991a 100644 --- proto/bgp/packets.c +++ proto/bgp/packets.c @@ -3275,7 +3275,6 @@ static struct { { 3, 10, "Invalid network field" }, { 3, 11, "Malformed AS_PATH" }, { 4, 0, "Hold timer expired" }, - { 4, 1, "Send hold timer expired" }, /* Provisional [draft-ietf-idr-bgp-sendholdtimer] */ { 5, 0, "Finite state machine error" }, /* Subcodes are according to [RFC6608] */ { 5, 1, "Unexpected message in OpenSent state" }, { 5, 2, "Unexpected message in OpenConfirm state" }, @@ -3290,7 +3289,8 @@ static struct { { 6, 7, "Connection collision resolution" }, { 6, 8, "Out of Resources" }, { 7, 0, "Invalid ROUTE-REFRESH message" }, /* [RFC7313] */ - { 7, 1, "Invalid ROUTE-REFRESH message length" } /* [RFC7313] */ + { 7, 1, "Invalid ROUTE-REFRESH message length" }, /* [RFC7313] */ + { 8, 0, "Send hold timer expired" } /* [draft-ietf-idr-bgp-sendholdtimer] */ }; /**

2 1

Static route IPv4 via FE80::2/64 and interface issue
by Saklak, Marcin 15 Feb '24

15 Feb '24

Hello Bird Users, I have an issue with adding static route and interfaces. I use two different platform one has interface names like eth-1_1_32 and second eth-1\1\64. First one works as I would expect. First platform: ifconfig eth-1_1_32 eth-1_1_32: flags=4163<UP,BROADCAST,RUNNING,MULTICAST> mtu 1500 bird.conf: route 192.168.1.5/32 via fe80::2 % 'eth-1_1_32'; ip r 192.168.1.5 via inet6 fe80::2 dev eth-1_1_32 proto bird metric 32 but second platform with interfaces in eth-1\1\64 style didn’t work ifconfig eth-1\\1\\64 eth-1\1\64: flags=4163<UP,BROADCAST,RUNNING,MULTICAST> mtu 1500 I’ve got an error message for route 192.168.1.5/32 via fe80::2 % 'eth-1\1\64'; birdc BIRD 2.13 ready. bird> configure Reading configuration from /mnt/storage/config/bird.conf /mnt/storage/config/bird.conf:29:45 Invalid character in apostrophed symbol for: route 192.168.1.5/32 via fe80::2 % "eth-1\1\64"; bird> configure Reading configuration from /mnt/storage/config/bird.conf /mnt/storage/config/bird.conf:29:51 syntax error, unexpected TEXT for: route 192.168.1.5/32 via "fe80::2%eth-1\1\64"; no error and no entries in linux I did also tests with route 192.168.1.5/32 via "fe80::2%eth-1\\\1\\\64"; route 192.168.1.5/32 via "fe80::2%eth-1\\1\\64"; route 192.168.1.5/32 via fe80::2 % ’eth-1\\\1\\\64’; route 192.168.1.5/32 via fe80::2 % ’eth-1\\1\\64’; without any success Is it possible to make it work on both cases or there is some other way to configure such static route? Thanks, Marcin

4 4

Add random number
by Max Tulyev 11 Feb '24

11 Feb '24

Hi All, is it possible to add a random number to some variable in the filter? For example, like this: filter myfilter { if net ~ 192.168.11.0/24 then preference = preference + random(10); ...

5 8

Multiple ebgp neighbours to the same peer
by Prem Anand 11 Feb '24

11 Feb '24

Hi all, New user here I am trying to get 2 ebgp neighbours on bird to peer with a remote bgp endpoint on frr node. One between 10.100.101.1 <—> 10.100.1.1 and other between 10.100.102.1 <—> 10.100.1.1 ┌──────────────────┐ ┌─────────────┐ 10.100.101.1 │ │ensp5s0 │ │ loop1 * Bird │◄──────────────────────►┘ Frr │ │ 2.0.10 │10.100.1.2 10.100.1.1 │ loop2 * │ │ │ 10.100.102.1 │ │ │ │ └──────────────────┘ └─────────────┘ I find that only the first ebgp neighbour comes up and moves to "Established” state whereas the second ebgp neighbour remains in “Idle” state. However if I restart the bgp neighbour in “Established” state, the other bgp neighbour comes up and moves to “Established” state, but the restarted one remains in Idle state. Is there any limitation that I can’t have 2 neighbours to the same peer? Or do I have to ensure that the 2 neighbours use different tables? I have already disabled rp_filter sysctl -w net.ipv4.conf.all.rp_filter=0 Regards Prem Config ====== log "/var/log/trex/bird.log" all; debug protocols all; router id 10.100.1.2; protocol device { # scan time 10; interface "loop1"; interface "loop2"; interface "enp5s0"; } protocol bgp bgp_peer1 { local 10.100.101.1 as 65001; neighbor 10.100.1.1 as 65500; ipv4 { import all; export all; }; } protocol bgp bgp_peer2 { local 10.100.102.1 as 65002; neighbor 10.100.1.1 as 65500; ipv4 { import all; export all; }; } protocol static bird_cfg_routes { ipv4 { export all; import all; }; route 200.1.1.1/32 via 10.100.2.100; } Logs ==== bird> show protocols Name Proto Table State Since Info device1 Device --- up 13:05:16.761 bgp_peer1 BGP --- up 13:05:21.497 Established bgp_peer2 BGP --- start 13:05:16.761 Idle bird_cfg_routes Static master4 up 13:05:16.761 bird> bird> bird> bird> restart bgp_peer1 bgp_peer1: restarted bird> bird> bird> show protocols Name Proto Table State Since Info device1 Device --- up 13:05:16.761 bgp_peer1 BGP --- start 13:07:13.673 Idle bgp_peer2 BGP --- up 13:07:18.328 Established bird_cfg_routes Static master4 up 13:05:16.761 bird> show interfaces lo up (index=1) MultiAccess AdminUp LinkUp Loopback Ignored MTU=65536 127.0.0.1/8 (Preferred, scope host) ::1/128 (Preferred, scope host) mgmt0 up (index=2) MultiAccess Broadcast Multicast AdminUp LinkUp MTU=1500 192.168.121.163/24 (Preferred, scope site) fe80::b203:e9ff:fe02:100/64 (Preferred, scope link) enp5s0 up (index=3) MultiAccess Broadcast Multicast AdminUp LinkUp MTU=1500 10.100.1.2/24 (Preferred, scope site) enp6s0 up (index=4) MultiAccess Broadcast Multicast AdminUp LinkUp MTU=1500 10.100.2.1/24 (Preferred, scope site) fc00:64:2::1/120 (Preferred, scope site) fe80::b203:e9ff:fe02:102/64 (Preferred, scope link) loop1 up (index=5) MultiAccess Broadcast Multicast AdminUp LinkUp MTU=1500 10.100.101.1/24 (Preferred, scope site) fe80::78f9:91ff:fe2c:83ed/64 (Preferred, scope link) loop2 up (index=6) MultiAccess Broadcast Multicast AdminUp LinkUp MTU=1500 10.100.102.1/24 (Preferred, scope site) fe80::a4fc:34ff:fefd:11ce/64 (Preferred, scope link) bird> bird> bird> show route all Table master4: 200.1.1.1/32 unicast [bird_cfg_routes 13:05:16.761] * (200) via 10.100.2.100 on enp6s0 Type: static univ bird> Debugs ====== 2023-01-21 13:05:16.761 <TRACE> device1: Initializing 2023-01-21 13:05:16.761 <TRACE> bgp_peer1: Initializing 2023-01-21 13:05:16.761 <TRACE> bgp_peer2: Initializing 2023-01-21 13:05:16.761 <TRACE> bird_cfg_routes: Initializing 2023-01-21 13:05:16.761 <TRACE> device1: Starting 2023-01-21 13:05:16.761 <TRACE> device1: Scanning interfaces 2023-01-21 13:05:16.761 <TRACE> device1: State changed to up 2023-01-21 13:05:16.761 <TRACE> bgp_peer1: Starting 2023-01-21 13:05:16.761 <TRACE> bgp_peer1: State changed to start 2023-01-21 13:05:16.761 <TRACE> bgp_peer2: Starting 2023-01-21 13:05:16.761 <TRACE> bgp_peer2: State changed to start 2023-01-21 13:05:16.761 <TRACE> bird_cfg_routes: Starting 2023-01-21 13:05:16.761 <TRACE> bird_cfg_routes: State changed to up 2023-01-21 13:05:16.761 <TRACE> bird_cfg_routes.ipv4 > added [best] 200.1.1.1/32 unicast 2023-01-21 13:05:16.761 <INFO> Started 2023-01-21 13:05:16.762 <TRACE> bgp_peer1: Started 2023-01-21 13:05:16.762 <TRACE> bgp_peer1: Connect delayed by 5 seconds 2023-01-21 13:05:21.495 <TRACE> bgp_peer1: Connecting to 10.100.1.1 from local address 10.100.101.1 2023-01-21 13:05:21.496 <TRACE> bgp_peer1: Connected 2023-01-21 13:05:21.496 <TRACE> bgp_peer1: Sending OPEN(ver=4,as=65001,hold=240,id=0a640102) 2023-01-21 13:05:21.497 <TRACE> bgp_peer1: Got OPEN(as=65500,hold=30,id=192.168.121.230) 2023-01-21 13:05:21.497 <TRACE> bgp_peer1: Sending KEEPALIVE 2023-01-21 13:05:21.497 <TRACE> bgp_peer1: Got KEEPALIVE 2023-01-21 13:05:21.497 <TRACE> bgp_peer1: BGP session established 2023-01-21 13:05:21.497 <TRACE> bgp_peer1: State changed to up 2023-01-21 13:05:21.497 <TRACE> bgp_peer1.ipv4 < added 200.1.1.1/32 unicast 2023-01-21 13:05:23.049 <TRACE> bgp_peer1: Got UPDATE 2023-01-21 13:05:23.049 <TRACE> bgp_peer1: Got END-OF-RIB 2023-01-21 13:05:23.049 <TRACE> bgp_peer1: Sending UPDATE 2023-01-21 13:05:23.049 <TRACE> bgp_peer1: Sending END-OF-RIB 2023-01-21 13:05:30.958 <TRACE> bgp_peer1: Sending KEEPALIVE 2023-01-21 13:05:31.499 <TRACE> bgp_peer1: Got KEEPALIVE 2023-01-21 13:05:38.689 <TRACE> bgp_peer1: Sending KEEPALIVE 2023-01-21 13:05:41.499 <TRACE> bgp_peer1: Got KEEPALIVE 2023-01-21 13:05:46.842 <TRACE> bgp_peer1: Sending KEEPALIVE 2023-01-21 13:05:51.499 <TRACE> bgp_peer1: Got KEEPALIVE 2023-01-21 13:05:54.864 <TRACE> bgp_peer1: Sending KEEPALIVE 2023-01-21 13:06:01.499 <TRACE> bgp_peer1: Got KEEPALIVE 2023-01-21 13:06:03.759 <TRACE> bgp_peer1: Sending KEEPALIVE 2023-01-21 13:06:11.499 <TRACE> bgp_peer1: Got KEEPALIVE 2023-01-21 13:06:11.843 <TRACE> bgp_peer1: Sending KEEPALIVE 2023-01-21 13:06:16.764 <TRACE> device1: Scanning interfaces ... ... ... 2023-01-21 13:07:13.673 <INFO> Restarting protocol bgp_peer1 2023-01-21 13:07:13.673 <TRACE> bgp_peer1: Shutting down 2023-01-21 13:07:13.673 <TRACE> bgp_peer1: Shutdown requested 2023-01-21 13:07:13.673 <TRACE> bgp_peer1: State changed to stop 2023-01-21 13:07:13.673 <TRACE> bgp_peer1: BGP session closed 2023-01-21 13:07:13.673 <TRACE> bgp_peer1: Sending NOTIFICATION(code=6.4) 2023-01-21 13:07:13.673 <TRACE> bgp_peer1: Down 2023-01-21 13:07:13.673 <TRACE> bgp_peer1: State changed to flush 2023-01-21 13:07:13.673 <TRACE> bgp_peer2: Started 2023-01-21 13:07:13.673 <TRACE> bgp_peer2: Connect delayed by 5 seconds 2023-01-21 13:07:13.673 <TRACE> bgp_peer1: State changed to down 2023-01-21 13:07:13.673 <TRACE> bgp_peer1: Starting 2023-01-21 13:07:13.673 <TRACE> bgp_peer1: State changed to start 2023-01-21 13:07:16.761 <TRACE> device1: Scanning interfaces 2023-01-21 13:07:18.326 <TRACE> bgp_peer2: Connecting to 10.100.1.1 from local address 10.100.102.1 2023-01-21 13:07:18.327 <TRACE> bgp_peer2: Connected 2023-01-21 13:07:18.327 <TRACE> bgp_peer2: Sending OPEN(ver=4,as=65002,hold=240,id=0a640102) 2023-01-21 13:07:18.328 <TRACE> bgp_peer2: Got OPEN(as=65500,hold=30,id=192.168.121.230) 2023-01-21 13:07:18.328 <TRACE> bgp_peer2: Sending KEEPALIVE 2023-01-21 13:07:18.328 <TRACE> bgp_peer2: Got KEEPALIVE 2023-01-21 13:07:18.328 <TRACE> bgp_peer2: BGP session established 2023-01-21 13:07:18.328 <TRACE> bgp_peer2: State changed to up 2023-01-21 13:07:18.328 <TRACE> bgp_peer2.ipv4 < added 200.1.1.1/32 unicast 2023-01-21 13:07:19.880 <TRACE> bgp_peer2: Got UPDATE 2023-01-21 13:07:19.880 <TRACE> bgp_peer2: Got END-OF-RIB 2023-01-21 13:07:19.880 <TRACE> bgp_peer2: Sending UPDATE 2023-01-21 13:07:19.880 <TRACE> bgp_peer2: Sending END-OF-RIB 2023-01-21 13:07:27.298 <TRACE> bgp_peer2: Sending KEEPALIVE 2023-01-21 13:07:28.329 <TRACE> bgp_peer2: Got KEEPALIVE 2023-01-21 13:07:36.478 <TRACE> bgp_peer2: Sending KEEPALIVE

4 12

Doc suggestion - clarifying behaviour when routes are moving between protocols
by Mark Shuttleworth 09 Feb '24

09 Feb '24

Hi folks Thank you for Bird, I have enjoyed working with it over the holidays for a personal project routing between offices. Along the way I got stuck on an issue that might catch other people as well, so I thought to describe it here in the hope that docs are updated to make the behaviour more clear. I have a metropolitan area network between a few sites. Each of those sites has its own internet connection, but the MAN is much faster, so my goal was to route traffic to whichever exit point had the best bandwidth, using the different sites as backup internet gateways. At each site, I was testing the local connectivity (looking beyond simple link up to whether I could reach common sites) and then, if the link was good, adding a static route out from that location. I wanted to use Bird to export and distribute those static routes to other sites, with custom metrics to prioritise the gateways that had the best bandwidth. The expected behaviour for me was that a local, statically defined default route would be imported and have the custom metric set based on its bandwidth, and that the 'best' route would then win and be distributed by OSPF to the other sites. The problem I ran into was that the implicit protocol preference comparison prevented the local route from even being considered at all. So once a route had propagated to a site with Bird, it could not be displaced by a 'better' static route, because of the relative preferences. I ended up with a config like this, where the explicit preference solved the issue: protocol kernel { learn; # Learn alien routes from the kernel ipv4 { # Connect protocol to IPv4 table by channel import filter { if net = 0.0.0.0/0 then { # We only want default routes added manually to this machine ospf_metric2 = 1000; preference = 150; accept "Accepted default route from kernel"; } reject; }; export all; # Install all Bird routes in kernel }; } I couldn't find any documentation that explained the role of 'preference' in the import process, so I was stuck on this for an embarrassing amount of time :blush: In the end, this blog https://mk16.de/blog/bird-preference/ and some tangential comments in mailing lists led me to try the explicit preference, and that solved the issue. Apologies if I missed this in the docs, but if it isn't already covered, perhaps a more detailed explanation of the way routes are compared for import into a table would help others. Again, thank you for Bird! I think we might build it into Ubuntu in some interesting ways :) Mark

4 4

upgrade from 2.13 to 2.14
by Marek Zarychta 08 Feb '24

08 Feb '24

Dear List, today, after 299 days of machine uptime I broke 7-months lasting BGP sessions and upgraded both: FreeBSD and BIRD on our router from 13.2-STABLE to 14.0-STABLE. Now bird2-netlink-2.14 is installed and it seems to be working fine, though surprising notifications showed up in the log file: bird: /usr/local/etc/bird.conf:114:57: Inferring function check_import_v4 return type from its return value: bool bird: /usr/local/etc/bird.conf:162:58: Inferring function check_import_v6 return type from its return value: bool These lines are respectively: if (net.len < 8) || (net.len > 24) then return false; and if (net.len < 16) || (net.len > 48) then return false; I believe the warnings are harmless since "configure check" passes, but please let me know if anything is wrong with this syntax. Cheers -- Marek Zarychta

2 1

bird 2.14 segfault
by ico 08 Feb '24

08 Feb '24

Hello, We are running few routers, all Slackware Linux, 64bit. The setup is like this: router A is a gateway for whole network, speaking BGP on the outside, OSPF on the inside. There are a few routers on the inside, let's say B, C, D, ..., all of them are OSPF neighbors to A and each other. Routers B, C, etc. are running bird 2.14. I wanted to upgrade bird on router A from 1.6 to 2.14. As soon as new bird started up on A, almost all of B, C, etc. started crashing. Today I started to look into this. I found out I messed up the configuration on router A, I didn't filter out all routes from BGP and all those prefixes (IPv4 only, ~100k) were exported to OSPF. The bird on router A handled it quite OK, but routers B, C, etc. segfaulted after few seconds of exporting all those prefixes to kernel. And that happened repeatedly after bird started again. And again.. In bird's log file I found nothing. In system log were 2 lines for each segfault: [Thu Feb 1 01:51:10 2024] bird[23724]: segfault at 7ffe0e092ff8 ip 00007f2c4fb219a7 sp 00007ffe0e093000 error 6 in libc-2.33.so[7f2c4fabe000+15e000] [Thu Feb 1 01:51:10 2024] Code: 48 89 d9 49 8b 7f 28 49 8b 5f 30 48 39 df 73 bf 48 29 fb 4c 39 f3 49 0f 47 de 48 83 fb 14 76 a3 48 89 ce 48 89 da 48 89 0c 24 <e8> f4 c8 f9 ff 48 8b 0c 24 49 89 47 28 48 01 d9 eb 90 0f 1f 80 00 I will try again to upgrade router A without all those prefixes exported to OSPF, that should work I believe. I am not good at this, but maybe someone could use this information to find a bug somewhere in bird. Maybe I can help and try something with the same failing setup? Thanks ico

2 1

freebsd mbuf cluster leak with bird 2.14
by Thomas Steen Rasmussen 07 Feb '24

07 Feb '24

Hello :) Yesterday I had one of my FreeBSD routers stop forwarding because it ran out of mbuf clusters. It usually operates far from the limit, but there is (was) something leaking mbuf clusters bad, and I suspect it might be bird. ---- Some background: Due to a missing/misconfigured kernel export filter bird was repeatedly trying to export some routes to the kernel which the kernel already knew (from statically configured blackhole routes). So these errors have been repeating in the logs for some time (more than a year): Jan 11 19:09:04 dgncr2a bird[30963]: KRT: Error sending route 2a09:94c0::/29 to kernel: File exists Jan 11 19:10:04 dgncr2a syslogd: last message repeated 1 times Jan 11 19:10:04 dgncr2a bird[30963]: KRT: Error sending route 85.209.116.0/22 to kernel: File exists Jan 11 19:11:04 dgncr2a syslogd: last message repeated 1 times Over the holidays I upgraded from bird 2.0.9 to bird 2.14, as well as upgrading FreeBSD from 13-STABLE-384a885111ad to 13-STABLE-2cbd132986a7. I suspect one of these two changes made this problem appear. I made no changes to bird or router config other than the upgrades. ---- The mbuf cluster leak was pretty bad, like 8-10 clusters per second at a pretty steady rate. The kern.ipc.nmbclusters limit on my routers was around 2 million and I raised it to 4 million now. Since I had no idea what was causing the leak and I was desperate for a fix I at one point tried adding the missing kernel export filter (as to at least silence the noisy warnings in the logs), and imagine my surprise when the mbuf cluster leak stopped. I tried removing the filers again, the leak started again, and stopped again when I re-added the filters. It appears some combination of bird 2.14 and exporting routes already found in the kernel means leaking mbuf clusters like crazy. I have no idea if this is a bird or a freebsd problem but I have to start somewhere :) I can to some extent test stuff, but the routers are in production (BGP with 1 ebgp and 1 ibgp peer and no full table) so nothing too wild. Thanks! :) Best regards, Thomas Steen Rasmussen / Tykling

3 3

[PATCH] birdc: Do not execute cmd on non interactive help request
by Inrin 06 Feb '24

06 Feb '24

Hi! A pal of mine noticed that `echo <cmd> ? | birdc` executes the command <cmd> after showing it's help text is shown. I later confirmed that `birdcl` in comparison to `birdc` does not show this behaviour. Since this is a non intuitive side effect on birdc's side, here a proposed patch to align birdc and birdcl's behaviour. Please advise if fixing it on another part might be preferred. I chose birdc.c, to minimize the changes needed. Below a full report: -------------------------------------------- # Scenario ## Setup ./bird -l ## birdcl no side effect bird (v2.14)> echo 'restrict ?' | ./birdcl -l BIRD v2.14 ready. bird> restrict ? restrict Restrict current CLI session to safe commands bird> bird (v2.14)> ## birdc side effect bird (v2.14)> echo 'restrict ?' | ./birdc -l BIRD v2.14 ready. bird> restrict ? restrict Restrict current CLI session to safe commands bird> restrict Access restricted bird (v2.14)> # Expected behaviour Like birdcl, just show help and exit # Actual behaviour Executes the <cmd> after showing the help # Tested version BIRD v2.14 (birdc.c last edited on 2017, so I guess this is on all versions the same) --------------------------------------------

2 1