- Bird-users - Mailing Lists

[radv] Backport solicited ra unicast to 1.6.x?
by Boris Lytochkin 17 Jun '20

17 Jun '20

Hi. I am curious if commit 70a4320bdd44122d7a93bc71c77a9d684b3c9adc could be cherry-pick'ed into 1.6.x branch? I've tested it and it's pretty straightforward: the only thing that needs to be changed is "current_time()" with "now". Aside from that, it just works out-of-box. -- Boris Lytochkin Yandex NOC +7 (495) 739 70 00 ext 7671

1 0

Static routes BGP
by Fabiano D'Agostino 15 Jun '20

15 Jun '20

Hi everyone, I have this configuration: protocol static { ipv4 { preference 110;}; route 10.0.0.0/8 via 192.168.1.1; } protocol bgp { local as 1; neighbor x.x.x.x as x ipv4 { import all; export filter {if (net ~ [10.0.0.0/8] ) then accept; reject;}; #also tried with export all; }; } On route-server I have: ipv4 table test_4; protocol pipe Ptest_4 { table master4; peer table test_4; import all; export all; } protocol bgp Btest_4 from rsclient_4 { neighbor x.x.x.x as x multihop 15; ipv4 { table test_4; import all; export all; }; } I don’t understand why 10.0.0.0/8 is not in master4 and test_4 tables of the route-server. How could I announce a test prefix from a client to the route-server? Thanks in advance, Fabiano D'Agostino

1 0

Static IPv6 fe80 route gets dormant
by Kenth Eriksson 12 Jun '20

12 Jun '20

Why is the route fe80::7270:8bff:fee8:8081 considered dormant? OSPF and static routes have different administrative distance and the static route has lower AD (higher bird preference). # birdc BIRD v2.0.7-11-g4f6e7456 ready. bird> show route Table master4: 0.0.0.0/0 unicast [ospfv2_1 13:28:22.244] * E1 (145/21) [1] [10.210.138.65] via 10.210.138.65 on eth0 10.210.138.64/30 unicast [direct1 13:27:55.058] * (255) dev eth0 unicast [ospfv2_1 13:28:17.245] I (145/10) [10.210.138.65] dev eth0 10.210.138.66/32 unicast [direct1 13:27:53.325] * (255) dev lo 10.210.138.69/32 unicast [direct1 13:28:17.451] * (255) dev p1-2-3-4g0 unicast [ospfv2_1 13:28:29.244] E1 (145/10) [10.210.138.69] via 10.210.138.69 on p1-2-3-4g0 10.210.128.0/24 unicast [ospfv2_1 13:28:22.244] * I (145/11) [10.210.138.65] via 10.210.138.65 on eth0 Table master6: ::/0 unicast [ospfv3_2 13:28:23.245] * E1 (145/20) [1] [10.210.138.65] via fe80::7270:8bff:fee8:8081 on eth0 2a02:1420:1:138b::64/126 unicast [direct1 13:27:55.058] * (255) dev eth0 unicast [ospfv3_2 13:28:18.244] I (145/10) [10.210.138.65] dev eth0 2a02:1420:1:138b::66/128 unicast [direct1 13:27:53.332] * (255) dev lo 2a02:1420:1:138b::69/128 unicast [ospfv3_2 13:28:29.244] * E1 (145/10) [10.210.138.69] via fe80::206:9cff:fe05:b9f1 on p1-2-3-4g0 bird> show static ::/0 via fe80::7270:8bff:fee8:8081 (dormant) bird>

3 3

invalid memory read in proto/ospf/packet.c
by Slava Aseev 10 Jun '20

10 Jun '20

Hello! I recently tested the OSPF protocol implementation with AFL fuzzer and found some problem, that causes invalid memory read. https://gitlab.labs.nic.cz/labs/bird/-/blob/master/proto/ospf/packet.c#L463 The problem is that 'plen' may be less than 'hlen'. And if this happens, then 'blen' will wraps around: if (ospf_is_v2(p) && (pkt->autype != OSPF_AUTH_CRYPT)) { uint hlen = sizeof(struct ospf_packet) + sizeof(union ospf_auth2); uint blen = plen - hlen; void *body = ((void *) pkt) + hlen; if (!ipsum_verify(pkt, sizeof(struct ospf_packet), body, blen, NULL)) DROP("invalid checksum", ntohs(pkt->checksum)); } 'plen' declared here: https://gitlab.labs.nic.cz/labs/bird/-/blob/master/proto/ospf/packet.c#L443 uint plen = ntohs(pkt->length); if ((plen < sizeof(struct ospf_packet)) || ((plen % 4) != 0)) DROP("invalid length", plen); -- Best regards, Slava Aseev

3 4

Contributing to bird
by Carsten Wolfrum 09 Jun '20

09 Jun '20

Hi bird developers, I'm currently maintaining a fork of the bird mq-notif branch (merged up to version 2.0.7 + several bugfixes). Are you interested in taking a look at this fork (it's currently at https://git.dn42.us/doxz/bird)? In case I should publish my changes in any other way let me know. We're currently testing this version of that branch on a large network at dn42 ( https://dn42.net/home) Regards, Carsten

2 1

BIRD unknown character using text editor
by Fabiano D'Agostino 04 Jun '20

04 Jun '20

I am using a text editor on Windows to edit the bird.conf. When I get my bird.conf in my linux machine and I try bird -p I get this error at the end of the line: Unknown character But everything is right. How can I solve? Thanks, Fabiano

5 6

null routing multiple communities
by micah anderson 03 Jun '20

03 Jun '20

Hi, I have some peers who want community string 666 set to null route, and some who want :0, I'm trying to setup bird so when I null route a /32, it gets properly null routed everywhere. I'm stuck with the routes not actually exported to the peers, I'm not sure why. Any suggestions would be very much appreciated! define NULLROUTE = [ 198.51.100.1/32, 198.51.100.2/32 ]; define OURNETS = [ 198.252.153.0/24, 198.51.100.0/24 ]; protocol static static_bgp { import all; preference 10000; route 198.252.153.0/24 reject; route 198.51.100.0/24 blackhole; } protocol bgp special { import filter bgp_in; export filter bgp_special_bl; multihop 255; local as ASN; neighbor x.x.x.x as xxxxx; graceful restart; passive; } protocol bgp cogent_blackhole { description "Cogent blackhole server"; local as ASN; neighbor 66.28.8.1 as 174; multihop 255; import filter bgp_in; export filter bgp_nullroute; } function our_network() { return net ~ OURNETS; } function nullroute(prefix set nroute) { if our_network() then { bgp_community = -empty-; bgp_community.add((ASN,666)); return net ~ nroute; } else { reject; } } filter bgp_special_bl { nullroute(NULLROUTE); if (ASN,666) ~ bgp_community && net.len = 32 && our_network() then { bgp_community = -empty-; bgp_community.add((ASN,0)); accept; } else { reject; } } filter bgp_nullroute { nullroute(NULLROUTE); if (ASN,666) ~ bgp_community && net.len = 32 && our_network() then { accept; } else { reject; } } all of these return empty: birdc show route filter bgp_special_bl birdc show route filter bgp_nullroute birdc show route export bgp_special birdc show route export cogent_blackhole I'd love any suggestions of things to try, or if you have a better way to do this, i'm all ears. -- micah

1 0

[PATCH] Doc: Add 'ptp address' to OSPF doc overview
by Kenth Eriksson 03 Jun '20

03 Jun '20

Signed-off-by: Kenth Eriksson <kenth.eriksson(a)infinera.com> --- doc/bird.sgml | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/bird.sgml b/doc/bird.sgml index 99486eb2..7d3cbb4a 100644 --- a/doc/bird.sgml +++ b/doc/bird.sgml @@ -3389,6 +3389,7 @@ protocol ospf [v2|v3] <name> { strict nonbroadcast <switch>; real broadcast <switch>; ptp netmask <switch>; + ptp address <switch>; check link <switch>; bfd <switch>; ecmp weight <num>; -- 2.26.2

2 1

[PATCH] Netlink: Fix parsing of MPLS multipath routes
by Kazuki Yamaguchi 03 Jun '20

03 Jun '20

Add support for RTA_MULTIPATH attribute parsing for AF_MPLS routes. BIRD is capable of installing a multipath route into kernel on Linux, but it would not be seen because parsing fails. This made BIRD attempt to install the same route repeatedly. Signed-off-by: Kazuki Yamaguchi <k(a)rhe.jp> --- sysdep/linux/netlink.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/sysdep/linux/netlink.c b/sysdep/linux/netlink.c index a9e711b4dae0..622c193bb795 100644 --- a/sysdep/linux/netlink.c +++ b/sysdep/linux/netlink.c @@ -357,6 +357,11 @@ static struct nl_want_attrs nexthop_attr_want6[BIRD_RTA_MAX] = { }; #ifdef HAVE_MPLS_KERNEL +static struct nl_want_attrs nexthop_attr_want_mpls[BIRD_RTA_MAX] = { + [RTA_VIA] = { 1, 0, 0 }, + [RTA_NEWDST] = { 1, 0, 0 }, +}; + static struct nl_want_attrs encap_mpls_want[BIRD_RTA_MAX] = { [RTA_DST] = { 1, 0, 0 }, }; @@ -401,6 +406,7 @@ static struct nl_want_attrs rtm_attr_want_mpls[BIRD_RTA_MAX] = { [RTA_OIF] = { 1, 1, sizeof(u32) }, [RTA_PRIORITY] = { 1, 1, sizeof(u32) }, [RTA_METRICS] = { 1, 0, 0 }, + [RTA_MULTIPATH] = { 1, 0, 0 }, [RTA_FLOW] = { 1, 1, sizeof(u32) }, [RTA_TABLE] = { 1, 1, sizeof(u32) }, [RTA_VIA] = { 1, 0, 0 }, @@ -703,6 +709,13 @@ nl_parse_multipath(struct nl_parse_state *s, struct krt_proto *p, struct rtattr return NULL; break; +#ifdef HAVE_MPLS_KERNEL + case AF_MPLS: + if (!nl_parse_attrs(RTNH_DATA(nh), nexthop_attr_want_mpls, a, sizeof(a))) + return NULL; + break; +#endif + default: return NULL; } @@ -728,6 +741,9 @@ nl_parse_multipath(struct nl_parse_state *s, struct krt_proto *p, struct rtattr } #ifdef HAVE_MPLS_KERNEL + if (af == AF_MPLS && a[RTA_NEWDST]) + rv->labels = rta_get_mpls(a[RTA_NEWDST], rv->label); + if (a[RTA_ENCAP] && a[RTA_ENCAP_TYPE]) { if (rta_get_u16(a[RTA_ENCAP_TYPE]) != LWTUNNEL_ENCAP_MPLS) { -- 2.27.0

2 1

[PATCH] RPKI: Fix unnecessary reconnection on reconfiguration
by Kazuki Yamaguchi 03 Jun '20

03 Jun '20

Compare the new timing parameters with the old configuration, not with the temporary state of the current connection. The timing values in struct rpki_cache is updated by a version 1 End Of Data PDU, unless this behavior is suppressed by the configuration explicitly by the "keep" keyword. Consequently, every reconfiguration of BIRD triggers a reconnection even if it is not necessary. Signed-off-by: Kazuki Yamaguchi <k(a)rhe.jp> --- Hello, I reproduce the issue with the following simple RPKI protocol configuration, where "a-cache" is a Routinator which supports the RTR protocol version 1. roa4 table r4; roa6 table r6; protocol rpki { roa4 { table r4; }; roa6 { table r6; }; remote "a-cache" port 3323; debug all; } And "birdc config" causes a transport reconnection. 2020-06-03 13:59:20.085 <TRACE> rpki1: Received End of Data packet (session id: 17629, serial number: 639, refresh: 500s, retry: 600s, expire: 7200s) ... 2020-06-03 13:59:22.077 <INFO> Reconfiguring ... 2020-06-03 13:59:22.077 <TRACE> rpki1: Refresh interval changed to 3600 seconds 2020-06-03 13:59:22.077 <TRACE> rpki1: Changing from Established to Fast-Reconnect state Kazuki Yamaguchi proto/rpki/rpki.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/proto/rpki/rpki.c b/proto/rpki/rpki.c index aa07f7d9d323..3e46b6d197a8 100644 --- a/proto/rpki/rpki.c +++ b/proto/rpki/rpki.c @@ -701,7 +701,7 @@ rpki_reconfigure_cache(struct rpki_proto *p UNUSED, struct rpki_cache *cache, st #endif #define TEST_INTERVAL(name, Name) \ - if (cache->name##_interval != new->name##_interval || \ + if (old->name##_interval != new->name##_interval || \ old->keep_##name##_interval != new->keep_##name##_interval) \ { \ cache->name##_interval = new->name##_interval; \ -- 2.27.0

2 1