- Bird-users - Mailing Lists

[PATCH 2/3] BSD: don't complain about interfaces without IP addresses
by Vincent Bernat 12 Aug '19

12 Aug '19

Without this patch, BIRD complains about interfaces without an IP address: 2019-08-12 07:41:26 <ERR> KIF: Invalid interface address 0.0.0.0 for vtnet2 --- sysdep/bsd/krt-sock.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sysdep/bsd/krt-sock.c b/sysdep/bsd/krt-sock.c index f0cebd11c5b7..f92cf1a68dc6 100644 --- a/sysdep/bsd/krt-sock.c +++ b/sysdep/bsd/krt-sock.c @@ -651,6 +651,8 @@ krt_read_addr(struct ks_msg *msg, int scan) imask = ipa_from_sa(&mask); ibrd = ipa_from_sa(&brd); + if (ipa_zero(iaddr)) + return; if ((masklen = ipa_masklen(imask)) < 0) { -- 2.23.0.rc1

1 0

Anyone used 'missing lladdr' option?
by Ondrej Zajicek 08 Aug '19

08 Aug '19

Hi I just noticed that since transition to 2.0, BGP option 'missing lladdr' is not implemented. I wonder if anyone used this option or whether we should just remove it. -- Elen sila lumenn' omentielvo Ondrej 'Santiago' Zajicek (email: santiago(a)crfreenet.org) OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net) "To err is human -- to blame it on a computer is even more so."

3 3

sets in bgpmasks ?
by Clemens Schrimpe 06 Aug '19

06 Aug '19

Hello all - I wonder: Is there a "nice" syntax to have sets (lists of ASs) inside of bgpmasks? I.e., [= 123 [234, 345] * =] does not work (syntax error). Any other ideas? Thanks, Clemens

4 6

BIRD 2.0.5 build failures on RHEL/CentOS 6 and 7
by Robert Scheck 06 Aug '19

06 Aug '19

Hello all, I'm seeing the following build failures with BIRD 2.0.5 on RHEL/CentOS 6, while BIRD 2.0.4 worked fine (just did a BIRD version bump, not more): --- snipp --- BUILDSTDERR: obj/conf/cf-parse.y: In function 'cf_parse': BUILDSTDERR: obj/conf/cf-parse.y:1918: error: unknown field 'asn' specified in initializer BUILDSTDERR: obj/conf/cf-parse.y:1918: warning: missing braces around initializer BUILDSTDERR: obj/conf/cf-parse.y:1918: warning: (near initialization for '(anonymous).val.pmi.<anonymous>') BUILDSTDERR: obj/conf/cf-parse.y:1919: error: unknown field 'from' specified in initializer BUILDSTDERR: obj/conf/cf-parse.y:1919: warning: missing braces around initializer BUILDSTDERR: obj/conf/cf-parse.y:1919: warning: (near initialization for '(anonymous).val.pmi.<anonymous>') BUILDSTDERR: obj/conf/cf-parse.y:1919: error: unknown field 'to' specified in initializer BUILDSTDERR: obj/conf/cf-parse.y:2172: error: unknown field 'sym' specified in initializer BUILDSTDERR: obj/conf/cf-parse.y:2172: warning: missing braces around initializer BUILDSTDERR: obj/conf/cf-parse.y:2172: warning: (near initialization for '(anonymous).<anonymous>') BUILDSTDERR: obj/conf/cf-parse.y:2174: error: unknown field 'sa' specified in initializer BUILDSTDERR: obj/conf/cf-parse.y:2174: warning: missing braces around initializer BUILDSTDERR: obj/conf/cf-parse.y:2174: warning: (near initialization for '(anonymous).<anonymous>') BUILDSTDERR: obj/conf/cf-parse.y:2174: error: incompatible types when initializing type 'struct symbol *' using type 'struct f_static_attr' BUILDSTDERR: obj/conf/cf-parse.y:2175: error: unknown field 'da' specified in initializer BUILDSTDERR: obj/conf/cf-parse.y:2175: warning: missing braces around initializer BUILDSTDERR: obj/conf/cf-parse.y:2175: warning: (near initialization for '(anonymous).<anonymous>') BUILDSTDERR: obj/conf/cf-parse.y:2175: error: incompatible types when initializing type 'struct symbol *' using type 'struct f_dynamic_attr' BUILDSTDERR: obj/conf/cf-parse.y:2403: warning: pointer targets in assignment differ in signedness BUILDSTDERR: obj/conf/cf-parse.y:2404: warning: pointer targets in assignment differ in signedness --- snapp --- https://kojipkgs.fedoraproject.org/work/tasks/4846/36814846/build.log is the full log (will be auto-cleaned up in a couple of days). And even building on RHEL/CentOS 7 fails now (also just a BIRD version bump): --- snipp --- BUILDSTDERR: /usr/bin/ld: /tmp/ccZUW9JI.ltrans0.ltrans.o: relocation R_X86_64_32 against `.rodata' can not be used when making a shared object; recompile with -fPIC BUILDSTDERR: /usr/bin/ld: /tmp/ccZUW9JI.ltrans1.ltrans.o: relocation R_X86_64_32 against hidden symbol `sk_class.61292' can not be used when making a shared object BUILDSTDERR: /usr/bin/ld: /tmp/ccZUW9JI.ltrans2.ltrans.o: relocation R_X86_64_32 against `.rodata' can not be used when making a shared object; recompile with -fPIC BUILDSTDERR: /usr/bin/ld: /tmp/ccZUW9JI.ltrans3.ltrans.o: relocation R_X86_64_32 against `.rodata' can not be used when making a shared object; recompile with -fPIC BUILDSTDERR: /usr/bin/ld: /tmp/ccZUW9JI.ltrans4.ltrans.o: relocation R_X86_64_32 against `.rodata' can not be used when making a shared object; recompile with -fPIC BUILDSTDERR: /usr/bin/ld: /tmp/ccZUW9JI.ltrans5.ltrans.o: relocation R_X86_64_32 against `.rodata' can not be used when making a shared object; recompile with -fPIC BUILDSTDERR: /usr/bin/ld: /tmp/ccZUW9JI.ltrans6.ltrans.o: relocation R_X86_64_32 against `.rodata' can not be used when making a shared object; recompile with -fPIC BUILDSTDERR: /usr/bin/ld: /tmp/ccZUW9JI.ltrans7.ltrans.o: relocation R_X86_64_32 against `.rodata' can not be used when making a shared object; recompile with -fPIC BUILDSTDERR: /usr/bin/ld: /tmp/ccZUW9JI.ltrans8.ltrans.o: relocation R_X86_64_32S against hidden symbol `opaque_lsa_types_inv.40457' can not be used when making a shared object BUILDSTDERR: /usr/bin/ld: /tmp/ccZUW9JI.ltrans9.ltrans.o: relocation R_X86_64_32 against `.rodata' can not be used when making a shared object; recompile with -fPIC BUILDSTDERR: /usr/bin/ld: /tmp/ccZUW9JI.ltrans10.ltrans.o: relocation R_X86_64_32S against hidden symbol `proto_bgp' can not be used when making a shared object BUILDSTDERR: /usr/bin/ld: /tmp/ccZUW9JI.ltrans11.ltrans.o: relocation R_X86_64_32 against `.rodata' can not be used when making a shared object; recompile with -fPIC BUILDSTDERR: /usr/bin/ld: /tmp/ccZUW9JI.ltrans12.ltrans.o: relocation R_X86_64_32 against `.rodata' can not be used when making a shared object; recompile with -fPIC BUILDSTDERR: /usr/bin/ld: /tmp/ccZUW9JI.ltrans13.ltrans.o: relocation R_X86_64_32S against hidden symbol `proto_bgp' can not be used when making a shared object BUILDSTDERR: /usr/bin/ld: /tmp/ccZUW9JI.ltrans14.ltrans.o: relocation R_X86_64_32 against `.rodata' can not be used when making a shared object; recompile with -fPIC BUILDSTDERR: /usr/bin/ld: /tmp/ccZUW9JI.ltrans15.ltrans.o: relocation R_X86_64_32 against `.rodata' can not be used when making a shared object; recompile with -fPIC BUILDSTDERR: /usr/bin/ld: /tmp/ccZUW9JI.ltrans16.ltrans.o: relocation R_X86_64_32S against hidden symbol `bfd_wait_list.24893' can not be used when making a shared object BUILDSTDERR: /usr/bin/ld: /tmp/ccZUW9JI.ltrans17.ltrans.o: relocation R_X86_64_32 against `.rodata' can not be used when making a shared object; recompile with -fPIC BUILDSTDERR: /usr/bin/ld: /tmp/ccZUW9JI.ltrans18.ltrans.o: relocation R_X86_64_32 against `.rodata' can not be used when making a shared object; recompile with -fPIC BUILDSTDERR: /usr/bin/ld: /tmp/ccZUW9JI.ltrans19.ltrans.o: relocation R_X86_64_32 against `.rodata' can not be used when making a shared object; recompile with -fPIC BUILDSTDERR: /usr/bin/ld: /tmp/ccZUW9JI.ltrans20.ltrans.o: relocation R_X86_64_32 against `.rodata' can not be used when making a shared object; recompile with -fPIC BUILDSTDERR: /usr/bin/ld: /tmp/ccZUW9JI.ltrans21.ltrans.o: relocation R_X86_64_32 against `.rodata' can not be used when making a shared object; recompile with -fPIC BUILDSTDERR: /usr/bin/ld: /tmp/ccZUW9JI.ltrans22.ltrans.o: relocation R_X86_64_32S against `.rodata' can not be used when making a shared object; recompile with -fPIC BUILDSTDERR: /usr/bin/ld: /tmp/ccZUW9JI.ltrans23.ltrans.o: relocation R_X86_64_32 against `.rodata' can not be used when making a shared object; recompile with -fPIC BUILDSTDERR: /usr/bin/ld: /tmp/ccZUW9JI.ltrans24.ltrans.o: relocation R_X86_64_32S against `.rodata' can not be used when making a shared object; recompile with -fPIC BUILDSTDERR: /usr/bin/ld: /tmp/ccZUW9JI.ltrans25.ltrans.o: relocation R_X86_64_32 against hidden symbol `b.8691.10727' can not be used when making a shared object BUILDSTDERR: /usr/bin/ld: /tmp/ccZUW9JI.ltrans26.ltrans.o: relocation R_X86_64_32 against hidden symbol `filter_state.9587' can not be used when making a shared object BUILDSTDERR: /usr/bin/ld: /tmp/ccZUW9JI.ltrans27.ltrans.o: relocation R_X86_64_32 against `.rodata' can not be used when making a shared object; recompile with -fPIC BUILDSTDERR: /usr/bin/ld: /tmp/ccZUW9JI.ltrans28.ltrans.o: relocation R_X86_64_32S against hidden symbol `yy_accept.7797' can not be used when making a shared object BUILDSTDERR: /usr/bin/ld: /tmp/ccZUW9JI.ltrans29.ltrans.o: relocation R_X86_64_32S against hidden symbol `yypact.4429' can not be used when making a shared object BUILDSTDERR: /usr/bin/ld: /tmp/ccZUW9JI.ltrans30.ltrans.o: relocation R_X86_64_32 against `.rodata' can not be used when making a shared object; recompile with -fPIC BUILDSTDERR: /usr/bin/ld: final link failed: Nonrepresentable section on output --- snapp --- https://kojipkgs.fedoraproject.org//work/tasks/5313/36815313/build.log is the full log (will be auto-cleaned up in a couple of days). While I indeed can pass -fPIC myself (leading to a successful build), I still wonder why these changes happened and whether you maybe missed some autoconf/automake-foo to cover it "automagically". Regards, Robert

4 7

Option --runstatedir in BIRD 2.0.4 broken?
by Robert Scheck 06 Aug '19

06 Aug '19

Hello folks, when trying to use --runstatedir in BIRD 2.0.4, it looks like this here: + ./configure --build=x86_64-redhat-linux-gnu --host=x86_64-redhat-linux-gnu --program-prefix= --disable-dependency-tracking --prefix=/usr --exec-prefix=/usr --bindir=/usr/bin --sbindir=/usr/sbin --sysconfdir=/etc --datadir=/usr/share --includedir=/usr/include --libdir=/usr/lib64 --libexecdir=/usr/libexec --localstatedir=/var --sharedstatedir=/var/lib --mandir=/usr/share/man --infodir=/usr/share/info --runstatedir=/run/bird BUILDSTDERR: configure: error: unrecognized option: `--runstatedir=/run/bird' https://kojipkgs.fedoraproject.org//work/tasks/7262/33807262/build.log is the full buildsystem log. So is --runstatedir in BIRD 2.0.4 broken? When looking to configure, it feels very much like a autoconf generation issue. Because in difference to that BIRD 2.0.3 doesn't complain, buildsystem log: https://kojipkgs.fedoraproject.org//work/tasks/7292/33807292/build.log Regards, Robert

3 4

BIRD 2.0.5 and 1.6.7
by Ondrej Filip 05 Aug '19

05 Aug '19

Dear BIRD users, we just released two new versions - 1.6.7 and 2.0.5. Many thanks to Santiago and Maria! Version 1.6.7 o BFD: Support for VRFs o Several bugfixes Version 2.0.5 o OSPF Graceful restart (RFC 3623, RFC 5187) o BGP: Dynamic BGP o BGP: Promiscuous ASN mode o BGP: Mandatory option for channels o BFD: Support for VRFs o Graceful restart command o Redesigned filtering code o Many bugfixes Notes: Previous version introduced an error in handling of OSPF NSSA-LSA, causing compatibility issues with proper implementations. The error is fixed in this version, therefore there are compatibility issues in OSPF NSSA areas between this and previous version. Cheers! Ondrej

4 8

[bird-users] cz.nic debian mirror and bullseye
by Christoffer Hansen 31 Jul '19

31 Jul '19

bird-users@, Was wondering why the CZ.NIC mirror[0] only contains the packages for jessie (8), and stretch (9). Not yet buster (10) or bullseye (testing) ? Imho it makes sense to either keep [0] up-to-date with [1]. Or just plainly close the CZ.NIC mirror[0]. [0]: http://bird.network.cz/debian/dists/ [1]: https://packages.debian.org/search?keywords=bird&searchon=names&suite=all&s… -- Christoffer

1 0

segmentation fault
by Илья Шипицин 30 Jul '19

30 Jul '19

hello, I'm running bird git-master config (OSPF +BFD): ------------------------ log "/var/log/bird.log" all; debug protocols all; router id X.X.X.X; filter deny_default { if net = 0.0.0.0/0 then reject; else accept; } filter permit_white { if net ~ [ X.X.X.X/32 ,X.X.X.X/32,X.X.X.X/32 ] then accept; else reject; } filter permit_internal { if net ~ [ X.X.X.X/32 ] then accept; else reject; } filter change_src { if net = 0.0.0.0/0 then { krt_prefsrc = X.X.X.X; accept; } else accept; } protocol direct { interface "*"; ipv4; } protocol kernel { scan time 20; ipv4 { import all; export filter change_src; }; } protocol device { scan time 10; } protocol ospf External { rfc1583compat yes; ipv4 { import all; export filter permit_white; }; area 100.0.0.0 { interface "eno1.1498" { type pointopoint; authentication cryptographic; password "XXX"; bfd yes; }; interface "eno2.1500" { type pointopoint; authentication cryptographic; password "XXX"; bfd yes; }; }; } protocol ospf Internal1 { rfc1583compat yes; ipv4 { import filter deny_default; export filter permit_internal; }; area 0.0.0.20 { interface "eno1.1497" { type pointopoint; authentication cryptographic; password "XXX"; bfd yes; }; }; } protocol ospf Internal2 { rfc1583compat yes; ipv4 { import filter deny_default; export filter permit_internal; }; area 0.0.0.20 { interface "eno2.1499" { type pointopoint; authentication cryptographic; password "XXX"; bfd yes; }; }; } protocol bfd bfd_proto { interface "eno1.1497" { interval 50ms; idle tx interval 2s; multiplier 3; authentication keyed sha1; password "XXX"; }; interface "eno1.1498" { interval 50ms; idle tx interval 2s; multiplier 3; authentication keyed sha1; password "XXX"; }; interface "eno2.1500" { interval 50ms; idle tx interval 2s; multiplier 3; authentication keyed sha1; password "XXX"; }; interface "eno2.1499" { interval 50ms; idle tx interval 2s; multiplier 3; authentication keyed sha1; password "XXX"; }; } ---------------------- on SIGHUP sometimes bird crashes (gdb) bt #0 _IO_vfprintf_internal (s=0x0, format=0x4ddaf9 "%s <%s> ", ap=ap@entry=0x7f9954af06d8) at vfprintf.c:1271 #1 0x00007f9954b45287 in __fprintf (stream=<optimized out>, format=<optimized out>) at fprintf.c:32 #2 0x000000000040352b in log_commit (class=2, buf=0x7f9954af0ce0) at sysdep/unix/log.c:192 #3 0x000000000040368d in vlog (class=2, msg=0x4e5c1a "%s: Sending CTL to %I [%s%s]", args=0x7f9954af0d20) at sysdep/unix/log.c:220 #4 0x0000000000403764 in log_msg (msg=0x4e5c1a "%s: Sending CTL to %I [%s%s]") at sysdep/unix/log.c:244 #5 0x000000000045d2be in bfd_send_ctl (p=0x25bf510, s=0x25f5028, final=0) at proto/bfd/packets.c:315 #6 0x0000000000466086 in bfd_tx_timer_hook (t=0x25f6010) at proto/bfd/bfd.c:387 #7 0x000000000047b1ce in timers_fire (loop=0x25e1c58) at lib/timer.c:235 #8 0x000000000045c956 in birdloop_main (arg=0x25e1c10) at proto/bfd/io.c:526 #9 0x00007f9954ec6dd5 in start_thread (arg=0x7f9954af1700) at pthread_create.c:307 #10 0x00007f9954befead in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:111 (gdb) in case someone interested, please have a look cheers, Ilya Shipitsin

3 4

Question in relation to draft-sa-grow-maxprefix
by Hansen, Christoffer 29 Jul '19

29 Jul '19

bird-users@, https://datatracker.ietf.org/doc/draft-sa-grow-maxprefix/?include_text=1 Do the current bird 1.6.4 and 2.0.4 releases *not* support any of these mentioned scenarios? Christoffer """ 2.1. Type A: Pre-Policy Inbound Maximum Prefix Limits The Adj-RIBs-In stores routing information learned from inbound UPDATE messages that were received from another BGP speaker Section 3.2 [RFC4271]. The Type A pre-policy limit uses the number of NLRIs per Address Family Identifier (AFI) per Subsequent Address Family Identifier (SAFI) as input into its threshold comparisons. For example, when an operator configures the Type A pre-policy limit for IPv4 Unicast to be 50 on a given EBGP session, and the other BGP speaker announces its 51st IPv4 Unicast NLRI, the session MUST be terminated. Type A pre-policy limits are particularly useful to help dampen the effects of full table route leaks and memory exhaustion when the implementation stores rejected routes. 2.2. Type B: Post-Policy Inbound Maximum Prefix Limits RFC4271 describes a Policy Information Base (PIB) that contains local policies that can be applied to the information in the Routing Information Base (RIB). The Type B post-policy limit uses the number of NLRIs per Address Family Identifier (AFI) per Subsequent Address Family Identifier (SAFI), after application of the Import Policy as input into its threshold comparisons. For example, when an operator configures the Type B post-policy limit for IPv4 Unicast to be 50 on a given EBGP session, and the other BGP speaker announces a hundred IPv4 Unicast routes of which none are accepted as a result of the local import policy (and thus not considered for the Loc-RIB by the local BGP speaker), the session is not terminated. Type B post-policy limits are useful to help prevent FIB exhaustion and prevent accidental BGP session teardown due to prefixes not accepted by policy anyway. 3. Outbound Maximum Prefix Limits An operator MAY configure a BGP speaker to terminate its BGP session with a neighbor when the number of address prefixes to be advertised to that neighbor exceeds a locally configured upper limit. The BGP speaker then MUST send the neighbor a NOTIFICATION message with the Error Code Cease and the Error Subcode "Threshold reached: Maximum Number of Prefixes Send", and MAY support other actions. Reporting when thresholds have been exceeded is an implementation specific consideration, but SHOULD include methods such as Syslog [RFC5424]. By definition, Outbound Maximum Prefix Limits are Post-Policy. The Adj-RIBs-Out stores information selected by the local BGP speaker for advertisement to its neighbors. The routing information stored in the Adj-RIBs-Out will be carried in the local BGP speaker's UPDATE messages and advertised to its neighbors Section 3.2 [RFC4271]. The Outbound Maximum Prefix Limit uses the number of NLRIs per Address Family Identifier (AFI) per Subsequent Address Family Identifier (SAFI), after application of the Export Policy, as input into its threshold comparisons. For example, when an operator configures the Outbound Maximum Prefix Limit for IPv4 Unicast to be 50 on a given EBGP session, and were about to announce its 51st IPv4 Unicast NLRI to the other BGP speaker as a result of the local export policy, the session MUST be terminated. Outbound Maximum Prefix Limits are useful to help dampen the negative effects of a misconfiguration in local policy. In many cases, it would be more desirable to tear down a BGP session rather than causing or propagating a route leak. """

1 1

[PATCH] RPKI: fix allocation of hostname when using an IPv6 address
by Vincent Bernat 29 Jul '19

29 Jul '19

--- proto/rpki/config.Y | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/proto/rpki/config.Y b/proto/rpki/config.Y index a88a29a1c004..63c7105cd073 100644 --- a/proto/rpki/config.Y +++ b/proto/rpki/config.Y @@ -97,7 +97,7 @@ rpki_cache_addr: rpki_check_unused_hostname(); RPKI_CFG->ip = $1; /* Ensure hostname is filled */ - char *hostname = cfg_allocz(sizeof(INET6_ADDRSTRLEN + 1)); + char *hostname = cfg_allocz(INET6_ADDRSTRLEN + 1); bsnprintf(hostname, INET6_ADDRSTRLEN+1, "%I", RPKI_CFG->ip); RPKI_CFG->hostname = hostname; } -- 2.22.0

2 1