- Bird-users - Mailing Lists

[PATCH 00/13] Some more cleanup for configure.ac and aclocal.m4
by Ruben Kerkhof 18 Mar '17

18 Mar '17

Ruben Kerkhof (13): aclocal.m4: remove unused macro aclocal.m4: use normal macro for function use fixed width integers types from <stdint.h> Remove check for struct ip_mreqn aclocal.m4: consistently quote and indent configure.ac: fix indentation configure.ac: use AS_HELP_STRING for help text Consistently quote all macro arguments Remove dead code configure.ac: reorganize a bit Simplify check for alloca.h Simplify check for syslog.h No need to look for clock_gettime in libc aclocal.m4 | 321 ++++++++++++++++---------------- configure.ac | 502 +++++++++++++++++++++++++++++---------------------- sysdep/config.h | 22 ++- sysdep/linux/sysio.h | 10 - sysdep/unix/log.c | 8 +- 5 files changed, 459 insertions(+), 404 deletions(-) -- 2.12.0

1 11

[PATCH 02/13] aclocal.m4: use normal macro for function
by Ruben Kerkhof 18 Mar '17

18 Mar '17

--- aclocal.m4 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/aclocal.m4 b/aclocal.m4 index a13b71f3..36749c58 100644 --- a/aclocal.m4 +++ b/aclocal.m4 @@ -134,7 +134,7 @@ AC_DEFUN([BIRD_ADD_GCC_OPTION], # BIRD_CHECK_PROG_FLAVOR_GNU(PROGRAM-PATH, IF-SUCCESS, [IF-FAILURE]) # copied autoconf internal _AC_PATH_PROG_FLAVOR_GNU -m4_define([BIRD_CHECK_PROG_FLAVOR_GNU], +AC_DEFUN([BIRD_CHECK_PROG_FLAVOR_GNU], [# Check for GNU $1 case `"$1" --version 2>&1` in *GNU*) @@ -143,4 +143,4 @@ m4_ifval([$3], [*) $3;; ])esac -])# +]) -- 2.12.0

1 0

[PATCH 01/13] aclocal.m4: remove unused macro
by Ruben Kerkhof 18 Mar '17

18 Mar '17

--- aclocal.m4 | 36 ------------------------------------ 1 file changed, 36 deletions(-) diff --git a/aclocal.m4 b/aclocal.m4 index f2775422..a13b71f3 100644 --- a/aclocal.m4 +++ b/aclocal.m4 @@ -34,42 +34,6 @@ for size in 1 2 4 8; do done ]) -dnl BIRD_CHECK_ENDIAN is unused and obsolete -AC_DEFUN([BIRD_CHECK_ENDIAN], -[AC_CACHE_CHECK([CPU endianity], bird_cv_c_endian,[ -AC_TRY_RUN([ -#include <stdio.h> - -unsigned int x = 0x12345678; -unsigned char *z = (unsigned char *) &x; - -int main(void) -{ - FILE *f = fopen("conftestresult", "w"); - if (!f) return 10; - fprintf(f, "%02x %02x %02x %02x", *z, *(z+1), *(z+2), *(z+3)); - fclose(f); - exit(0); -} -],[ - endian=`cat conftestresult` - if test "$endian" = "12 34 56 78" ; then - bird_cv_c_endian=big-endian - elif test "$endian" = "78 56 34 12" ; then - bird_cv_c_endian=little-endian - fi -],[endian="test program failed"],[endian="not available, we're cross compiling"]) -if test -z "$bird_cv_c_endian" ; then - AC_MSG_RESULT($endian) - AC_MSG_ERROR([Cannot determine CPU endianity.]) - fi -]) -case $bird_cv_c_endian in - big-endian) AC_DEFINE(CPU_BIG_ENDIAN) ;; - little-endian) AC_DEFINE(CPU_LITTLE_ENDIAN) ;; - esac -]) - AC_DEFUN([BIRD_CHECK_STRUCT_ALIGN], [AC_CACHE_CHECK([usual alignment of structures],bird_cv_c_struct_align,[ AC_TRY_RUN([ -- 2.12.0

1 0

cppcheck on bird-1.6.3
by Илья Шипицин 16 Mar '17

16 Mar '17

Hello, I wonder about those issues: [sysdep/unix/krt.c:1189]: (error) Memory is allocated but not initialized: n [sysdep/unix/krt.c:1190]: (error) Memory is allocated but not initialized: n Cheers, Ilya Shipitsin

1 0

Multi core validate ospf
by Fernando Galvão 15 Mar '17

15 Mar '17

Hello guys, I wanted your help to validate if the bird with ospf is running with multi thread. I have a dell r410 server with 2 x56 quad core xeon processors totaling 16 cores. This server was serving pppoe server with accel-ppp + quagga ospf v4 / v6 with route summarization. With 2,000 sessions and going on around 1GB, the quagga process blew the cpu and all sessions were disconnected. The problem is that the quagga is single core so it uses only one core. Looking, I've seen that the bird is multi-core. I started to run, I have 2,200 pppoe sessions but still early to get high traffic, I'm passing 300MB and the bird has peaks in a 25% core. I would like to know if I have validate that it is distributing the process between CPUs? Or if you have any configuration for this. Fernando Galvão Wantel Telecom +55 87 3866-5200

4 4

Some autoconf cleanups
by Ruben Kerkhof 14 Mar '17

14 Mar '17

The goal of this series is to make it possible to run autoreconf on a git checkout. It does this by moving configure.in to configure.ac and fixes deprecation warnings and errors generated by autoheader. I have some follow up patches with more cleanups, but this series is already large enough as it is.

2 16

[PATCH,RFC 0/3] Secondary remote AS support for protocol BGP.
by Lennert Buytenhek 14 Mar '17

14 Mar '17

Hi! These patches implement a way of simplifying BGP topology migrations that involve changing AS numbers on one or both ends of BGP sessions. The first patch allows a BGP peer to connect to us using either of two different AS numbers specified in our local config. (See the commit message for that patch for more details.) The second patch fixes what I think is a reconfiguration bug for protocol BGP and is in the stack mainly because of patch three. The third patch avoids bouncing a BGP session when reconfiguring its BGP protocol if all we're changing is adding a secondary remote AS to the protocol or changing one of two remote AS numbers that is not currently being advertised by the peer. (Again, see the commit message for that patch for more details.) Any feedback appreciated! And even if you happen not to like patch 3, I hope that you'd still be willing to consider patch 1 (and 2). Cheers, Lennert

3 13

[PATCH] Allow address scopes for non-link-local addresses
by Fritz Grimpen 14 Mar '17

14 Mar '17

Hi. Here is a small patch which allows non-zero address scopes on non-link-local addresses. This is required to create connections inside a VRF domain, as the Linux kernel documentation states. In combination with multiple RIBs and FIBs, this makes Bird completely VRF-capable. Therefore, this patch is neccessary to integrate Bird in non-trivial routing setups without the use of multiple network namespaces. It would be nice when you accept this patch. Kind regards, Fritz Grimpen

2 2

Re: multithreading ospf
by Fernando Galvão 13 Mar '17

13 Mar '17

> > Hello guys, > > I wanted your help to validate if the bird with ospf is running with multi thread. > > I have a dell r410 server with 2 x56 quad core xeon processors totaling 16 cores. > > This server was serving pppoe server with accel-ppp + quagga ospf v4 / v6 with route summarization. > > With 2,000 sessions and going on around 1GB, the quagga process blew the cpu and all sessions were disconnected. The problem is that the quagga is single core so it uses only one core. > > Looking, I've seen that the bird is multi-core. I started to run, I have 2,200 pppoe sessions but still early to get high traffic, I'm passing 300MB and the bird has peaks in a 25% core. I would like to know if I have validate that it is distributing the process between CPUs? > > Or if you have any configuration for this. > > Fernando Galvão > Wantel Telecom > +55 87 3866-5200 > > >

3 4

bgp proto bug with add paths in bird 1.6.3
by Lennert Buytenhek 11 Mar '17

11 Mar '17

Hi! bgp_init() in proto/bgp/bgp.c does: P->accept_ra_types = c->secondary ? RA_ACCEPTED : RA_OPTIMAL; and then bgp_rx_open() in proto/bgp/packets.c does: if (p->add_path_tx) p->p.accept_ra_types = RA_ANY; As bgp_init() seems to only be called at configuration time, this means that if you have add path tx, and you have a peer that advertises rx add path and then reconnects without advertising rx add path, you will still have RA_ANY set on the sending side and not have the correct behavior of only sending the optimal route. (This is easy to verify.) Not entirely sure how you'd want to fix this, but perhaps replicating the RA_ACCEPTED / RA_OPTIONAL assignment in bgp_rx_open() (or just moving it there) would do the trick? Cheers, Lennert

2 3