- Bird-users - Mailing Lists

Incorrect usage of dirname() in sysdep/unix/main.c causes segfault
by Henrique de Moraes Holschuh 26 Mar '12

26 Mar '12

According to POSIX, dirname() is allowed to modify the string passed to it. In fact, according to dirname(3), glibc's will do just that when libgen.h is in use. The manpage even warns you that it will segfault when passed a constant that cannot be modified... Well, I hit that bug and it took a while to track it down. --enable-debug seems to link a different dirname() that is less crappy, so the bug wouldn't show up in debug builds. The attached patch explains it better. -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh

2 2

[PATCH] Allow to match on the kernel route protocol in filters
by Jérémie Dimino 25 Mar '12

25 Mar '12

Hi, I made a patch that allow to access the protocol field of routes learned from the kernel. The goal is to be able to filter on the protocol that added the route. For example FDN [1] need it to filter routes added by a patched version of l2tpns [2]. The patch adds two attributes: krt_source and krt_proto. krt_source is an enum which export the u.krt.src field of routes and krt_proto is an integer which export the u.krt.proto field. The patch also adds constants from /etc/iproute2/rt_protos. [1] http://www.fdn.fr/ [2] http://dolka.fr/code/l2tpns.git Cheers, -- Jérémie

3 6

New release 1.3.7!
by Ondrej Filip 23 Mar '12

23 Mar '12

Hi! Santiago did a great job again and we have a new version! Changes: Version 1.3.7 o Route Origin Authorization basics. o RIPng working again. o Extended clist operations in filters. o Fixes several bugs in BSD iface handling. o Several minor bugfixes and enhancements.

3 3

adding bgpsec to bird
by Michael Baer 20 Mar '12

20 Mar '12

Hi All, We've been working on an extension to BIRD supporting the BGPSec protocol that is currently being discussed in the IETF SIDR Working Group. And I had some questions I wanted to ask the BIRD developers. If the user list isn't the appropriate forum, let me know and we can discuss it elsewhere or offline. We've made some initial progress, although it's not even to what I would call an Alpha stage yet. Our current plan is to have a beta/alpha working by the beginning of Summer and to continue work on it for up to a year afterwords. We would like to have the work contributed back to the BIRD project. Which brings me to the questions I had. Is the BIRD team interested in the contribution? Are we in conflict with any work you are doing to support BGPSec? (I haven't seen any mention on the user list, but I don't know if there has been any work otherwise). Assuming you are interested, besides that our code should have a compatible license, i.e. GPL, and it should try match the coding style of the files that are modified, are there any other requirements or desires that you may have regarding code enhancements and contributions to the BIRD project? Thanks, Mike -- Michael Baer baerm(a)tislabs.com

3 6

community features request
by Oleg 19 Mar '12

19 Mar '12

Hi, list. I have the next situation. I want to filter our AS communities in an input filter. So, i made the next function for this: function filter_communities(pair set allowed) clist comm; pair set def_allowed; bool is_empty; { def_allowed = [(myas,1000), (myas,1001), (myas,1002)]; if ( (0,0) ~ allowed ) then allowed = def_allowed; comm = filter(bgp_community, allowed); bgp_community.delete([(myas,*)]); is_empty = true; if (( (myas,1000) ~ comm ) && ( (myas,1000) ~ allowed )) then { is_empty = false; bgp_community.add((myas,1000)); } if (( (myas,1001) ~ comm ) && ( (myas,1001) ~ allowed )) then { is_empty = false; bgp_community.add((myas,1001)); } if (( (myas,1002) ~ comm ) && ( (myas,1002) ~ allowed )) then { is_empty = false; bgp_community.add((myas,1002)); } if (( is_empty ) && ( (myas,1000) ~ allowed )) then bgp_community.add((myas,1000)); } Code overview: We have some allowed communities passed in function as a parameter (if we pass [(0,0)], then it treats like a NULL and default communities list is applied (def_allowed)). At first, we delete all not allowed our AS communities from bgp_community, but preserve not our AS communities. Then we insert default community (myas,1000), if we have no our AS community at all and (myas,1000) is allowed. So, what's wrong. It works fine, but the code seems some strange: 1. If we have empty clist or empty pair set constructions, we can do if ( allowed = [] ) then instead of hack with (0,0) community; 2. add(C,P) cann't get pair set like delete(C,P) do and 3. we have incompatible types clist and pair set (Why? Why cann't pair set be modifiable?). So we cann't simply do comm = filter(bgp_community, allowed); bgp_community.delete([(51230,*)]); bgp_community.add(comm); instead of tons of lines. So, if all of above would be true, we could write: function filter_communities(pair set allowed) pair set comm; pair set def_allowed; { def_allowed = [(myas,1000), (myas,1001), (myas,1002)]; if ( allowed = [] ) then allowed = def_allowed; comm = filter(bgp_community, allowed); bgp_community.delete([(myas,*)]); bgp_community.add(comm); if (( comm = [] ) && ( (myas,1000) ~ allowed )) then bgp_community.add((myas,1000)); } May be i do something wrong and my code can be simplified? Thanks.

3 8

Some small CLI changes
by Alexander V. Chernikov 19 Mar '12

19 Mar '12

Hello list! Two small additions: 1) Type filter can be specified in 'show symbols' command, like: 'show symbols table' 2) lsa database can be filtered by adv-router ID, like: 'show ospf lsadb advrouter 1.2.3.4' P.S. switch {} in show symbols is added in hope that a bit more info will be added when printing other data (it prints table type in "mpls/reflector" version, for example)

2 1

exporting routes to kernel
by Tomasz Głuch 19 Mar '12

19 Mar '12

Hi! I'm trying configure BIRD 1.3.6 on Centos 5.8. I have 2 routing tables. In default table I've routes imported from kernel, static and direct protocols: root@tomasz:~# ip ro s 10.110.10.5 dev eth0 proto bird 192.168.100.0/24 dev virbr1 proto kernel scope link src 192.168.100.1 10.110.10.0/24 dev eth0 proto kernel scope link src 10.110.10.27 192.168.122.0/24 dev virbr0 proto kernel scope link src 192.168.122.1 169.254.0.0/16 dev eth0 scope link metric 1000 default via 10.110.10.1 dev eth0 metric 100 root@tomasz:~# birdc BIRD 1.3.6 ready. bird> show route 0.0.0.0/0 via 10.110.10.1 on eth0 [kernel1 12:55] * (10) 192.168.100.0/24 dev virbr1 [direct1 12:55] * (240) 192.168.122.0/24 dev virbr0 [direct1 12:55] * (240) 10.110.10.5/32 dev eth0 [static1 12:55] * (200) 10.110.10.0/24 dev eth0 [direct1 12:55] * (240) Now, I would like to copy them to table 'testable'. Pipe protocol is configured with import all and export all filters. Bird's table testable includes all routes according to filters, but only static routes are exported to kernel2 table testable: bird> show route table testable 0.0.0.0/0 via 10.110.10.1 on eth0 [kernel1 12:55] * (10) 192.168.100.0/24 dev virbr1 [direct1 12:55] * (240) 192.168.122.0/24 dev virbr0 [direct1 12:55] * (240) 10.110.10.5/32 dev eth0 [static1 12:55] * (200) 10.110.10.0/24 dev eth0 [direct1 12:55] * (240) bird> q root@tomasz:~# ip ro s table testable 10.110.10.5 dev eth0 proto bird default via 10.110.10.1 dev eth0 proto bird In debug logs I spotted lines: Mar 15 12:55:53 tomasz bird: pipe1 < added 192.168.100.0/24 dev virbr1 Mar 15 12:55:53 tomasz bird: pipe1 < rejected by protocol 192.168.100.0/24 dev virbr1 It seems to be filtered out by krt_import_control() in krt.c. I prepare dirty hack as below and routes are propagated as I want. diff --git a/sysdep/unix/krt.c b/sysdep/unix/krt.c index 0fb8c4f..55a1a0a 100644 --- a/sysdep/unix/krt.c +++ b/sysdep/unix/krt.c @@ -770,7 +770,7 @@ krt_import_control(struct proto *P, rte **new, ea_list **attrs, struct linpool * if (!KRT_CF->devroutes && (e->attrs->dest == RTD_DEVICE) && - (e->attrs->source != RTS_STATIC_DEVICE)) + (!(e->attrs->source == RTS_STATIC_DEVICE || e->attrs->source == RTS_DEVICE))) return -1; if (!krt_capable(e)) Is there any reason to not accept routes other than RTS_STATIC_DEVICE, assuming that possible loops are filtered out? Is other approach for this issue? The same problem occurs when routes origin from OSPF. Minimal config which problem occurs on: router id 10.110.10.27; table testable; debug protocols all; protocol direct { interface "*"; export all; } protocol kernel { learn; # Learn all alien routes from the kernel persist; # Don't remove routes on bird shutdown scan time 20; # Scan kernel routing table every 20 seconds export all; # Default is export none } protocol kernel { table testable; persist; # Don't remove routes on bird shutdown scan time 20; # Scan kernel routing table every 20 seconds export all; # Default is export none kernel table 252; # Kernel table to synchronize with (default: main) } protocol device { scan time 10; # Scan interfaces every 10 seconds } protocol static { route 10.110.10.5/32 via "eth0"; } protocol pipe { peer table testable; import all; # default is all export all; # default is none } -- Best Regards, Tomasz Głuch groups @ tomaszgluch.pl

3 4

BIRD-1.3.6 - show bgp summary command
by Dean Belev 14 Mar '12

14 Mar '12

Hi there, Is the patch for 1.3.4 (http://marc.info/?l=bird-users&m=132155489919052&w=2 <http://marc.info/?l=bird-users&m=132155489919052&w=2>) usable for 1.3.6 ? We have a strange behavior when we tried to implement it for 1.3.6 - the process stops right after the Enter is triggered. But the "?" function works correctly. Best~ -- Dean Belev Network Management Team Neterra Ltd. Sofia, Bulgaria Phone: +359 2 974 33 11 Fax: +359 2 975 34 36 Mobile: +359 886 663 123 http://www.neterra.net

7 12

bird reflector: release 20120307 - Release candidate 1
by Alexander V. Chernikov 14 Mar '12

14 Mar '12

Hello list! Changelog: * Fix pipe transparent mode * Fix duplicated interfaces in OSPF in initial stage (reported by Nikita Shirokov) * Fix several major bugs in VPNv4 family (reported by Marek Zbroch) * Send withdraw label as asked by RFC3107 * Implement show symbols [table|protocol|etc..] filtering * Implement show ospf lsadb filtering by router id * Merge IPv6 macro/functions * Permit RD / IPv6 to be used in 'show route' for VPN/labeled families Link: http://bird.mpls.in/distfiles/bird/bird-20120307.tar.gz Documentation: http://bird.mpls.in/projects/mpls-bird/wiki/Bird_rr Git: http://bird.mpls.in/projects/mpls-bird/repository/show?rev=l3vpn Setup: Do configure with --enable-mpls switch (FreeBSD example) ./configure --prefix=/usr/local --mandir=/usr/local/man --infodir=/usr/local/info/ --build=amd64-portbld-freebsd8.2 --enable-mpls FreeBSD users can edit net/bird-devel port, change its version to 20120307 and call 'make makesum' This version is considered as RC1. Feel free to send questions/suggestions/patches.

1 0

BGP Local preference for prefix
by Marek Wajdzik 13 Mar '12

13 Mar '12

Is there a possibility to change bgp local preference of single prefix in import filter? If yes, then how to do it? Rgrds

3 2