- Bird-users - Mailing Lists

RE: BIRD is taking too much time to converge 106362 prefixes from a non-client iBGP neighbor
by saifullah＠fiberathome.net 13 Apr '23

13 Apr '23

Dear All, Please help me regarding this. Thanks & Regards Abu Nasar Md. Saifullah From: saifullah(a)fiberathome.net <saifullah(a)fiberathome.net> Sent: Wednesday, April 12, 2023 10:19 PM To: 'bird-users(a)network.cz' <bird-users(a)network.cz> Subject: BIRD is taking too much time to converge 106362 prefixes from a non-client iBGP neighbor Dear Concern, After installing BIRD, I made iBGP neighbor with 8 routers. From a non-client neighbor it should receive about 106362 prefixes but I found it is taking huge time to process and converge the mentioned prefixes. It took about 35 minutes to process, converge and advertise prefixes to other neighbors. Is it normal behavior or am I missing sometime to make faster convergence? Kindly suggest me. Related configuration parts are given below (actual IP and names are changed): router id <local_ip>; vpn4 table vpntab4; template bgp template_rr_non_client { local <local_ip> as as_number; neighbor as as_number; vpn4 mpls { table vpntab4; import all; export all; }; } protocol bgp <non_client_neighbor> from template_rr_non_client { neighbor non_client_neighbor_ip; } template bgp template_rr_client2 { local <local_ip> as as_number; neighbor as as_number; rr client; rr cluster id <local_ip>; vpn4 mpls { table vpntab4; import all; export all; }; } # protocol bgp client1 from template_rr_client2 { neighbor client1_ip; . . . } protocol bgp client7 from template_rr_client2 { neighbor client7_ip; } Thanks & Regards Saifullah Nasar Connecting our future with light

1 0

How to prohibit resetting bgp neighborship after any bgp config change in bird.conf
by saifullah＠fiberathome.net 09 Apr '23

09 Apr '23

3 6

Bird 3.0-alpha0 crash on start
by Francois Espinet 05 Apr '23

05 Apr '23

Hello, I am currently trying bird out in a route collector scenario. We have around 50 devices all sending around 1.2M routes. I initially started with bird 2.0.12, but the CPU it stuck at 100%, and the debug logs has a lot of "channel reload burst split (max_feed=-1) ». So I wanted to try bird 3.0, but I am getting the following logs (using the -d flag), and the router crashes just after starting: bird: Started bird: Trying to lock in a bad order Aborted Any idea what could be the issue there ? Here is my config: timeformat base iso long; timeformat log iso long; timeformat protocol iso long; timeformat route iso long; router id X.X.X.X; hostname "route-collector"; attribute int roa_status1; attribute int roa_status2; roa4 table roa4_1; roa4 table roa4_2; roa6 table roa6_1; roa6 table roa6_2; ipv4 table pb4 ipv6 table pb6; filter flag_rpki { if bgp_path.len = 0 || bgp_path.last = 16276 then accept; if roa_check(roa4_1, net, bgp_path.last) = ROA_INVALID then roa_status1=1; if roa_check(roa4_1, net, bgp_path.last) = ROA_UNKNOWN then roa_status1=2; if roa_check(roa4_1, net, bgp_path.last) = ROA_VALID then roa_status1=3; if roa_check(roa4_2, net, bgp_path.last) = ROA_INVALID then roa_status2=1; if roa_check(roa4_2, net, bgp_path.last) = ROA_UNKNOWN then roa_status2=2; if roa_check(roa4_2, net, bgp_path.last) = ROA_VALID then roa_status2=3; accept; } protocol bgp PB { local X.X.X.X as 16276; neighbor range 0.0.0.0/0 as 16276; dynamic name "pb"; dynamic name digits 2; ipv4 { export filter { reject; }; table pb4; import filter flag_rpki; add paths rx; import table yes; next hop keep on; rpki reload on; }; ipv6 { export filter { reject; }; table pb6; import filter flag_rpki; add paths rx; import table yes; next hop keep on; rpki reload on; }; strict bind on; } protocol rpki stack1 { roa4 { table roa4_1; }; roa6 { table roa6_1; }; remote X.X.X.Z port 323; transport tcp; refresh 300; retry 300; expire 600; } protocol rpki stack2 { roa4 { table roa4_2; }; roa6 { table roa6_2; }; remote X.X.X.Y port 323; transport tcp; refresh 300; retry 300; expire 600; } Best regards, François

5 6

BGP med attribute
by Edward Sun 03 Apr '23

03 Apr '23

Hi, Starting from bird v2.0.11, BGP med attribute will not be zero and propagate to the external BGP neighbor. How to empty the BGP med attribute when export? thanks!

2 1

[PATCH][RFC] BFD: Labeling a manually configured neighbor for tracking
by Miao Wang 30 Mar '23

30 Mar '23

For BFD controlled Static routes, the BFD sessions are created to the route next hop. However, in some scenarios, e.g. when the next hop itself does not support BFD, or when it might be more meaningful to create the session to a remote monitoring station, we need more flexible relationship between a static route nexthop and its controlling BFD session. In this patch, a numeric label value can be specified with manually configured BFD neighbors, and a static route nexthop can be configured to track a certain BFD session using that label. The detailed behavior is updated in the user's guide. This feature may also be added to other protocols, but it seems not so meaningful. --- doc/bird.sgml | 23 ++++++++++++++--- nest/bfd.h | 5 ++-- nest/config.Y | 11 +++++++- proto/bfd/bfd.c | 59 ++++++++++++++++++++++++++++++++++++++----- proto/bfd/bfd.h | 1 + proto/bfd/config.Y | 22 +++++++++++++--- proto/bgp/bgp.c | 2 +- proto/ospf/neighbor.c | 2 +- proto/rip/rip.c | 2 +- proto/static/config.Y | 8 ++++-- proto/static/static.c | 6 +++-- proto/static/static.h | 1 + 12 files changed, 120 insertions(+), 22 deletions(-) diff --git a/doc/bird.sgml b/doc/bird.sgml index 5ac32e9e..80aaa24f 100644 --- a/doc/bird.sgml +++ b/doc/bird.sgml @@ -2198,7 +2198,7 @@ protocol bfd [<name>] { multiplier <num>; passive <switch>; }; - neighbor <ip> [dev "<interface>"] [local <ip>] [multihop <switch>]; + neighbor <ip> [dev "<interface>"] [local <ip>] [multihop <switch>] [label <num>]; } </code> @@ -2233,7 +2233,7 @@ protocol bfd [<name>] { connected sessions. Currently only one such definition (for all multihop sessions) could be used. - <tag><label id="bfd-neighbor">neighbor <m/ip/ [dev "<m/interface/"] [local <m/ip/] [multihop <m/switch/]</tag> + <tag><label id="bfd-neighbor">neighbor <m/ip/ [dev "<m/interface/"] [local <m/ip/] [multihop <m/switch/] [label <m/num/]</tag> BFD sessions are usually created on demand as requested by other protocols (like OSPF or BGP). This option allows to explicitly add a BFD session to the specified neighbor regardless of such requests. @@ -2242,7 +2242,11 @@ protocol bfd [<name>] { optional specification of used interface and local IP. By default the neighbor must be directly connected, unless the session is configured as multihop. Note that local IP must be specified for - multihop sessions. + multihop sessions. If the optional <cf/label/ is specified, it is + used to identify the session in the BFD protocol instance and can + be later tracked explicitly by other protocols. The choice of the + label is up to the user other than zero, but it should be unique + within all BFD protocol instances. </descrip> Session specific options (part of <cf/interface/ and <cf/multihop/ definitions): @@ -2338,6 +2342,7 @@ protocol bfd { neighbor 192.168.1.10; neighbor 192.168.2.2 dev "eth2"; neighbor 192.168.10.1 local 192.168.1.1 multihop; + neighbor 192.168.10.2 local 192.168.1.1 multihop label 10; } </code> @@ -5314,6 +5319,17 @@ options (<cf/bfd/ and <cf/weight 1/), the second nexthop has just <cf/weight 2/. that BFD protocol also has to be configured, see <ref id="bfd" name="BFD"> section for details. Default value is no. + <tag><label id="static-route-bfd-track">bfd track <m/num/</tag> + Like <cf/bfd/ option, but the BFD session is not created by the Static + protocol, but it is expected to be already created by one of the neighbors + labeled by the given number in the <cf/neighbor/ statement of the + <ref id="bfd" name="BFD"> protocol. If such a BFD session is not configured, + the route is not installed until a matching session is created later by a + config update and established. It is useful when the next hop liveness + is confirmed with another BFD (maybe multihop) peer other than the next hop + itself. It is not possible to use both <cf/bfd/ and <cf/bfd track/ options + for the same nexthop. Default value is not to track any BFD session. + <tag><label id="static-route-mpls">mpls <m/num/[/<m/num/[/<m/num/[...]]]</tag> MPLS labels that should be pushed to packets forwarded by the route. The option could be used for both IP routes (on MPLS ingress routers) @@ -5516,6 +5532,7 @@ protocol static { route 2001:db8:40::/48 via "eth2"; # Direct route to eth2 route 2001:db8::/32 unreachable; # Unreachable route route ::/0 via 2001:db8:1::1 bfd; # BFD-controlled default route + route 2001:db8:50::/48 via fe80::1%'eth1.70' bfd track 10; # BFD-controlled default route, track bfd session labeled 10 } </code> diff --git a/nest/bfd.h b/nest/bfd.h index 37561266..f5059c17 100644 --- a/nest/bfd.h +++ b/nest/bfd.h @@ -42,6 +42,7 @@ struct bfd_request { u8 diag; u8 old_state; u8 down; + u32 label; }; #define BGP_BFD_GRACEFUL 2 /* BFD down triggers graceful restart */ @@ -57,14 +58,14 @@ static inline struct bfd_options * bfd_new_options(void) #ifdef CONFIG_BFD -struct bfd_request * bfd_request_session(pool *p, ip_addr addr, ip_addr local, struct iface *iface, struct iface *vrf, void (*hook)(struct bfd_request *), void *data, const struct bfd_options *opts); +struct bfd_request * bfd_request_session(pool *p, ip_addr addr, ip_addr local, struct iface *iface, struct iface *vrf, u32 label, void (*hook)(struct bfd_request *), void *data, const struct bfd_options *opts); void bfd_update_request(struct bfd_request *req, const struct bfd_options *opts); static inline void cf_check_bfd(int use UNUSED) { } #else -static inline struct bfd_request * bfd_request_session(pool *p UNUSED, ip_addr addr UNUSED, ip_addr local UNUSED, struct iface *iface UNUSED, struct iface *vrf UNUSED, void (*hook)(struct bfd_request *) UNUSED, void *data UNUSED, const struct bfd_options *opts UNUSED) { return NULL; } +static inline struct bfd_request * bfd_request_session(pool *p UNUSED, ip_addr addr UNUSED, ip_addr local UNUSED, struct iface *iface UNUSED, struct iface *vrf UNUSED, u32 label, void (*hook)(struct bfd_request *) UNUSED, void *data UNUSED, const struct bfd_options *opts UNUSED) { return NULL; } static inline void bfd_update_request(struct bfd_request *req UNUSED, const struct bfd_options *opts UNUSED) { }; static inline void cf_check_bfd(int use) { if (use) cf_error("BFD not available"); } diff --git a/nest/config.Y b/nest/config.Y index e78350ca..dea898d1 100644 --- a/nest/config.Y +++ b/nest/config.Y @@ -143,7 +143,7 @@ CF_ENUM_PX(T_ENUM_AF, AF_, AFI_, IPV4, IPV6) %type <s> optproto %type <ra> r_args %type <sd> sym_args -%type proto_start echo_mask echo_size debug_mask debug_list debug_flag mrtdump_mask mrtdump_list mrtdump_flag export_mode limit_action net_type tos password_algorithm +%type proto_start echo_mask echo_size debug_mask debug_list debug_flag mrtdump_mask mrtdump_list mrtdump_flag export_mode limit_action net_type tos password_algorithm bfd_neigh_label %type <ps> proto_patt proto_patt2 %type <cc> channel_start proto_channel %type <cl> limit_spec @@ -605,6 +605,15 @@ bfd_opts: '{' bfd_items '}' ; +bfd_neigh_label: + expr { + if ($1 == 0){ + cf_error("BFD label cannot be zero"); + } + $$ = $1; + } + ; + /* Core commands */ CF_CLI_HELP(SHOW, ..., [[Show status information]]) diff --git a/proto/bfd/bfd.c b/proto/bfd/bfd.c index 873e2ed5..bec5f1da 100644 --- a/proto/bfd/bfd.c +++ b/proto/bfd/bfd.c @@ -659,6 +659,23 @@ bfd_add_request(struct bfd_proto *p, struct bfd_request *req) { struct bfd_config *cf = (struct bfd_config *) (p->p.cf); + struct bfd_request *ref_req = NULL; + if (req->label != 0 && ipa_zero(req->addr)){ + struct bfd_neighbor *nei; + WALK_LIST(nei, cf->neigh_list){ + if (nei->label == req->label){ + ref_req = nei->req; + break; + } + } + if (ref_req == NULL){ + return 0; + } + } + struct bfd_request *actual_req = req; + if (ref_req != NULL) + req = ref_req; + if (p->p.vrf_set && (p->p.vrf != req->vrf)) return 0; @@ -675,6 +692,8 @@ bfd_add_request(struct bfd_proto *p, struct bfd_request *req) if (!s) s = bfd_add_session(p, req->addr, req->local, req->iface, &req->opts); + req = actual_req; + rem_node(&req->n); add_tail(&s->request_list, &req->n); req->session = s; @@ -731,7 +750,7 @@ static struct resclass bfd_request_class; struct bfd_request * bfd_request_session(pool *p, ip_addr addr, ip_addr local, - struct iface *iface, struct iface *vrf, + struct iface *iface, struct iface *vrf, u32 label, void (*hook)(struct bfd_request *), void *data, const struct bfd_options *opts) { @@ -744,6 +763,7 @@ bfd_request_session(pool *p, ip_addr addr, ip_addr local, req->local = local; req->iface = iface; req->vrf = vrf; + req->label = label; if (opts) req->opts = *opts; @@ -771,9 +791,8 @@ bfd_update_request(struct bfd_request *req, const struct bfd_options *opts) } static void -bfd_request_free(resource *r) +bfd_request_detach_from_session(struct bfd_request *req) { - struct bfd_request *req = (struct bfd_request *) r; struct bfd_session *s = req->session; rem_node(&req->n); @@ -785,6 +804,13 @@ bfd_request_free(resource *r) bfd_remove_session(s->ifa->bfd, s); } +static void +bfd_request_free(resource *r) +{ + struct bfd_request *req = (struct bfd_request *) r; + return bfd_request_detach_from_session(req); +} + static void bfd_request_dump(resource *r) { @@ -819,7 +845,7 @@ bfd_neigh_notify(struct neighbor *nb) if ((nb->scope > 0) && !n->req) { ip_addr local = ipa_nonzero(n->local) ? n->local : nb->ifa->ip; - n->req = bfd_request_session(p->p.pool, n->addr, local, nb->iface, p->p.vrf, NULL, NULL, NULL); + n->req = bfd_request_session(p->p.pool, n->addr, local, nb->iface, p->p.vrf, n->label, NULL, NULL, NULL); } if ((nb->scope <= 0) && n->req) @@ -836,7 +862,7 @@ bfd_start_neighbor(struct bfd_proto *p, struct bfd_neighbor *n) if (n->multihop) { - n->req = bfd_request_session(p->p.pool, n->addr, n->local, NULL, p->p.vrf, NULL, NULL, NULL); + n->req = bfd_request_session(p->p.pool, n->addr, n->local, NULL, p->p.vrf, n->label, NULL, NULL, NULL); return; } @@ -868,16 +894,37 @@ bfd_stop_neighbor(struct bfd_proto *p UNUSED, struct bfd_neighbor *n) if (n->neigh) n->neigh->data = NULL; n->neigh = NULL; + list tmp_list; + init_list(&tmp_list); + if (n->label != 0){ + if (n->req && n->req->session){ + struct bfd_session *s = n->req->session; + struct node *nd, *ndn; + WALK_LIST_DELSAFE(nd, ndn, s->request_list){ + struct bfd_request *req = SKIP_BACK(struct bfd_request, n, nd); + if (req->label == n->label){ + bfd_request_detach_from_session(req); + add_tail(&tmp_list, &req->n); + } + } + } + } rfree(n->req); n->req = NULL; + + struct node *nd; + WALK_LIST_FIRST(nd, tmp_list){ + struct bfd_request *req = SKIP_BACK(struct bfd_request, n, nd); + bfd_submit_request(req); + } } static inline int bfd_same_neighbor(struct bfd_neighbor *x, struct bfd_neighbor *y) { return ipa_equal(x->addr, y->addr) && ipa_equal(x->local, y->local) && - (x->iface == y->iface) && (x->multihop == y->multihop); + (x->iface == y->iface) && (x->multihop == y->multihop) && (x->label == y->label); } static void diff --git a/proto/bfd/bfd.h b/proto/bfd/bfd.h index 7caf9f66..405ca192 100644 --- a/proto/bfd/bfd.h +++ b/proto/bfd/bfd.h @@ -83,6 +83,7 @@ struct bfd_neighbor u8 multihop; u8 active; + u32 label; }; struct bfd_proto diff --git a/proto/bfd/config.Y b/proto/bfd/config.Y index 70461872..e478fc3a 100644 --- a/proto/bfd/config.Y +++ b/proto/bfd/config.Y @@ -24,11 +24,11 @@ CF_DECLS CF_KEYWORDS(BFD, MIN, IDLE, RX, TX, INTERVAL, MULTIPLIER, PASSIVE, INTERFACE, MULTIHOP, NEIGHBOR, DEV, LOCAL, AUTHENTICATION, NONE, SIMPLE, METICULOUS, KEYED, MD5, SHA1, IPV4, IPV6, DIRECT, - STRICT, BIND) + STRICT, BIND, LABEL) %type <iface> bfd_neigh_iface %type <a> bfd_neigh_local -%type bfd_neigh_multihop bfd_auth_type +%type bfd_neigh_multihop bfd_auth_type bfd_neigh_option_label CF_GRAMMAR @@ -164,7 +164,14 @@ bfd_neigh_multihop: | MULTIHOP bool { $$ = $2; } ; -bfd_neighbor: ipa bfd_neigh_iface bfd_neigh_local bfd_neigh_multihop +bfd_neigh_option_label: + /* empty */ { $$ = 0; } + | LABEL bfd_neigh_label { + $$ = $2; + } + ; + +bfd_neighbor: ipa bfd_neigh_iface bfd_neigh_local bfd_neigh_multihop bfd_neigh_option_label { this_bfd_neighbor = cfg_allocz(sizeof(struct bfd_neighbor)); add_tail(&BFD_CFG->neigh_list, NODE this_bfd_neighbor); @@ -173,12 +180,21 @@ bfd_neighbor: ipa bfd_neigh_iface bfd_neigh_local bfd_neigh_multihop BFD_NEIGHBOR->local = $3; BFD_NEIGHBOR->iface = $2; BFD_NEIGHBOR->multihop = $4; + BFD_NEIGHBOR->label = $5; if ($4 && $2) cf_error("Neighbor cannot set both interface and multihop"); if ($4 && ipa_zero($3)) cf_error("Multihop neighbor requires specified local address"); + + if ($5){ + struct bfd_neighbor *other_nei; + WALK_LIST(other_nei, BFD_CFG->neigh_list){ + if (other_nei != this_bfd_neighbor && other_nei->label == $5) + cf_error("Neighbor label %d already used", $5); + } + } }; diff --git a/proto/bgp/bgp.c b/proto/bgp/bgp.c index 9408715e..a3e6becf 100644 --- a/proto/bgp/bgp.c +++ b/proto/bgp/bgp.c @@ -1380,7 +1380,7 @@ bgp_update_bfd(struct bgp_proto *p, const struct bfd_options *bfd) if (bfd && !p->bfd_req && !bgp_is_dynamic(p)) p->bfd_req = bfd_request_session(p->p.pool, p->remote_ip, p->local_ip, p->cf->multihop ? NULL : p->neigh->iface, - p->p.vrf, bgp_bfd_notify, p, bfd); + p->p.vrf, 0, bgp_bfd_notify, p, bfd); if (!bfd && p->bfd_req) { diff --git a/proto/ospf/neighbor.c b/proto/ospf/neighbor.c index ca369819..a59cef32 100644 --- a/proto/ospf/neighbor.c +++ b/proto/ospf/neighbor.c @@ -776,7 +776,7 @@ ospf_neigh_update_bfd(struct ospf_neighbor *n, int use_bfd) if (use_bfd && !n->bfd_req) n->bfd_req = bfd_request_session(n->pool, n->ip, n->ifa->addr->ip, - n->ifa->iface, p->p.vrf, + n->ifa->iface, p->p.vrf, 0, ospf_neigh_bfd_hook, n, NULL); if (!use_bfd && n->bfd_req) diff --git a/proto/rip/rip.c b/proto/rip/rip.c index 8c2d5aeb..6c559ce8 100644 --- a/proto/rip/rip.c +++ b/proto/rip/rip.c @@ -531,7 +531,7 @@ rip_update_bfd(struct rip_proto *p, struct rip_neighbor *n) */ ip_addr saddr = rip_is_v2(p) ? n->ifa->sk->saddr : n->nbr->ifa->ip; n->bfd_req = bfd_request_session(p->p.pool, n->nbr->addr, saddr, - n->nbr->iface, p->p.vrf, + n->nbr->iface, p->p.vrf, 0, rip_bfd_notify, n, NULL); } diff --git a/proto/static/config.Y b/proto/static/config.Y index 9d26ee82..6fa47338 100644 --- a/proto/static/config.Y +++ b/proto/static/config.Y @@ -46,8 +46,7 @@ static_route_finish(void) CF_DECLS CF_KEYWORDS(STATIC, ROUTE, VIA, DROP, REJECT, PROHIBIT, PREFERENCE, CHECK, LINK) -CF_KEYWORDS(ONLINK, WEIGHT, RECURSIVE, IGP, TABLE, BLACKHOLE, UNREACHABLE, BFD, MPLS) - +CF_KEYWORDS(ONLINK, WEIGHT, RECURSIVE, IGP, TABLE, BLACKHOLE, UNREACHABLE, BFD, MPLS, TRACK) CF_GRAMMAR @@ -98,6 +97,11 @@ stat_nexthop: } | stat_nexthop BFD bool { this_snh->use_bfd = $3; cf_check_bfd($3); + this_snh->bfd_label = 0; + } + | stat_nexthop BFD TRACK bfd_neigh_label { + this_snh->use_bfd = 1; cf_check_bfd(1); + this_snh->bfd_label = $4; } ; diff --git a/proto/static/static.c b/proto/static/static.c index f2bb98c7..47f7fa67 100644 --- a/proto/static/static.c +++ b/proto/static/static.c @@ -206,9 +206,10 @@ static_update_bfd(struct static_proto *p, struct static_route *r) if (bfd_up && !r->bfd_req) { // ip_addr local = ipa_nonzero(r->local) ? r->local : nb->ifa->ip; - r->bfd_req = bfd_request_session(p->p.pool, r->via, + r->bfd_req = bfd_request_session(p->p.pool, + r->bfd_label != 0 ? IPA_NONE : r->via, nb->ifa ? nb->ifa->ip : IPA_NONE, - nb->iface, p->p.vrf, + nb->iface, p->p.vrf, r->bfd_label, static_bfd_notify, r, NULL); } @@ -320,6 +321,7 @@ static_same_dest(struct static_route *x, struct static_route *y) (x->onlink != y->onlink) || (x->weight != y->weight) || (x->use_bfd != y->use_bfd) || + (x->bfd_label != y->bfd_label) || (!x->mls != !y->mls) || ((x->mls) && (y->mls) && (x->mls->len != y->mls->len))) return 0; diff --git a/proto/static/static.h b/proto/static/static.h index fc91f71c..22010d86 100644 --- a/proto/static/static.h +++ b/proto/static/static.h @@ -50,6 +50,7 @@ struct static_route { byte use_bfd; /* Configured to use BFD */ struct bfd_request *bfd_req; /* BFD request, if BFD is used */ mpls_label_stack *mls; /* MPLS label stack; may be NULL */ + u32 bfd_label; /* Label for referred BFD session */ }; /* -- 2.39.0

1 1

[PATCH] Fixed crash when requesting a BFD session on an unnumbered interface
by Miao Wang 30 Mar '23

30 Mar '23

Hi, The bug can be reproduced with the following steps: 1. create an unnumbered interface: # ip link add dummy0 type dummy # ip link set dummy0 up # ip neigh replace 169.254.0.1 lladdr <some:mac:add:ress> dev dummy0 2. Create a static route via this interface and request a bfd session protocol device { } ipv4 table main4; protocol bfd bfd1 { strict bind; accept direct; } protocol static { ipv4{ table main4; export all; }; route 1.2.3.4/32 via 169.254.0.1%dummy0 onlink bfd; } The crash happens when dereferencing nb->ifa in static protocol module. nb->ifa is null pointer in this case. This patch also contains a fix in sk_setup(). When the source address and the destination address of a socket are both zero, the socket will be judged as an IPv6 socket since zero address is not a v4-mapped address. As a result, IPV6_V6ONLY is set on this socket. This patch prevents IPV6_V6ONLY from being set when both source address and destination address are zero. With below patch, I can confirm that bird won't crash and BFD packets can be successfully sent. Cheers, Miao Wang --- proto/static/static.c | 3 ++- sysdep/unix/io.c | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/proto/static/static.c b/proto/static/static.c index bb93305e..f2bb98c7 100644 --- a/proto/static/static.c +++ b/proto/static/static.c @@ -206,7 +206,8 @@ static_update_bfd(struct static_proto *p, struct static_route *r) if (bfd_up && !r->bfd_req) { // ip_addr local = ipa_nonzero(r->local) ? r->local : nb->ifa->ip; - r->bfd_req = bfd_request_session(p->p.pool, r->via, nb->ifa->ip, + r->bfd_req = bfd_request_session(p->p.pool, r->via, + nb->ifa ? nb->ifa->ip : IPA_NONE, nb->iface, p->p.vrf, static_bfd_notify, r, NULL); } diff --git a/sysdep/unix/io.c b/sysdep/unix/io.c index e131ca41..8075c2bd 100644 --- a/sysdep/unix/io.c +++ b/sysdep/unix/io.c @@ -996,7 +996,7 @@ sk_setup(sock *s) if (sk_is_ipv6(s)) { - if ((s->type == SK_TCP_PASSIVE) || (s->type == SK_TCP_ACTIVE) || (s->type == SK_UDP)) + if (((s->type == SK_TCP_PASSIVE) || (s->type == SK_TCP_ACTIVE) || (s->type == SK_UDP)) && (ipa_nonzero(s->saddr) || ipa_nonzero(s->daddr))) if (setsockopt(fd, SOL_IPV6, IPV6_V6ONLY, &y, sizeof(y)) < 0) ERR("IPV6_V6ONLY"); -- 2.39.0

2 4

[PATCH] doc: weight should be followed by a number in static route
by Miao Wang 29 Mar '23

29 Mar '23

This patch fixes a mis-spelling in the doc. --- doc/bird.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/bird.sgml b/doc/bird.sgml index f75fa9fe..5ac32e9e 100644 --- a/doc/bird.sgml +++ b/doc/bird.sgml @@ -5326,7 +5326,7 @@ options (<cf/bfd/ and <cf/weight 1/), the second nexthop has just <cf/weight 2/. interface must be attached to nexthop IP address using link-local-scope format (e.g. <cf/192.0.2.1%eth0/). Default value is no. - <tag><label id="static-route-weight">weight <m/switch/</tag> + <tag><label id="static-route-weight">weight <m/num/</tag> For multipath routes, this value specifies a relative weight of the nexthop. Allowed values are 1-256. Default value is 1. </descrip> -- 2.39.0

1 0

VRF separated BGP neighborships over a logical interface
by Ramanathan Selvamani 29 Mar '23

29 Mar '23

Hi Team, I would like to bring up 2 VRF separated BGP neighborship between two routers as below R1 [eth1.55]-------------------------[eth1.55] R2 B_VRF_BLUE<---------------------> B_VRF_BLUE B_VRF_RED <---------------------> B_VRF_RED I created two VRFs red and blue in the kernel. ip link add red type vrf table 100 ip link set dev red up ip link add blue type vrf table 200 ip link set dev blue up Then i enslaved the logical interface to both VRFs red and blue. ip link set dev eth1.55 master red ip link set dev eth1.55 master blue ---> enslaving to red is overridden by blue after this /tmp # ip link show eth1.55 14: eth1.55@eth1: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue *master blue * At R1, I could see B_VRF_BLUE is established and at R2 B_VRF_RED is established. R1 == bird> show protocols Name Proto Table State Since Info B_VRF_RED BGP --- start 23:54:26.660 Idle Received: Cease B_VRF_BLUE BGP --- up 23:54:42.207 Established R2 ==== bird> show protocols Name Proto Table State Since Info B_VRF_RED BGP --- up 23:58:44.611 Established B_VRF_BLUE BGP --- start 23:58:39.842 Active Socket: Connection closed Either one of the BGP sessions is established on both ends. The other session is not getting established. Please let me know if I am missing anything here. Also I noticed that L3VPN support was added into BIRD recently. Is there any support added to handle multiple VRF separated BGP neighborships during this commit ? Please clarify. Below are the configurations used. R1 ==== ipv4 table T_VRF_RED; ipv4 table T_VRF_BLUE; protocol kernel K_VRF_RED { vrf "red"; kernel table 100; scan time 20; ipv4 { table T_VRF_RED; import all; export all; }; } protocol kernel K_VRF_BLUE { vrf "blue"; kernel table 200; scan time 20; ipv4 { table T_VRF_BLUE; import all; export all; }; } protocol direct C_VRF_RED { vrf "red"; ipv4 { table T_VRF_RED; }; } protocol direct C_VRF_BLUE { vrf "blue"; ipv4 { table T_VRF_BLUE; }; } protocol static S_VRF_RED { vrf "red"; ipv4 { table T_VRF_RED; }; route 10.10.1.0/24 blackhole; } protocol static S_VRF_BLUE { vrf "blue"; ipv4 { table T_VRF_BLUE; }; route 10.10.1.0/24 blackhole; } protocol bgp B_VRF_RED { vrf "red"; router id 10.16.44.216; local 55.0.0.1 as 100; neighbor 55.0.0.2 as 100; enable as4 on; hold time 90; keepalive time 30; direct; # regular IPv4 unicast (1/1) ipv4 { table T_VRF_RED; import all; export all; }; } protocol bgp B_VRF_BLUE { vrf "blue"; router id 10.16.44.216; local 55.0.0.1 as 100; neighbor 55.0.0.2 as 100; enable as4 on; hold time 90; keepalive time 30; direct; # regular IPv4 unicast (1/1) ipv4 { table T_VRF_BLUE; import all; export all; }; } R2 ==== ipv4 table T_VRF_RED; ipv4 table T_VRF_BLUE; protocol kernel K_VRF_RED { vrf "red"; kernel table 100; scan time 20; ipv4 { table T_VRF_RED; import all; export all; }; } protocol kernel K_VRF_BLUE { vrf "blue"; kernel table 200; scan time 20; ipv4 { table T_VRF_BLUE; import all; export all; }; } protocol direct C_VRF_RED { vrf "red"; ipv4 { table T_VRF_RED; }; } protocol direct C_VRF_BLUE { vrf "blue"; ipv4 { table T_VRF_BLUE; }; } protocol static S_VRF_RED { vrf "red"; ipv4 { table T_VRF_RED; }; route 10.10.1.0/24 blackhole; } protocol static S_VRF_BLUE { vrf "blue"; ipv4 { table T_VRF_BLUE; }; route 10.10.1.0/24 blackhole; } protocol bgp B_VRF_RED { vrf "red"; router id 10.16.44.217; local 55.0.0.2 as 100; neighbor 55.0.0.1 as 100; enable as4 on; hold time 90; keepalive time 30; direct; # regular IPv4 unicast (1/1) ipv4 { table T_VRF_RED; import all; export all; }; } protocol bgp B_VRF_BLUE { vrf "blue"; router id 10.16.44.217; local 55.0.0.2 as 100; neighbor 55.0.0.1 as 100; enable as4 on; hold time 90; keepalive time 30; direct; # regular IPv4 unicast (1/1) ipv4 { table T_VRF_BLUE; import all; export all; }; } Thanks, Ramanathan

2 2

RIP protocol packet maximum length checking
by Mingwei Zheng 29 Mar '23

29 Mar '23

Hi, I noticed that you have defined RIP_MAX_PKT_LENGTH = 532 in rip.h. It seems that this value isn’t used. So I am wondering how do you check the maximum length in RIP protocol implementation, thanks Best, Mingwei

1 0

Force bird to update bgp route configuration after X seconds
by Pedro Henrique de Araújo Marques 28 Mar '23

28 Mar '23

Good evening, I'm doing some tests with BIRD for a while now and I would like some help with a problem I'm facing. I have the following BIRD configuration: router id 10.0.0.128; ipv4 table master4; ipv6 table master6; flow4 table flowtab4; flow6 table flowtab6; filter subnet_group1{ if(bgp_community.len = 0) then { bgp_community.add((555,555)); accept; } else{ accept; } }; protocol bgp uplink1{ local as 129; neighbor 10.0.1.128 as 128; multihop 1; ipv4{ import filter { accept; }; export filter subnet_group1; }; ipv6{ import filter { accept; }; export filter subnet_group1; }; }; protocol static blackhole_ipv4_routes{ route 10.0.90.100/32 blackhole; route 10.0.90.99/32 blackhole; ipv4; }; I created a script that after some time it inserts some new routes into the blackhole_ipv4_routes protocol defined above, let's say all of 10.0.0.0/24 for example. Is there an option that I could use in the config file to detect this change and update bird accordingly with the new table additions, or do I need to always call 'birdc -configure' after the script ends?

5 7