- Bird-users - Mailing Lists

Code style?
by Kenth Eriksson 12 Jun '19

12 Jun '19

Is there a code style guide to be used when submitting patches to bird? An emacs file, clang-format or similar would be useful. Thanks, Kenth

4 4

Fwd: bird (2.0.4) does not install multipath route in kernel
by Arno O 11 Jun '19

11 Jun '19

One more (last) question: since when (which Bird) -release is ECMP like this supported? Thx BR Ar Am Di., 11. Juni 2019 um 15:39 Uhr schrieb Kenth Eriksson < Kenth.Eriksson(a)infinera.com>: > On Tue, 2019-06-11 at 15:13 +0200, Arno O wrote: > > all, Alexander, > > > > bingo, "ip route" does the job ( sorry, was not aware about that > > difference). > > Thanx > > > Message only sent to me, please re-post to list so that they can see > your resolution of the problem. > > > Enjoy the day > > BR > > Ar > > > > [root@localhost ~]# ip route > > 10.10.10.0/24 dev enp0s3 proto bird scope link metric 10 > > 10.10.10.0/24 dev enp0s3 proto kernel scope link src 10.10.10.1 > > metric 100 > > 50.50.50.0/24 proto bird metric 10 > > nexthop via 10.10.10.2 dev enp0s3 weight 11 > > nexthop via 10.10.10.3 dev enp0s3 weight 11 > > 192.168.122.0/24 dev virbr0 proto kernel scope link src 192.168.122.1 > > linkdown > > 192.168.122.0/24 via 10.10.10.3 dev enp0s3 proto bird metric 10 > > [root@localhost ~]# > > > > Am Di., 11. Juni 2019 um 14:56 Uhr schrieb Arno O <odermaar(a)gmail.com > > >: > > > Dear Kenth, > > > > > > there is no such error trace in syslog > > > > > > (bird log setting: > > > # Configure logging > > > log syslog all;) > > > > > > How to proceed? > > > > > > BR > > > Ar > > > > > > > > > Am Di., 11. Juni 2019 um 14:36 Uhr schrieb Kenth Eriksson < > > > Kenth.Eriksson(a)infinera.com>: > > > > On Tue, 2019-06-11 at 14:18 +0200, Arno O wrote: > > > > > CAUTION: This email originated from outside of the > > > > organization. Do > > > > > not click links or open attachments unless you recognize the > > > > sender > > > > > and know the content is safe. > > > > > > > > > > This topic was already discussed around March 1st 2019, > > > > without > > > > > having received a clear outcome. > > > > > > > > > > Now, dealing with ECMP with OSPF in Bird 2.04 on Fedora30, I > > > > run in > > > > > same problems: > > > > > > > > > > -> multiple next hops to same destination (50.50.50.0/24) are > > > > in the > > > > > route table of bird: > > > > > bird> sho route > > > > > Table master4: > > > > > 10.10.10.0/24 unicast [OIPv46 13:39:16.979] I (150/10) > > > > > [10.10.10.1] > > > > > dev enp0s3 > > > > > 192.168.122.0/24 unicast [OIPv46 13:46:18.979] E2 > > > > (150/10/10000) > > > > > [10.10.10.3] > > > > > via 10.10.10.3 on enp0s3 > > > > > 50.50.50.0/24 unicast [OIPv46 13:46:18.979] E2 > > > > (150/10/100) > > > > > [10.10.10.3] > > > > > via 10.10.10.2 on enp0s3 weight 11 > > > > > via 10.10.10.3 on enp0s3 weight 11 > > > > > bird> > > > > > [root@localhost ~]# > > > > > > > > > > but kernel route table looks unexpectedly different: > > > > > root@localhost ~]# netstat -rn > > > > > Kernel IP routing table > > > > > Destination Gateway Genmask Flags MSS > > > > Window > > > > > irtt Iface > > > > > 10.10.10.0 0.0.0.0 255.255.255.0 U 0 0 > > > > > > > > > 0 enp0s3 > > > > > 50.50.50.0 10.10.10.2 255.255.255.0 UG 0 0 > > > > > > > > > 0 enp0s3 > > > > > 192.168.122.0 10.10.10.3 255.255.255.0 UG 0 0 > > > > > > > > > 0 enp0s3 > > > > > [root@localhost ~]# > > > > > > > > > Do you see them if you do 'ip route'? I think iproute2 is better > > > > at > > > > displaying multipath routes. > > > > > > > > > Kernel looks configured correctly > > > > (CONFIG_IP_ROUTE_MULTIPATH=y), > > > > > etc.etc. > > > > > > > > > If the kernel is mis-configured, I believe you get an error trace > > > > in > > > > the bird log. Something along the following lines; > > > > > > > > <WARN> Netlink: Invalid argument > > > > > > > > I tested it on 2.0.4 and kernel 4.14.92+ and that seems to work. > > > > > > > > > > > > > > Bird config on ECMPed bird router: > > > > > protocol ospf OIPv46 { > > > > > tick 2; > > > > > rfc1583compat yes; > > > > > ecmp yes limit 8; > > > > > merge external yes; > > > > > ipv4 { > > > > > import all; > > > > > export all; > > > > > }; > > > > > area 0 { > > > > > interface "enp0*" { > > > > > # type broadcast; # Detected by default > > > > > cost 10; # Interface metric > > > > > ecmp weight 11; > > > > > > > > > > What is missing either in the bird-config or the kernel part? > > > > > > > > > > Thx > > > > > > > > > > BR > > > > > Ar > > > > > >

2 2

[PATCH 3/3] Fix cli socket close due to io buffer full
by Kenth Eriksson 11 Jun '19

11 Jun '19

The pointer rpos in the socket io module is only restored if the rx_hook callback returns 1. Previously the cli_rx hook always returned 0. Guarantee by design that we return 1 if we are at the end of the socket buffer. Signed-off-by: Kenth Eriksson <kenth.eriksson(a)infinera.com> --- sysdep/unix/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sysdep/unix/main.c b/sysdep/unix/main.c index cf5f4a3c..6a6d1d2b 100644 --- a/sysdep/unix/main.c +++ b/sysdep/unix/main.c @@ -422,7 +422,7 @@ static int cli_rx(sock *s, uint size UNUSED) { cli_kick(s->data); - return 0; + return s->rbuf+s->rbsize==s->rpos? 1 : 0; } static void -- 2.21.0

3 2

bird (2.0.4) does not install multipath route in kernel
by Arno O 11 Jun '19

11 Jun '19

This topic was already discussed around March 1st 2019, without having received a clear outcome. Now, dealing with ECMP with OSPF in Bird 2.04 on Fedora30, I run in same problems: -> multiple next hops to same destination (50.50.50.0/24) are in the route table of bird: bird> sho route Table master4: 10.10.10.0/24 unicast [OIPv46 13:39:16.979] I (150/10) [10.10.10.1] dev enp0s3 192.168.122.0/24 unicast [OIPv46 13:46:18.979] E2 (150/10/10000) [10.10.10.3] via 10.10.10.3 on enp0s3 50.50.50.0/24 unicast [OIPv46 13:46:18.979] E2 (150/10/100) [10.10.10.3] via 10.10.10.2 on enp0s3 weight 11 via 10.10.10.3 on enp0s3 weight 11 bird> [root@localhost ~]# but kernel route table looks unexpectedly different: root@localhost ~]# netstat -rn Kernel IP routing table Destination Gateway Genmask Flags MSS Window irtt Iface 10.10.10.0 0.0.0.0 255.255.255.0 U 0 0 0 enp0s3 50.50.50.0 10.10.10.2 255.255.255.0 UG 0 0 0 enp0s3 192.168.122.0 10.10.10.3 255.255.255.0 UG 0 0 0 enp0s3 [root@localhost ~]# Kernel looks configured correctly (*CONFIG_IP_ROUTE_MULTIPATH=y), etc.etc.* *Bird config on ECMPed bird router: *protocol ospf OIPv46 { tick 2; rfc1583compat yes; ecmp yes limit 8; merge external yes; ipv4 { import all; export all; }; area 0 { interface "enp0*" { # type broadcast; # Detected by default cost 10; # Interface metric ecmp weight 11; What is missing either in the bird-config or the kernel part? Thx BR Ar

3 3

radv/OpenWRT: "propagate routes yes" syntax error
by Marvin Gaube 11 Jun '19

11 Jun '19

Hello, I'm currently trying to run bird6 on a Gluon-Device (Gluon is build upon OpenWRT) to announce Router Advertisments. I need to announce more specific routes, which I'm trying to export like this: table radv_routes; # Add routes protocol static { table radv_routes; route fd21:b4dc::/40 via fe80::1; } protocol radv { table radv_routes; propagate routes yes; export all; interface "local-gw" { max ra interval 5; default preference high; default lifetime 1600; }; prefix 2a0e:...::/64 { }; } The configuration is inspired by the example from https://bird.network.cz/?get_doc&v=16&f=bird-6.html#ss6.10 Every time I'm trying to start bird with "propagate routes yes" it says that there's a syntax error in this line. Without - announcing only the default route - everything works fine. The exact version is 1.6.3 on OpenWRT 18.02. Has anyone an idea on how to solve this? I didn't found this as "known bug" yet. Thanks and best regards Marvin

2 1

[PATCH] Fix an issue where bird may accidently close a socket
by Kenth Eriksson 11 Jun '19

11 Jun '19

Datagram sockets may return 0 and stream sockets can return 0 if the requested number of bytes to read is 0. Signed-off-by: Kenth Eriksson <kenth.eriksson(a)infinera.com> --- sysdep/unix/io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sysdep/unix/io.c b/sysdep/unix/io.c index d1d86e3b..44dd3172 100644 --- a/sysdep/unix/io.c +++ b/sysdep/unix/io.c @@ -1873,7 +1873,7 @@ sk_read(sock *s, int revents) s->err_hook(s, 0); } } - else if (!c) + else if (!c && (revents & POLLHUP)) s->err_hook(s, 0); else { -- 2.21.0

3 7

adding MED to + bgp_med
by Łukasz Trąbiński 06 Jun '19

06 Jun '19

Hello In my configuration I export policy function like this: if (yyyyy,xxxxx) ~ bgp_community && (defined (bgp_med)) then { bgp_med = bgp_med + 100; accept; } It worked well in 1.6.4 if the prefix was set community yyyyy,xxxxx and med was set to for example = 20, med was set to 120 in export bgp session. In version 1.6.6 it looks like it does not work, med is set = 100. Something was changed beetwen versions? Maybe it’s a bug? Łukasz Trąbiński

2 2

2 upstreams 1 downstream BGP configuration optimization
by Kevin B 05 Jun '19

05 Jun '19

Hello, I have 2 upstream transit providers and 1 downstream customer we provide transit to - http://paste.debian.net/1086030/ (full Bird configuration with explanation) There is a problem: Bird is exporting all the imported prefixes from my upstreams back to them. For example 10.40.40.0/24 is being exported from us even when AS20's customer doesn't announce it, because it is announced somewhere else in the full table and we just export it back from the full view. Here is `birdc show protocols all` output - http://paste.debian.net/1086033/ I would like to prevent exporting the full view tables imported from my upstreams back to them, can you help me to understand what is wrong with the configuration and why does it happen?

4 4

Re: Submitting code? (Wireguard)
by Janne Heß 02 Jun '19

02 Jun '19

Hey everyone, I wrote code that adds Wireguard support (new kernelspace VPN) to Bird 2. The problem is that with the cryptokey routing of Wireguard, it needs to know which IPs are behind which peers. The patch does exactly that: If the interface is a wireguard interface, try modifying the list of IPs. So my question is: How do I contribute that? I think the feature would be useful for other people, so having it upstream would be nice. Should I just post the patch here? Or create a GitLab PR? PR would probably be more convenient due to the discussion feature, but I'm unable to fork the project because my project limit is at 0. Could you give me information on how to contribute the code? Thanks and regards Janne

3 2

Forward full view to a downstream
by Kevin B 30 May '19

30 May '19

Hello, My customer wants me to announce a full IPv4 table via BGP to him, but we don't use it on the BGP node where that customer is peered. We receive the default from our BGP upstream, but can actually ask for and receive a full view as well, but only for a purpose of forwarding it to the customer. What would be a scheme to receive a full-table from a BGP upstream and forward it to a BGP downstream, without importing it to our own routing table? I am not very experienced with Bird, but some guys on Freenode ##networking have suggested using a pipe, can someone help me on this please?

4 3