- Bird-users - Mailing Lists

Adding BuildRequires for RPM SPEC file
by Ang Way Chuang 10 Oct '11

10 Oct '11

Hi all, I thought that this may be useful. Anyway, is there any standard procedure to produce src.rpm from the git repository? I cannot find the src.rpm for bird-1.3.3-1. Thanks. Regards, Ang Way Chuang diff --git a/misc/bird.spec b/misc/bird.spec index 16aa682..030005f 100644 --- a/misc/bird.spec +++ b/misc/bird.spec @@ -10,6 +10,7 @@ Source2: birdc6 Buildroot: /var/tmp/bird-root Url: http://bird.network.cz Prereq: /sbin/chkconfig +BuildRequires: flex bison readline-devel ncurses-devel %description BIRD is dynamic routing daemon supporting IPv4 and IPv6 versions of routing

2 1

Include statement in bird 1.3.3
by Mathias Wolkert 10 Oct '11

10 Oct '11

Hi I am trying to create a distributed config in bird where I move all bgp to a file of its own. What is the syntax I should use? Doc says: include "filename" So I tried: include "/etc/bird-bgp.conf"; and /etc/bird-bgp.conf looking like this: protocol bgp { router id 1.1.1.1; local as 65555; neighbor 1.1.1.2 as 65535; import filter imp; export filter exp; } With this config, bird refuses to start, hanging at "Restarting Internet routing daemon: bird" bird 1.3.3 Debian 5 2.6.32-bpo.3-amd64 Any input is much appreciated. /Tias

2 2

Re: Multi-protocol core
by Martin Mares 03 Oct '11

03 Oct '11

Ahoj! > commit ee3256fe1cb3e429de22e7c50a0826aaa4dc7a73 > Author: Ondrej Zajicek <santiago(a)crfreenet.org> > Date: Sat Oct 1 10:28:34 2011 +0200 > > Multiprotocol core support. > > The patch from Alexander V. Chernikov. Overall, the multiprotocol core looks good, there is a couple of minor nit-picking comments: | diff --git a/configure.in b/configure.in | index 46a6ecd..9af70b7 100644 | --- a/configure.in | +++ b/configure.in | @@ -10,6 +10,7 @@ AC_ARG_ENABLE(debug,[ --enable-debug enable internal debugging routine | AC_ARG_ENABLE(memcheck,[ --enable-memcheck check memory allocations when debugging (default: enabled)],,enable_memcheck=yes) | AC_ARG_ENABLE(client,[ --enable-client enable building of BIRD client (default: enabled)],,enable_client=yes) | AC_ARG_ENABLE(ipv6,[ --enable-ipv6 enable building of IPv6 version (default: disabled)],,enable_ipv6=no) | +AC_ARG_ENABLE(mpls,[ --enable-mpls enable building MPLS version (default: disabled)],,enable_mpls=no) | AC_ARG_WITH(sysconfig,[ --with-sysconfig=FILE use specified BIRD system configuration file]) | AC_ARG_WITH(protocols,[ --with-protocols=LIST include specified routing protocols (default: all)],,[with_protocols="all"]) | AC_ARG_WITH(sysinclude,[ --with-sysinclude=PATH search for system includes on specified place]) | @@ -50,6 +51,12 @@ else | all_protocols=bgp,ospf,pipe,rip,static | fi | | +if test "$enable_mpls" = yes ; then | + AC_DEFINE(MPLS) | + AC_DEFINE(MPLS_VPN) | +# all_protocols="$all_protocols",ldp | +fi | + Why is it called MPLS, when we call all other configuration switches CONFIG_something? | diff --git a/lib/addrs.c b/lib/addrs.c | new file mode 100644 | index 0000000..6553bba | --- /dev/null | +++ b/lib/addrs.c | @@ -0,0 +1,293 @@ | +/* | + * BIRD Library -- Address Manipulation Functions | + * | + * (c) 2011 Alexander V. Chernikov <melifaro(a)ipfw.ru> | + * | + * Can be freely distributed and used under the terms of the GNU GPL. | + */ | + | +#include <stdio.h> | +#include <stdlib.h> | + | +#include <sys/types.h> | +#include <sys/socket.h> | +#include <netinet/in.h> | +#include <arpa/inet.h> <arpa/inet.h> definitely belongs to sysdep. | +#define PBUFS 4 | +#define PSIZE 50 This deserves a comment. | +/** | + * fn_print - prints a FIB node | + * @n: pointer to fib_node structure | + * | + * This function prints fib node address to static buffer and | + * returns it to the caller. Up to PBUFS(4) different buffers are | + * available. | + */ Recycling of a fixed number of static buffers is a rather dirty trick, which will likely lead to hard-to-catch bugs. (And break multithreading, if we ever use it in BIRD.) Better let the caller supply an appropriate buffer. The number of direct callers is going to be low anyway, since almost everybody will use bprintf(). | --- /dev/null | +++ b/lib/addrs.h [...] | +typedef uint64_t u64; Huh? It should be already defined in sysdep/config.h. | +#ifndef IPV6 | +typedef vpn4_addr vpn_addr; | +#else | +typedef vpn6_addr vpn_addr; | +#endif Calling this beast "vpn" without further clarification is going to be confusing -- people (even those experienced in networking) usually do not associate "vpn" with "MPLS" implicitly. Better choose a more descriptive name. | diff --git a/nest/route.h b/nest/route.h | index 641b924..c3d5e2b 100644 | --- a/nest/route.h | +++ b/nest/route.h | @@ -36,9 +36,10 @@ struct fib_node { | struct fib_iterator *readers; /* List of readers of this node */ | byte pxlen; | byte flags; /* User-defined */ | - byte x0, x1; /* User-defined */ | + byte addr_type; /* User-defined */ | + byte addr_off; /* address data offset */ Please use consistent capitalization (everywhere). | + unsigned int addr_type; /* Type of adresses stored in fib (IPv46, VPNv46, MPLS, etc..)*/ | + unsigned int addr_size; /* size of address specified in entry */ | + unsigned int addr_off; /* value of data offset to be set in fib_node */ I did not understand anything from the latter two comments. What is specified in an entry? An address? Or the size itself? Offset of which data? | @@ -116,6 +129,7 @@ void fit_put(struct fib_iterator *, struct fib_node *); | struct rtable_config { | node n; | char *name; | + int rtype; /* Type of the table (IPv46, VPNv46, MPLS, etc..)*/ Why is it called "rtype" here and "addr_type" elsewhere? | +/* Types of routing tables/entries */ | +#define RT_IPV4 1 | +#define RT_IPV6 2 | +#define RT_VPNV4 3 | +#define RT_VPNV6 4 | +#define RT_MPLS 5 | + | +#define RT_MAX 6 Deserves comments. | +/* Same tables using bit positions. Used for appropriate table linking on protocol init */ | +#define RT_IPV4_BIT 0x001 | +#define RT_IPV6_BIT 0x002 | +#define RT_VPNV4_BIT 0x004 | +#define RT_VPNV6_BIT 0x008 | +#define RT_MPLS_BIT 0x010 Better use #define RT_IPV4_BIT (1U << RT_IPV4) | diff --git a/nest/rt-fib.c b/nest/rt-fib.c | index 510aa76..bf2b562 100644 | --- a/nest/rt-fib.c | +++ b/nest/rt-fib.c | @@ -73,9 +73,22 @@ fib_ht_free(struct fib_node **h) | } | | static inline unsigned | -fib_hash(struct fib *f, ip_addr *a) | +fib_hash(struct fib *f, void *a) | { | - return ipa_hash(*a) >> f->hash_shift; | + u32 *v, x; | + int i; | + | + if (f->hash_f) | + return f->hash_f(a); | + | + if (f->addr_type == RT_IP) | + return ipa_hash(*((ip_addr *)a)) >> f->hash_shift; | + | + x = 0; | + for (i = 0, v = (u32 *)a; i < f->addr_size / 4; i++, v++) | + x = x ^ *v; | + | + return ((x ^ (x >> 16) ^ (x >> 8)) & 0xffff) >> f->hash_shift; | } Is it guaranteed that addr_size will be always divisible by 4? If it is a requirement, document it. If I understand the code properly, fib_hash() is a pretty hot place, but you do several pointless tests there -- e.g., f->addr_type is constant for the whole FIB, but you test it during each calculation of a hash value. Instead of that, set f->hash_f during initialization of the FIB according to the type of addresses used. Martin

3 3

Use of public networks/ASNs in bird.conf
by Alexander V. Chernikov 02 Oct '11

02 Oct '11

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hello list! There are a bunch of IP addresses used in example bird.conf. Maybe we can consider using addresses from rfc5737 (IPv4 Address Blocks Reserved for Documentation) for this? I mean, do sed 's?62.168.0?198.51.100?g' bird.conf, for example The same approach can be taken for ASN, there is rfc 5398 giving us 64496 - 64511 ASN block for 16-bits ASN. Diff to current bird.conf (just an example) attached P.S. and consider using rfc3849 2001:DB8::/32 when writing examples for bird6.conf -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk6IR7EACgkQwcJ4iSZ1q2nOegCeMnYdufDLiCMP9K635P9NgB9h pKEAoKgTQYv/Em+m7RZZGbXJ3Fb0XEAy =5Q10 -----END PGP SIGNATURE----- --- bird.conf.example 2011-09-29 18:38:34.000000000 +0400 +++ /home/melifaro/bird.conf 2011-10-02 15:10:33.964294041 +0400 @@ -10,7 +10,7 @@ #log "tmp" all; # Override router ID -#router id 62.168.0.1; +#router id 198.51.100.1; # You can define your own symbols... #define xyzzy = (120+10); @@ -66,12 +66,12 @@ # preference 1000; # Default preference of routes # debug { states, routes, filters, interfaces, events, packets }; # debug all; -# route 0.0.0.0/0 via 62.168.0.13; -# route 62.168.0.0/25 reject; +# route 0.0.0.0/0 via 198.51.100.13; +# route 198.51.100.0/25 reject; # route 10.0.0.0/8 reject; -# route 10.1.1.0:255.255.255.0 via 62.168.0.3; -# route 10.1.2.0:255.255.255.0 via 62.168.0.3; -# route 10.1.3.0:255.255.255.0 via 62.168.0.4; +# route 10.1.1.0:255.255.255.0 via 198.51.100.3; +# route 10.1.2.0:255.255.255.0 via 198.51.100.3; +# route 10.1.3.0:255.255.255.0 via 198.51.100.4; # route 10.2.0.0/24 via "arc0"; } @@ -168,7 +168,7 @@ # disabled; # description "My BGP uplink"; # local as 65000; -# neighbor 62.168.0.130 as 5588; +# neighbor 198.51.100.130 as 64496; # multihop; # hold time 240; # startup hold time 240; @@ -183,7 +183,7 @@ # path metric 1; # Prefer routes with shorter paths (like Cisco does) # default bgp_med 0; # MED value we use for comparison when none is defined # default bgp_local_pref 0; # The same for local preference -# source address 62.168.0.14; # What local address we use for the TCP connection +# source address 198.51.100.14; # What local address we use for the TCP connection # password "secret"; # Password used for MD5 authentication # rr client; # I am a route reflector and the neighor is my client # rr cluster id 1.0.0.1; # Use this value for cluster id instead of my router id @@ -193,7 +193,7 @@ # bgp_community = -empty-; bgp_community = add(bgp_community,(65000,5678)); # bgp_origin = 0; # bgp_community = -empty-; bgp_community.add((65000,5678)); -# if (65000,5678) ~ bgp_community then +# if (65000,64501) ~ bgp_community then # bgp_community.add((0, 1)); # if bgp_path ~ [= 65000 =] then # bgp_path.prepend(65000);

2 1

ERR when redistributing to OSPF NSSA
by Fedor Dikarev 02 Oct '11

02 Oct '11

Hello, I've got the problem: I'm trying to reditribute lo-address-es to ospf nssa area: > ifconfig lo0 > lo0: flags=8049<UP,LOOPBACK,RUNNING,MULTICAST> metric 0 mtu 16384 > options=3<RXCSUM,TXCSUM> > inet6 fe80::1%lo0 prefixlen 64 scopeid 0x6 > inet6 ::1 prefixlen 128 > inet 127.0.0.1 netmask 0xff000000 > inet 81.19.70.17 netmask 0xffffffff > inet 81.19.70.18 netmask 0xffffffff > inet 81.19.94.166 netmask 0xffffffff > inet 81.19.94.167 netmask 0xffffffff bird.conf: > # Override router ID > router id 81.19.68.227; > > #include filters.conf; > > filter ospf_metrics_for_lo0 { > # if source != RTS_DEVICE then reject; > > if net = 81.19.70.17/32 then { ospf_metric2 = 11; accept "70.17"; } else > if net = 81.19.70.18/32 then { ospf_metric2 = 19; accept "70.18"; } else > reject; > }; > > # Turn on global debugging of all protocols > debug protocols all; > > # This pseudo-protocol watches all interface up/down events. > protocol device { > scan time 10; # Scan interfaces every 10 seconds > }; > > protocol direct { > interface "lo0"; > } > > protocol kernel { > # export all; > scan time 15; > }; > > protocol ospf { > import all; > export filter ospf_metrics_for_lo0; > > area 70 { > nssa; > interface "bge0" { > hello 1; > dead 3; > }; > }; > }; But when I run bird, I've got: > bird -d > 29-09-2011 17:34:50 <TRACE> device1: Initializing > 29-09-2011 17:34:50 <TRACE> direct1: Initializing > 29-09-2011 17:34:50 <TRACE> kernel1: Initializing > 29-09-2011 17:34:50 <TRACE> ospf1: Initializing > 29-09-2011 17:34:50 <TRACE> device1: Starting > 29-09-2011 17:34:50 <TRACE> device1: Scanning interfaces > 29-09-2011 17:34:50 <TRACE> device1: State changed to feed > 29-09-2011 17:34:50 <TRACE> direct1: Starting > 29-09-2011 17:34:50 <TRACE> direct1: State changed to feed > 29-09-2011 17:34:50 <TRACE> kernel1: Starting > 29-09-2011 17:34:50 <TRACE> kernel1: State changed to feed > 29-09-2011 17:34:50 <TRACE> ospf1: Starting > 29-09-2011 17:34:50 <TRACE> ospf1: Adding area 0.0.0.70 > 29-09-2011 17:34:50 <TRACE> ospf1: State changed to feed > 29-09-2011 17:34:50 <INFO> Started > 29-09-2011 17:34:50 <TRACE> device1: State changed to up > 29-09-2011 17:34:50 <TRACE> direct1 < primary address 81.19.68.224/28 on interface bge0 added > 29-09-2011 17:34:50 <TRACE> direct1 < primary address 81.19.70.17/32 on interface lo0 added > 29-09-2011 17:34:50 <TRACE> direct1 > added [best] 81.19.70.17/32 dev lo0 > 29-09-2011 17:34:50 <TRACE> direct1 < secondary address 127.0.0.0/8 on interface lo0 added > 29-09-2011 17:34:50 <TRACE> direct1 < secondary address 81.19.70.18/32 on interface lo0 added > 29-09-2011 17:34:50 <TRACE> direct1 > added [best] 81.19.70.18/32 dev lo0 > 29-09-2011 17:34:50 <TRACE> direct1 < secondary address 81.19.94.166/32 on interface lo0 added > 29-09-2011 17:34:50 <TRACE> direct1 > added [best] 81.19.94.166/32 dev lo0 > 29-09-2011 17:34:50 <TRACE> direct1 < secondary address 81.19.94.167/32 on interface lo0 added > 29-09-2011 17:34:50 <TRACE> direct1 > added [best] 81.19.94.167/32 dev lo0 > 29-09-2011 17:34:50 <TRACE> direct1: State changed to up > 29-09-2011 17:34:50 <TRACE> kernel1: Connected to table master > 29-09-2011 17:34:50 <TRACE> kernel1 < rejected by protocol 81.19.70.18/32 dev lo0 > 29-09-2011 17:34:50 <TRACE> kernel1 < rejected by protocol 81.19.70.17/32 dev lo0 > 29-09-2011 17:34:50 <TRACE> kernel1 < rejected by protocol 81.19.94.166/32 dev lo0 > 29-09-2011 17:34:50 <TRACE> kernel1 < rejected by protocol 81.19.94.167/32 dev lo0 > 29-09-2011 17:34:50 <TRACE> kernel1: State changed to up > 29-09-2011 17:34:50 <TRACE> ospf1: Connected to table master > 29-09-2011 17:34:50 <TRACE> ospf1 < interface usbus0 created > 29-09-2011 17:34:50 <TRACE> ospf1 < interface usbus1 created > 29-09-2011 17:34:50 <TRACE> ospf1 < interface bge0 goes up > 29-09-2011 17:34:50 <TRACE> ospf1 < primary address 81.19.68.224/28 on interface bge0 added > 29-09-2011 17:34:50 <TRACE> ospf1: Adding interface bge0 (81.19.68.224/28) to area 0.0.0.70 > 29-09-2011 17:34:50 <TRACE> ospf1 < interface bge1 created > 29-09-2011 17:34:50 <TRACE> ospf1 < interface ipfw0 created > 29-09-2011 17:34:50 <TRACE> ospf1 < interface lo0 goes up > 29-09-2011 17:34:50 <TRACE> ospf1 < primary address 81.19.70.17/32 on interface lo0 added > 29-09-2011 17:34:50 <TRACE> ospf1 < secondary address 127.0.0.0/8 on interface lo0 added > 29-09-2011 17:34:50 <TRACE> ospf1 < secondary address 81.19.70.18/32 on interface lo0 added > 29-09-2011 17:34:50 <TRACE> ospf1 < secondary address 81.19.94.166/32 on interface lo0 added > 29-09-2011 17:34:50 <TRACE> ospf1 < secondary address 81.19.94.167/32 on interface lo0 added > 29-09-2011 17:34:50 <INFO> 70.18 > 29-09-2011 17:34:50 <TRACE> ospf1 < added 81.19.70.18/32 dev lo0 > 29-09-2011 17:34:50 <TRACE> ospf1: Originating NSSA-LSA for 81.19.70.18/32 > 29-09-2011 17:34:50 <ERR> ^^^^^^^^^^^^^^^^^^^^^^^^^^^ what is the ERR? > 29-09-2011 17:34:50 <INFO> 70.17 > 29-09-2011 17:34:50 <TRACE> ospf1 < added 81.19.70.17/32 dev lo0 > 29-09-2011 17:34:50 <TRACE> ospf1: Originating NSSA-LSA for 81.19.70.17/32 > 29-09-2011 17:34:50 <ERR> ^^^^^^^^^^^^^^^^^^^^^^^^^^^ what is the ERR? > 29-09-2011 17:34:50 <TRACE> ospf1 < filtered out 81.19.94.166/32 dev lo0 > 29-09-2011 17:34:50 <TRACE> ospf1 < filtered out 81.19.94.167/32 dev lo0 > 29-09-2011 17:34:50 <TRACE> ospf1: State changed to up And so I don't see this routes. What am I doing wrong? > bird --version > BIRD version 1.3.3 > uname -a > FreeBSD xxxxx 8.2-20110713-SNAP FreeBSD 8.2-20110713-SNAP #0: Wed Jul 13 20:56:12 UTC 2011 root@nat-m1.rambler.ru:/usr/obj/usr/src/sys/DEVEL amd64 -- Fedor Dikarev Rambler Internet Holding

5 8

ospf and default route
by fredrik danerklint 01 Oct '11

01 Oct '11

(it's me again!) How do I announce a default route to a specific interface? What I want is that all ospf routers connected to that interface should only receive default router. Is that possible? -- //fredan

1 0

iBGP
by fredrik danerklint 30 Sep '11

30 Sep '11

Hi, FreeBSD 8.2 and Bird 1.3.3. I do my internal peering between routes on loopback interfaces. All the loopback interfaces is announced over ospf. To be able to get an bgp session the 'multi hop 4;' is needed. The question I have is what value should the 'next hop' be? I would like to have it to the neighbour address of the peering session but it seems it always the nearest physical network interface address (to the neighbour) that's 'next hop'. I did even try with setting bgp_next_hop=10.10.10.11; within the filter of the bgp protocol but that did not work. -- //fredan

2 7

Looking-Glass
by Mihai Claudiu Capatina 29 Sep '11

29 Sep '11

Hi, Does anybody know about an open-source looking-glass for BIRD ? Best Regards, Mihai Claudiu Capatina Managing Partner Vector Communications SRL Address : Aleea Cetatuia, Nr. 4, Bl. M22, Sc. 5, Et. 2, Ap. 276, Sect. 6, Bucuresti, 060834 Romania Phone: +40-729-087003 Fax: +40-318-146297 www.vector-communications.net

8 10

Directly connected interface redistribution problem
by Alex Bligh 29 Sep '11

29 Sep '11

I am using a config a little like the one below to import routes directed at interfaces into bird (by which I mean a /32 routed out of an interface with a static route) and then redistribute them into OSPF. The configuration in general works. If I a) start bird (assume an empty routing table) b) pause for several seconds / minutes c) add the interface d) add the /32 static route to the interface then all is well. If I omit step (b) above, then the route appears to get imported into the evrospf protocol (i.e. 'show protocols all evrospf' shows the same thing) but it never makes it to the OSPF peer (Quagga in this case). A "restart evrospf" fixes it. It /seems/ that if kernel routes are added whilst bird is starting up (or perhaps whilst the adjacency is being formed), then those changes are lost. Any ideas on this, or how to debug it further? I suppose I can work around it with a sleep(), but it is a bit arbitrary as I have no idea how long to sleep for. -- Alex Bligh # Import kernel routes. These come in with RTS_INHERIT protocol kernel evrkernel { persist; # Don't remove routes on bird shutdown scan time 10; # Scan kernel routing table every 20 seconds import all; export all; learn; # Learn all alien routes from the kernel } # This pseudo-protocol watches all interface up/down events. protocol device { scan time 10; # Scan interfaces every 10 seconds } # Import all directly connected routes. These come in with RTS_DEVICE protocol direct evrdirect { interface "-evrr-000000", "evrr-*"; export all; } protocol ospf evrospf { area 0.0.0.0 { interface "evrr-000000" { cost 20; priority 1; }; }; export filter { # RTS_INHERIT means routes from the kernel if net = 0.0.0.0/0 then reject; if (source = RTS_INHERIT) || (source = RTS_DEVICE) then { accept; } reject; }; }

2 1

Number of arguments to a function
by fredrik danerklint 27 Sep '11

27 Sep '11

I've got an function with more than two arguments. You can define a function with more than two, but you can not call that function, with two or more arguments. Tested with the source code from git in the last hour. diff --git a/filter/test.conf b/filter/test.conf index 4f09637..ef433eb 100644 --- a/filter/test.conf +++ b/filter/test.conf @@ -29,7 +29,7 @@ function mkpath(int a; int b) return [= a b 3 2 1 =]; } -function callme(int arg1; int arg2) +function callme(int arg1; int arg2; int arg3) int local1; int local2; int i; @@ -318,6 +318,8 @@ string s; callme ( 4, 4 ); callme ( 7, 2 ); + callme ( 7, 2 , 1); + i = fifteen(); print "Testing function calls: 15 = ", i; The errormessage from bird: bird: test.conf, line 321: Wrong number of arguments for function callme. -- //fredan

2 2