- Bird-users - Mailing Lists

[PATCH 1/3] babel: Fix type of route entry router ID
by Toke Høiland-Jørgensen 09 May '18

09 May '18

The router ID being assigned to routes was a uint, which discards the upper 32 bits. This also has the nice side effect of echoing the wrong router ID back to other routers. Signed-off-by: Toke Høiland-Jørgensen <toke(a)toke.dk> --- proto/babel/babel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/proto/babel/babel.c b/proto/babel/babel.c index 4fd88042..a8eb5ea8 100644 --- a/proto/babel/babel.c +++ b/proto/babel/babel.c @@ -2140,7 +2140,7 @@ babel_rt_notify(struct proto *P, struct channel *c UNUSED, struct network *net, uint internal = (new->attrs->src->proto == P); uint rt_seqno = internal ? new->u.babel.seqno : p->update_seqno; uint rt_metric = ea_get_int(attrs, EA_BABEL_METRIC, 0); - uint rt_router_id = internal ? new->u.babel.router_id : p->router_id; + u64 rt_router_id = internal ? new->u.babel.router_id : p->router_id; if (rt_metric > BABEL_INFINITY) { -- 2.17.0

2 10

[PATCH 2/3] babel: Short-circuit route selection for routes we originate ourselves
by Toke Høiland-Jørgensen 09 May '18

09 May '18

Routes that are originated by this Babel instance doesn't have an entry in e->selected, which means that the best route selection logic will always pick another route when an update arrives for the same prefix. This will be rejected by Bird core, which will cause a nice looping selection procedure (depending on filters, of course). To avoid this problem, simply short-circuit the route selection procedure if the entry has our own router ID set. Signed-off-by: Toke Høiland-Jørgensen <toke(a)toke.dk> --- proto/babel/babel.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/proto/babel/babel.c b/proto/babel/babel.c index a8eb5ea8..f7981333 100644 --- a/proto/babel/babel.c +++ b/proto/babel/babel.c @@ -727,6 +727,9 @@ babel_select_route(struct babel_proto *p, struct babel_entry *e, struct babel_ro { struct babel_route *r, *best = e->selected; + if (e->router_id == p->router_id) + return; + /* Shortcut if only non-best was modified */ if (mod && (mod != best)) { -- 2.17.0

2 5

BGP next hop
by Arvin Gan 09 May '18

09 May '18

Hi all, I notice below description in user guide, my understand is source address mainly used for BGP session for TCP connection ,don't understand why this source is also used as next_hop_addr calculation. If source address is related with next hop calculation, this case is may not support: used MP_REACH_NLRI to support IPV4 route with IPV4 next hop ,but TCP connection type is IPV6. Since to support MP_REACH_NLRI for ipv4 channel, need to enabled ext_next_hop, if enabled ext_next_hop, if ipv6 source address is selected as next_hop_addr if no others configuration for next_hop_addr. Does my understand is correct ? source address ip Define local address we should use for next hop calculation and as a source address for the BGP session. Default: the address of the local end of the interface our neighbor is connected to. Thanks Arvin

2 1

OSPF wireguard fallback
by chrono 08 May '18

08 May '18

Ahoy all, I'm struggling a little to set wireguard as a fallback link in conjunction with two MPLS links. In my tests BIRD would not route traffic through wg0 when I took the other two interfaces down. The setup is rather simple, two DCs, each side has a gw running BIRD. ---- Config DC1 ---- router id 192.168.184.1; ### Kernel ##################################################################### protocol kernel { scan time 15; # Scan kernel routing table every 15 seconds export all; # Default is export none } ### Device Monitor ############################################################# protocol device { scan time 10; # Scan interfaces every 10 seconds } ### OSPF ####################################################################### protocol ospf MyOSPF { tick 2; ecmp yes; rfc1583compat yes; area 0.0.0.0 { # Advertise DC1 prod net stubnet 192.168.184.0/24; # MPLS1 interface interface "macsec.2335" { cost 5; ecmp weight 1; bfd yes; authentication cryptographic; password "testtesttest" { id 1; algorithm hmac sha256; }; }; # MPLS2 interface interface "macsec.2334" { cost 5; ecmp weight 1; bfd yes; authentication cryptographic; password "testtesttest" { id 2; algorithm hmac sha256; }; }; # WireGuard Fallback interface "wg0" { cost 10; bfd yes; type pointopoint; authentication cryptographic; password "testtesttest" { id 3; algorithm hmac sha256; }; }; }; }; ### BFD ######################################################################## protocol bfd PCrewBFD { # BFD on DTAG interface interface "macsec.2335" { min rx interval 20 ms; min tx interval 50 ms; idle tx interval 300 ms; }; # BFD on Console-Networks interface interface "macsec.2334" { min rx interval 20 ms; min tx interval 50 ms; idle tx interval 300 ms; }; # BFD on WireGuard interface interface "wg0" { min rx interval 200 ms; min tx interval 500 ms; idle tx interval 3000 ms; }; # WTF is multihop?? multihop { interval 200 ms; multiplier 10; }; }; ---- Config DC2 ---- router id 192.168.148.1; ### Kernel ##################################################################### protocol kernel { scan time 15; # Scan kernel routing table every 20 seconds export all; # Default is export none } ### Device Monitor ############################################################# protocol device { scan time 10; # Scan interfaces every 10 seconds } ### OSPF ####################################################################### protocol ospf MyOSPF { tick 2; ecmp yes; rfc1583compat yes; area 0.0.0.0 { # Advertise MUC prod net stubnet 192.168.148.0/24; # MPLS1 interface interface "macsec.2335" { cost 5; ecmp weight 1; bfd yes; authentication cryptographic; password "testtesttest" { id 1; algorithm hmac sha256; }; }; # MPLS2 interface interface "macsec.2334" { cost 5; ecmp weight 1; bfd yes; authentication cryptographic; password "testtesttest" { id 2; algorithm hmac sha256; }; }; # WireGuard Fallback interface "wg0" { cost 10; bfd yes; type pointopoint; authentication cryptographic; password "testtesttest" { id 3; algorithm hmac sha256; }; }; }; }; ---- BIRD states ---- bird> show route 172.23.1.0/29 dev macsec.2335 [MyOSPF 09:26:22] * I (150/5) [192.168.184.1] 172.23.2.0/29 dev macsec.2334 [MyOSPF 09:26:22] * I (150/5) [192.168.184.1] 192.168.148.0/24 multipath [MyOSPF 09:27:26] * I (150/15) [192.168.148.1] via 172.23.1.2 on macsec.2335 weight 1 via 172.23.2.2 on macsec.2334 weight 1 172.23.3.0/29 dev wg0 [MyOSPF 09:26:22] * I (150/10) [192.168.184.1] bird> show ospf state all area 0.0.0.0 router 192.168.148.1 distance 5 network 172.23.2.0/29 metric 5 network 172.23.1.0/29 metric 5 stubnet 172.23.3.0/29 metric 10 stubnet 192.168.148.0/24 metric 10 router 192.168.164.1 distance 0 network 172.23.2.0/29 metric 5 network 172.23.1.0/29 metric 5 stubnet 172.23.3.0/29 metric 10 stubnet 192.168.184.0/24 metric 10 network 172.23.1.0/29 dr 192.168.164.1 distance 5 router 192.168.184.1 router 192.168.148.1 network 172.23.2.0/29 dr 192.168.164.1 distance 5 router 192.168.184.1 router 192.168.148.1 What makes me wonder is why wg0 is coming up as stubnet here, while the MPLS links come up as network (stubnet 172.23.3.0/29 metric 10) and 172.23.3.0/29 (wg0 net) not being listed. Any hints or corrections of my config to get this to work with wireguard would be very much appreciated.

4 17

Received: No supported AFI/SAFI
by Rwakagabo Janvier 03 May '18

03 May '18

Hi All Can anyone help to understand why this error Received: No supported AFI/SAFI, i am using BIRD 1.4.0 to peer with my neighbours, other sessions are established except 1 peer with below error (Peer AAA) device1 Device master up 2017-11-19 AAA BGP master start 22:24:01 Idle Received: No supported AFI/SAFI BBB BGP master up 2017-11-19 Established CCC BGP master up 2018-04-16 Established DDD BGP master up 2018-04-04 Established Below is my configuration sample and it is the same for all peers filter bgp_in_AAA prefix set PL_in_AAA; { if ! (avoid_martians()) then reject; if (bgp_path.first != AAA) then reject; PL_in_AAA = [ AAA prefixes]; if net ~ PL_in_AAA then accept; else reject; } template bgp PEERS{ local as YYY; import limit 2000; export all; rs client; } protocol bgp AAA from PEERS { description "Peer-AAA"; neighbor a.b.c.d as AAA; import filter bgp_in_AAA; } Regards, Janvier R.

2 2

mrtdump-core
by Bjorn Carlsson 03 May '18

03 May '18

Any plans to merge those updates into version 2? Thanks, --BC

2 1

[PATCH] Makefile.in: Only set git version if .git directory exists
by Toke Høiland-Jørgensen 03 May '18

03 May '18

If Bird is compiled from a release tarball, but there is a git repository somewhere in a parent directory, the Makefile git version logic will pick up that version and use it as the Bird version, which is obviously not desirable. For instance, on OpenWrt this results in something like this: BIRD version reboot-6789-g4e9ce23aa5 Signed-off-by: Toke Høiland-Jørgensen <toke(a)toke.dk> --- Makefile.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.in b/Makefile.in index c8168bbe..1184d583 100644 --- a/Makefile.in +++ b/Makefile.in @@ -21,7 +21,7 @@ INSTALL=@INSTALL@ INSTALL_PROGRAM=@INSTALL_PROGRAM@ INSTALL_DATA=@INSTALL_DATA@ -git-label:=$(strip $(shell git describe --always --dirty=-x 2>/dev/null)) +git-label:=$(strip $(shell [ -d .git ] && git describe --always --dirty=-x 2>/dev/null)) ifneq ($(git-label),) CFLAGS += -DGIT_LABEL="$(git-label)" endif -- 2.17.0

2 2

Setting ONLINK flag for arbitrary routes
by Toke Høiland-Jørgensen 29 Apr '18

29 Apr '18

Hi Is it possible to set the ONLINK flag for arbitrary routes? The use case is a common setup in mesh networks: All devices have a /32 assigned to the interface and advertise this as the nexthop for v4 routes. The routing protocol then installs all kernel routes as onlink, allowing routes to be installed even though the nexthop is not in the same subnet as the local link address. Is this possible to configure in Bird currently? -Toke

2 2

Difference between loopback and dummy interfaces for use in Linux routing
by Wilhelm Schuster 28 Apr '18

28 Apr '18

Hi, I’m learning about IP-networking and am in the process of setting up a Linux router using bird. During my research I’ve come across the usage of loopback interfaces. I could gather that this is done, because Ethernet interfaces for example (in contrast to loopbacks) can go down making the addresses configured on them unavailable. In addition, the kernel accepts packets destined to loopbacks addresses on other interfaces making these addresses available on multiple interfaces and not just the loopback. On Linux I found both the lo(opback), and dummy interfaces recommended to achieve the behavior outlined above. What I’m struggling with is understanding the differences between both interface types (besides the obvious difference in packet processing) and when to use which. Searching this mailing list I’ve seen people use lo, on other sites dummy interfaces are recommended. From a quick test (assigning address to lo/dummy; pinging/receiving pings on the host) I wasn’t able to find a difference. When should I use which interface? Cheers, Wilhelm.

7 12

BGP filter
by Arvin Gan 28 Apr '18

28 Apr '18

Hi All, I am implementing a function that send default route to BGP peer, and I am facing an issue about BGP filter, when I use "show route filter" in birdc, the filter result is correct; when I add this filter to config-file and start bird, the bird will occur coredump issue. Does anyone know the reason? Appreciated in advance. 1. bird>show route filter {if format(net) = "0.0.0.0/0" then accept;} //correct result /* show route filter {if net = "0.0.0.0/0" then accept;} // incorrect result */ 2. config-file: filter filter_bgp1{ if format(net) = "0.0.0.0/0" then accept; // "format(net) = ..." , bird coredump ??? /* if net = "0.0.0.0/0" then accept; // " net= ..." , not bird coredump*/ } protocol bgp bgp1 { ...... ipv4 { import all; export filter filter_bgp1; }; ........ } Thanks Arvin

2 8