- Bird-users - Mailing Lists

Doc and doc not syncing together on windows
by Sam Russell 17 Jun '13

17 Jun '13

Is there any chance we could rename either the "doc" folder or the "Doc" document? I'm doing dev on a variety of machines, and on my windows machine I can only sync one because windows isn't case sensitive.

1 0

Building in OpenFlow/SDN support
by Sam Russell 14 Jun '13

14 Jun '13

Hi, I want a way to swap out the kernel/iface stuff from BIRD and replace that with something that can talk to an OpenFlow/SDN controller. I've made a start debugging to find out where I need to cut things into place and put it in github (bird Git was broken yesterday so had to start from 1.3.10 tarball) https://github.com/samrussell/bird Is anyone else keen for this? I've hooked the krt_notify, krt_learn_announce_update and ifa_send_notify functions and these seem to be the main things - would this be enough to make a start? My ideal goal would be to separate all the kernel/interface code from the engine and abstract it away in another protocol (or 2) so that different kernels/controllers can be swapped out at config time or run time, not at build time. Keen for any feedback Cheers Sam

3 7

Running BIRD 1.3.4 on custom config Linux 3.8.13 kernel
by Bao Nguyen 30 May '13

30 May '13

We testing BIRD on a custom 3.8.13 Linux kernel and seeing this message every 20 seconds. We did not see this on 3.2 kernel release by Ubuntu 12.04 LTS release. Is there any chance that there's a kernel config that's needed by BIRD that we are not aware of? I notice that the "wait 20" is the only time that matches this interval in the log... May 20 23:29:05 sja15 bird: Netlink: Invalid argument May 20 23:29:26 sja15 bird: Netlink: Invalid argument May 20 23:29:46 sja15 bird: Netlink: Invalid argument May 20 23:30:06 sja15 bird: Netlink: Invalid argument May 20 23:30:25 sja15 bird: Netlink: Invalid argument May 20 23:30:45 sja15 bird: Netlink: Invalid argument May 20 23:31:06 sja15 bird: Netlink: Invalid argument May 20 23:31:26 sja15 bird: Netlink: Invalid argument Here's our OSPF config. protocol ospf { import filter import_OSPF; export filter export_OSPF; ecmp 4; area 0 { interface "eth0", "eth1" { cost 100; type broadcast; hello 10; retransmit 5; wait 20; dead 40; }; interface "dummy0" { stub; }; }; Here's the kernel config related to the NETLINK stuff. root@sja15:~# cat config | grep NETLINK CONFIG_NETFILTER_NETLINK=m CONFIG_NETFILTER_NETLINK_ACCT=m CONFIG_NETFILTER_NETLINK_QUEUE=m CONFIG_NETFILTER_NETLINK_LOG=m CONFIG_NF_CT_NETLINK=m CONFIG_NF_CT_NETLINK_TIMEOUT=m CONFIG_NF_CT_NETLINK_HELPER=m CONFIG_NETFILTER_NETLINK_QUEUE_CT=y CONFIG_SCSI_NETLINK=y CONFIG_QUOTA_NETLINK_INTERFACE=y -bn 0216331C

2 7

Importing/exporting only static routes from the kernel
by Rob Greenwood 29 May '13

29 May '13

Hi, I'm wondering if there is a way with bird to only import static routes from the kernel routing table. Routes are currently being managed directly in the linux routing table via keepalived, however, I want to announce them out via BGP. I have tried just; kernel { import all; export all; } and this picks up the routes I want, however, it also imports a load of unreachable routes that I don't want to advertise. [root@infra-fw1a ~]# birdc6 show route protocol kernel1 BIRD 1.3.9 ready. ::/96 unreachable [kernel1 11:55] * (10) 2002:a00::/24 unreachable [kernel1 11:55] * (10) 3ffe:ffff::/32 unreachable [kernel1 11:55] * (10) 2002:7f00::/24 unreachable [kernel1 11:55] * (10) 2002:a9fe::/32 unreachable [kernel1 11:55] * (10) 2002:ac10::/28 unreachable [kernel1 11:55] * (10) 2a03:b200:0:2::/64 via 2a03:b200:1:2::2 on eth1.227 [kernel1 11:55] * (10) 2002:e000::/19 unreachable [kernel1 11:55] * (10) 2002:c0a8::/32 unreachable [kernel1 11:55] * (10) ::ffff:0.0.0.0/96 unreachable [kernel1 11:55] * (10) [root@infra-fw1a ~]# I know I can probably filter these, but that seems less ideal. Is there a way of just importing the reachable routes? Thanks, Rob

2 4

debian testing bird 1.3.10 segfaults with virtual link enabled
by Martin Kraus 28 May '13

28 May '13

Hi. bird 1.3.10 in debian testing segfaults with ospfv2 virtual link enabled. [177145.632393] bird[19291]: segfault at 30 ip 00007f0e2f601fe8 sp 00007fffe6899e90 error 4 in bird[7f0e2f5db000+60000] mk

2 4

erroneous "Netlink: File exists" ?
by Aragon Gouveia 27 May '13

27 May '13

Hi, So I've seen this issue mentioned in past mailings, and the FAQ, but I think I might be experiencing a buggy form of it in Bird 1.3.10. In debug mode I'm getting this: May 23 23:59:06 wugpi bird: device1: Scanning interfaces May 23 23:59:06 wugpi bird: CTWUG: HELLO packet sent via eth0 May 23 23:59:06 wugpi bird: kernel1: Scanning routing table May 23 23:59:06 wugpi bird: kernel1: Pruning table master May 23 23:59:06 wugpi bird: kernel1: 172.18.102.32/32: reinstalling May 23 23:59:06 wugpi bird: Netlink: File exists May 23 23:59:06 wugpi bird: kernel1: 172.18.102.160/28: reinstalling May 23 23:59:06 wugpi bird: Netlink: File exists May 23 23:59:06 wugpi bird: kernel1: 172.18.102.224/28: reinstalling May 23 23:59:06 wugpi bird: Netlink: File exists May 23 23:59:06 wugpi bird: kernel1: 172.18.102.240/28: reinstalling May 23 23:59:06 wugpi bird: Netlink: File exists May 23 23:59:06 wugpi bird: kernel1: 172.18.128.0/22: reinstalling May 23 23:59:06 wugpi bird: Netlink: File exists May 23 23:59:06 wugpi bird: ... Those prefixes are from OSPF only, and are not alien routes. My routing table without bird: # ip route list default via 172.18.102.7 dev eth0 172.18.102.0/28 dev eth0 proto kernel scope link src 172.18.102.8 172.18.102.71 via 172.18.102.7 dev eth0 With bird: # ip route list default via 172.18.102.7 dev eth0 172.16.0.0/12 via 172.18.102.1 dev eth0 proto bird 172.18.0.0/16 via 172.18.102.1 dev eth0 proto bird 172.18.1.1 via 172.18.102.7 dev eth0 proto bird 172.18.100.0/24 via 172.18.102.1 dev eth0 proto bird 172.18.100.2 via 172.18.102.1 dev eth0 proto bird 172.18.100.16/30 via 172.18.102.1 dev eth0 proto bird 172.18.100.20/30 via 172.18.102.1 dev eth0 proto bird 172.18.100.22 via 172.18.102.1 dev eth0 proto bird 172.18.100.24/30 via 172.18.102.1 dev eth0 proto bird 172.18.100.28/30 via 172.18.102.1 dev eth0 proto bird 172.18.100.29 via 172.18.102.1 dev eth0 proto bird 172.18.101.0/24 via 172.18.102.1 dev eth0 proto bird 172.18.102.0/28 dev eth0 proto kernel scope link src 172.18.102.8 172.18.102.1 via 172.18.102.1 dev eth0 proto bird 172.18.102.16/29 via 172.18.102.1 dev eth0 proto bird 172.18.102.18 via 172.18.102.1 dev eth0 proto bird 172.18.102.24/30 via 172.18.102.1 dev eth0 proto bird 172.18.102.32 via 172.18.102.7 dev eth0 proto bird 172.18.102.64/28 via 172.18.102.7 dev eth0 proto bird 172.18.102.71 via 172.18.102.7 dev eth0 172.18.102.128/27 via 172.18.102.14 dev eth0 proto bird 172.18.102.160/28 via 172.18.102.11 dev eth0 proto bird 172.18.102.192/28 via 172.18.102.9 dev eth0 proto bird 172.18.102.208/28 via 172.18.102.12 dev eth0 proto bird 172.18.102.224/28 via 172.18.102.10 dev eth0 proto bird 172.18.102.240/28 via 172.18.102.13 dev eth0 proto bird 172.18.103.0/24 via 172.18.102.1 dev eth0 proto bird 172.18.103.1 via 172.18.102.1 dev eth0 proto bird 172.18.128.0/22 via 172.18.102.1 dev eth0 proto bird Kernel: # uname -a Linux wugpi 3.6.11+ #452 PREEMPT Fri May 17 14:25:40 BST 2013 armv6l GNU/Linux Bird config: filter ospfin { if net ~ 172.16.0.0/12 then accept; reject; } protocol kernel { learn; scan time 20; import none; export all; } protocol device { scan time 10; } protocol ospf CTWUG { import filter ospfin; export none; area 172.18.102.0 { interface "eth*" 172.16.0.0/12 { type broadcast; priority 0; }; }; } Any ideas please? Before I start fumbling in source code... :) Thanks, Aragon

2 6

[PATCH RFC v2] Preserve BGP attributes from non-BGP protocols
by Matthias Schiffer 24 May '13

24 May '13

There is no reason to overwrite attributes like AS path, next hop, etc. when the route source is not BGP. Preserving them has several advantages: * no attributes are lost by using opaque pipes * BGP attributes can by pre-populated in other protocols' import filters As a side effect of moving code from bgp_create_attrs() to bgp_update_attrs(), the BGP protocol now uses the same logic to determine if the "gw" attribute should be used as next hop for routes from BGP sources as for those from other sources. Previously, the "gw" attribute was never for routes from BGP. Limitations: * The handling of routes imported from/exported to route reflectors isn't preserved through opaque pipes --- Hi, I found a small issue with my first patch (origin and local_pref attributes not being preserved), so here is a v2. Regards, Matthias proto/bgp/attrs.c | 101 ++++++++++++++++++++++++------------------------------ 1 file changed, 45 insertions(+), 56 deletions(-) diff --git a/proto/bgp/attrs.c b/proto/bgp/attrs.c index c27a498..7f3b739 100644 --- a/proto/bgp/attrs.c +++ b/proto/bgp/attrs.c @@ -903,47 +903,17 @@ bgp_rt_notify(struct proto *P, rtable *tbl UNUSED, net *n, rte *new, rte *old UN bgp_schedule_packet(p->conn, PKT_UPDATE); } -static int +static void bgp_create_attrs(struct bgp_proto *p, rte *e, ea_list **attrs, struct linpool *pool) { - ea_list *ea = lp_alloc(pool, sizeof(ea_list) + 4*sizeof(eattr)); rta *rta = e->attrs; - byte *z; - ea->next = *attrs; - *attrs = ea; - ea->flags = EALF_SORTED; - ea->count = 4; - - bgp_set_attr(ea->attrs, BA_ORIGIN, + if (!ea_find(rta->eattrs, EA_CODE(EAP_BGP, BA_ORIGIN))) + bgp_attach_attr(attrs, pool, BA_ORIGIN, ((rta->source == RTS_OSPF_EXT1) || (rta->source == RTS_OSPF_EXT2)) ? ORIGIN_INCOMPLETE : ORIGIN_IGP); - if (p->is_internal) - bgp_set_attr_wa(ea->attrs+1, pool, BA_AS_PATH, 0); - else - { - z = bgp_set_attr_wa(ea->attrs+1, pool, BA_AS_PATH, 6); - z[0] = AS_PATH_SEQUENCE; - z[1] = 1; /* 1 AS */ - put_u32(z+2, p->local_as); - } - - /* iBGP -> use gw, eBGP multi-hop -> use source_addr, - eBGP single-hop -> use gw if on the same iface */ - z = bgp_set_attr_wa(ea->attrs+2, pool, BA_NEXT_HOP, NEXT_HOP_LENGTH); - if (p->cf->next_hop_self || - rta->dest != RTD_ROUTER || - ipa_equal(rta->gw, IPA_NONE) || - ipa_has_link_scope(rta->gw) || - (!p->is_internal && !p->cf->next_hop_keep && - (!p->neigh || (rta->iface != p->neigh->iface)))) - set_next_hop(z, p->source_addr); - else - set_next_hop(z, rta->gw); - - bgp_set_attr(ea->attrs+3, BA_LOCAL_PREF, p->cf->default_local_pref); - - return 0; /* Leave decision to the filters */ + if (!ea_find(rta->eattrs, EA_CODE(EAP_BGP, BA_LOCAL_PREF))) + bgp_attach_attr(attrs, pool, BA_LOCAL_PREF, p->cf->default_local_pref); } @@ -973,7 +943,16 @@ static inline void bgp_path_prepend(rte *e, ea_list **attrs, struct linpool *pool, u32 as) { eattr *a = ea_find(e->attrs->eattrs, EA_CODE(EAP_BGP, BA_AS_PATH)); - bgp_attach_attr(attrs, pool, BA_AS_PATH, (uintptr_t) as_path_prepend(pool, a->u.ptr, as)); + if (a) + bgp_attach_attr(attrs, pool, BA_AS_PATH, (uintptr_t) as_path_prepend(pool, a->u.ptr, as)); + else + { + byte *z; + z = bgp_attach_attr_wa(attrs, pool, BA_AS_PATH, 6); + z[0] = AS_PATH_SEQUENCE; + z[1] = 1; /* 1 AS */ + put_u32(z+2, as); + } } static inline void @@ -986,6 +965,7 @@ bgp_cluster_list_prepend(rte *e, ea_list **attrs, struct linpool *pool, u32 cid) static int bgp_update_attrs(struct bgp_proto *p, rte *e, ea_list **attrs, struct linpool *pool, int rr) { + rta *rta = e->attrs; eattr *a; if (!p->is_internal && !p->rs_client) @@ -1000,6 +980,8 @@ bgp_update_attrs(struct bgp_proto *p, rte *e, ea_list **attrs, struct linpool *p if (a) bgp_attach_attr(attrs, pool, BA_MULTI_EXIT_DISC, 0); } + else if (!ea_find(e->attrs->eattrs, EA_CODE(EAP_BGP, BA_AS_PATH))) + bgp_attach_attr_wa(attrs, pool, BA_AS_PATH, 0); /* iBGP -> keep next_hop, eBGP multi-hop -> use source_addr, * eBGP single-hop -> keep next_hop if on the same iface. @@ -1019,7 +1001,15 @@ bgp_update_attrs(struct bgp_proto *p, rte *e, ea_list **attrs, struct linpool *p { /* Need to create new one */ byte *b = bgp_attach_attr_wa(attrs, pool, BA_NEXT_HOP, NEXT_HOP_LENGTH); - set_next_hop(b, p->source_addr); + if (p->cf->next_hop_self || + rta->dest != RTD_ROUTER || + ipa_equal(rta->gw, IPA_NONE) || + ipa_has_link_scope(rta->gw) || + (!p->is_internal && !p->cf->next_hop_keep && + (!p->neigh || (rta->iface != p->neigh->iface)))) + set_next_hop(b, p->source_addr); + else + set_next_hop(b, rta->gw); } if (rr) @@ -1079,30 +1069,29 @@ bgp_import_control(struct proto *P, rte **new, ea_list **attrs, struct linpool * if (p == new_bgp) /* Poison reverse updates */ return -1; - if (new_bgp) - { - /* We should check here for cluster list loop, because the receiving BGP instance - might have different cluster ID */ - if (bgp_cluster_list_loopy(p, e->attrs)) - return -1; - if (p->cf->interpret_communities && bgp_community_filter(p, e)) - return -1; + if (!new_bgp) + bgp_create_attrs(p, e, attrs, pool); - if (p->local_as == new_bgp->local_as && p->is_internal && new_bgp->is_internal) - { - /* Redistribution of internal routes with IBGP */ - if (p->rr_client || new_bgp->rr_client) - /* Route reflection, RFC 4456 */ - return bgp_update_attrs(p, e, attrs, pool, 1); - else - return -1; - } + /* We should check here for cluster list loop, because the receiving BGP instance + might have different cluster ID */ + if (bgp_cluster_list_loopy(p, e->attrs)) + return -1; + + if (p->cf->interpret_communities && bgp_community_filter(p, e)) + return -1; + + if (new_bgp && p->local_as == new_bgp->local_as && p->is_internal && new_bgp->is_internal) + { + /* Redistribution of internal routes with IBGP */ + if (p->rr_client || new_bgp->rr_client) + /* Route reflection, RFC 4456 */ + return bgp_update_attrs(p, e, attrs, pool, 1); else - return bgp_update_attrs(p, e, attrs, pool, 0); + return -1; } else - return bgp_create_attrs(p, e, attrs, pool); + return bgp_update_attrs(p, e, attrs, pool, 0); } static inline u32 -- 1.8.2.3

2 4

Flood of: <WARN> Netlink: File exists
by Tapio Haapala 22 May '13

22 May '13

Hello, We get <WARN> Netlink: File exists message to bird log about 25 times in minute. I think it comes when bird try add some routes to kernel table what are allready in table. Is there way to get more information what it try insert to table so then I maybe can resolve that with filters. I think it just get same routes from two different protocol. -- F-Solutions Oy Tapio Haapala PL7, 90571 Oulu GSM 0400 998371 Skype burner- IRC Burner@ircnet

3 2

[PATCH RFC] Preserve BGP attributes from non-BGP protocols
by Matthias Schiffer 17 May '13

17 May '13

There is no reason to overwrite attributes like AS path, next hop, etc. when the route source is not BGP. Preserving them has several advantages: * no attributes are lost by using opaque pipes * BGP attributes can by pre-populated in other protocols' import filters As a side effect of moving code from bgp_create_attrs() to bgp_update_attrs(), the BGP protocol now uses the same logic to determine if the "gw" attribute should be used as next hop for routes from BGP sources as for those from other sources. Previously, the "gw" attribute was never for routes from BGP. Limitations: * The handling of routes imported from/exported to route reflectors isn't preserved through opaque pipes --- Hi, this is a patch I just wrote up in need for this feature. I've tested it on a handful of systems and everything seems to be working correctly. Comments welcome :) Regards, Matthias proto/bgp/attrs.c | 101 ++++++++++++++++++++++++------------------------------ 1 file changed, 45 insertions(+), 56 deletions(-) diff --git a/proto/bgp/attrs.c b/proto/bgp/attrs.c index c27a498..6e6f784 100644 --- a/proto/bgp/attrs.c +++ b/proto/bgp/attrs.c @@ -903,47 +903,17 @@ bgp_rt_notify(struct proto *P, rtable *tbl UNUSED, net *n, rte *new, rte *old UN bgp_schedule_packet(p->conn, PKT_UPDATE); } -static int +static void bgp_create_attrs(struct bgp_proto *p, rte *e, ea_list **attrs, struct linpool *pool) { - ea_list *ea = lp_alloc(pool, sizeof(ea_list) + 4*sizeof(eattr)); rta *rta = e->attrs; - byte *z; - ea->next = *attrs; - *attrs = ea; - ea->flags = EALF_SORTED; - ea->count = 4; - - bgp_set_attr(ea->attrs, BA_ORIGIN, + if (!ea_find(*attrs, EA_CODE(EAP_BGP, BA_ORIGIN))) + bgp_attach_attr(attrs, pool, BA_ORIGIN, ((rta->source == RTS_OSPF_EXT1) || (rta->source == RTS_OSPF_EXT2)) ? ORIGIN_INCOMPLETE : ORIGIN_IGP); - if (p->is_internal) - bgp_set_attr_wa(ea->attrs+1, pool, BA_AS_PATH, 0); - else - { - z = bgp_set_attr_wa(ea->attrs+1, pool, BA_AS_PATH, 6); - z[0] = AS_PATH_SEQUENCE; - z[1] = 1; /* 1 AS */ - put_u32(z+2, p->local_as); - } - - /* iBGP -> use gw, eBGP multi-hop -> use source_addr, - eBGP single-hop -> use gw if on the same iface */ - z = bgp_set_attr_wa(ea->attrs+2, pool, BA_NEXT_HOP, NEXT_HOP_LENGTH); - if (p->cf->next_hop_self || - rta->dest != RTD_ROUTER || - ipa_equal(rta->gw, IPA_NONE) || - ipa_has_link_scope(rta->gw) || - (!p->is_internal && !p->cf->next_hop_keep && - (!p->neigh || (rta->iface != p->neigh->iface)))) - set_next_hop(z, p->source_addr); - else - set_next_hop(z, rta->gw); - - bgp_set_attr(ea->attrs+3, BA_LOCAL_PREF, p->cf->default_local_pref); - - return 0; /* Leave decision to the filters */ + if (!ea_find(*attrs, EA_CODE(EAP_BGP, BA_LOCAL_PREF))) + bgp_attach_attr(attrs, pool, BA_LOCAL_PREF, p->cf->default_local_pref); } @@ -973,7 +943,16 @@ static inline void bgp_path_prepend(rte *e, ea_list **attrs, struct linpool *pool, u32 as) { eattr *a = ea_find(e->attrs->eattrs, EA_CODE(EAP_BGP, BA_AS_PATH)); - bgp_attach_attr(attrs, pool, BA_AS_PATH, (uintptr_t) as_path_prepend(pool, a->u.ptr, as)); + if (a) + bgp_attach_attr(attrs, pool, BA_AS_PATH, (uintptr_t) as_path_prepend(pool, a->u.ptr, as)); + else + { + byte *z; + z = bgp_attach_attr_wa(attrs, pool, BA_AS_PATH, 6); + z[0] = AS_PATH_SEQUENCE; + z[1] = 1; /* 1 AS */ + put_u32(z+2, as); + } } static inline void @@ -986,6 +965,7 @@ bgp_cluster_list_prepend(rte *e, ea_list **attrs, struct linpool *pool, u32 cid) static int bgp_update_attrs(struct bgp_proto *p, rte *e, ea_list **attrs, struct linpool *pool, int rr) { + rta *rta = e->attrs; eattr *a; if (!p->is_internal && !p->rs_client) @@ -1000,6 +980,8 @@ bgp_update_attrs(struct bgp_proto *p, rte *e, ea_list **attrs, struct linpool *p if (a) bgp_attach_attr(attrs, pool, BA_MULTI_EXIT_DISC, 0); } + else if (!ea_find(e->attrs->eattrs, EA_CODE(EAP_BGP, BA_AS_PATH))) + bgp_attach_attr_wa(attrs, pool, BA_AS_PATH, 0); /* iBGP -> keep next_hop, eBGP multi-hop -> use source_addr, * eBGP single-hop -> keep next_hop if on the same iface. @@ -1019,7 +1001,15 @@ bgp_update_attrs(struct bgp_proto *p, rte *e, ea_list **attrs, struct linpool *p { /* Need to create new one */ byte *b = bgp_attach_attr_wa(attrs, pool, BA_NEXT_HOP, NEXT_HOP_LENGTH); - set_next_hop(b, p->source_addr); + if (p->cf->next_hop_self || + rta->dest != RTD_ROUTER || + ipa_equal(rta->gw, IPA_NONE) || + ipa_has_link_scope(rta->gw) || + (!p->is_internal && !p->cf->next_hop_keep && + (!p->neigh || (rta->iface != p->neigh->iface)))) + set_next_hop(b, p->source_addr); + else + set_next_hop(b, rta->gw); } if (rr) @@ -1079,30 +1069,29 @@ bgp_import_control(struct proto *P, rte **new, ea_list **attrs, struct linpool * if (p == new_bgp) /* Poison reverse updates */ return -1; - if (new_bgp) - { - /* We should check here for cluster list loop, because the receiving BGP instance - might have different cluster ID */ - if (bgp_cluster_list_loopy(p, e->attrs)) - return -1; - if (p->cf->interpret_communities && bgp_community_filter(p, e)) - return -1; + if (!new_bgp) + bgp_create_attrs(p, e, attrs, pool); - if (p->local_as == new_bgp->local_as && p->is_internal && new_bgp->is_internal) - { - /* Redistribution of internal routes with IBGP */ - if (p->rr_client || new_bgp->rr_client) - /* Route reflection, RFC 4456 */ - return bgp_update_attrs(p, e, attrs, pool, 1); - else - return -1; - } + /* We should check here for cluster list loop, because the receiving BGP instance + might have different cluster ID */ + if (bgp_cluster_list_loopy(p, e->attrs)) + return -1; + + if (p->cf->interpret_communities && bgp_community_filter(p, e)) + return -1; + + if (new_bgp && p->local_as == new_bgp->local_as && p->is_internal && new_bgp->is_internal) + { + /* Redistribution of internal routes with IBGP */ + if (p->rr_client || new_bgp->rr_client) + /* Route reflection, RFC 4456 */ + return bgp_update_attrs(p, e, attrs, pool, 1); else - return bgp_update_attrs(p, e, attrs, pool, 0); + return -1; } else - return bgp_create_attrs(p, e, attrs, pool); + return bgp_update_attrs(p, e, attrs, pool, 0); } static inline u32 -- 1.8.2.3

1 0

Cacti Scripts
by Joe Wooller 16 May '13

16 May '13

Hey All, We have just been making some cacti scripts for graphing routes. Please let me know what you think. https://github.com/dowlingw/bird-tool Cheers Joe

1 0