- Bird-users - Mailing Lists

Bird2 installation failing for debian https://bird.network.cz/?download&tdir=debian/
by Akshay kumar 27 Apr '20

27 Apr '20

Hi all, I am trying to install bird2 from apt as mention in https://bird.network.cz/?download&tdir=debian/ for debian. Its getting failed, seems to be related to apt key is missing, please advise. "W: GPG error: http://bird.network.cz/debian buster InRelease: The following signatures couldn't be verified because the public key is not available: NO_PUBKEY B188E2B695BD4743 E: The repository 'http://bird.network.cz/debian buster InRelease' is not signed. N: Updating from such a repository can't be done securely, and is therefore disabled by default. N: See apt-secure(8) manpage for repository creation and user configuration details." Thanks Akshay

2 2

Need to run 'configure' command two times to apply route filter change
by Nasato Goto 27 Apr '20

27 Apr '20

Hi all, I run BIRD v2.0.7 as a route server. When I changed the route filter configuration in BIRD, for example adding prefix entry to a filter, I needed to execute 'configure' command twice to apply new route filter. The first 'configure' command didn't affect. The prefix which I added to filter configuration was kept to be rejected. I could only see '<protocol_name> reconfigured' message in the log file. Then the second 'configure' worked. The prefix was accepted. I saw '<protocol_name>: Sending ROUTE-REFRESH' message in log file. Is this a normal behavior or am I missing something? Best regards, ----- Nasato Goto INTERNET MULTIFEED CO. goto(a)mfeed.ad.jp -----

2 2

Vulnerability? Bug? Missing check after xmalloc() in xstrdup().
by liupeiyu＠zju.edu.cn 27 Apr '20

27 Apr '20

Hi,In lib/string.h line 38,staticinlinechar*xstrdup(constchar*c){size_tl=strlen(c)+1;// xmalloc may fail, and z will be NULL. char*z=xmalloc(l);// write to a NULL pointer, crash. memcpy(z,c,l);returnz;}I think this is a vulnerability, and maybe we can fix it as following:staticinlinechar*xstrdup(constchar*c){size_tl=strlen(c)+1;char*z=xmalloc(l); if(z) { memcpy(z,c,l);returnz; } else return -1;}Thanks for any consideration!Peiyu Liu, NESA lab, Zhejiang University

2 2

"bird -p" creates log file owned by root
by Brian Candler 24 Apr '20

24 Apr '20

Hello, I'm testing out the bird2 2.0.7 package from the PPA under Ubuntu 18.04, and I've found a problem with permissions on log files when run under systemd. I created a directory /var/log/bird/ owned by bird:bird, and configured logging as: log "/var/log/bird/bird.log" all; This works fine when I start bird by hand: root@rs1:/etc/bird# ls -l /var/log/bird total 0 root@rs1:/etc/bird# /usr/sbin/bird -f -u bird -g bird ^C root@rs1:/etc/bird# ls -l /var/log/bird total 4 -rw-r--r-- 1 bird bird 39 Apr 24 11:00 bird.log The problem is that when running under systemd, the log file is created owned by root:root and this causes bird to crash with a permissions error: root@rs1:/etc/bird# rm /var/log/bird/bird.log root@rs1:/etc/bird# systemctl start bird root@rs1:/etc/bird# ls -l /var/log/bird total 0 -rw-r--r-- 1 root root 0 Apr 24 11:03 bird.log root@rs1:/etc/bird# journalctl -eu bird ... Apr 24 11:01:28 rs1 systemd[1]: Starting BIRD Internet Routing Daemon... Apr 24 11:01:28 rs1 systemd[1]: Started BIRD Internet Routing Daemon. Apr 24 11:01:28 rs1 bird[1849]: /etc/bird/bird.conf:9:30 Unable to open log file '/var/log/bird/bird.log': Permission denied Apr 24 11:01:28 rs1 bird[1849]: bird: /etc/bird/bird.conf:9:30 Unable to open log file '/var/log/bird/bird.log': Permission denied Apr 24 11:01:28 rs1 systemd[1]: bird.service: Main process exited, code=exited, status=1/FAILURE Apr 24 11:01:28 rs1 systemd[1]: bird.service: Failed with result 'exit-code'. I found the cause. /lib/systemd/system/bird.service includes the line "ExecStartPre=/usr/sbin/bird -p", and if the log file doesn't exist, it creates it owned by root:root root@rs1:/etc/bird# rm /var/log/bird/bird.log root@rs1:/etc/bird# /usr/sbin/bird -p root@rs1:/etc/bird# ls -l /var/log/bird/bird.log -rw-r--r-- 1 root root 0 Apr 24 11:07 /var/log/bird/bird.log The documentation for the -p flag states: -p Just parse the config file and exit. Return value is zero if the config file is valid, nonzero if there are some errors. So it seems like a bug that it creates the log file. Workaround is to create the log file manually first: root@rs1:/etc/bird# touch /var/log/bird/bird.log root@rs1:/etc/bird# chown bird:bird /var/log/bird/bird.log You would have to be careful whenever rotating the log file too. Cheers, Brian.

2 1

BGP Socket:Connection closed
by Fabiano D'Agostino 23 Apr '20

23 Apr '20

Good evening, I am facing this problem with bgp protocol: Info: Active Socket:Connection closed Why do I have this? Thanks in advance, Fabiano

1 0

RFC 5575 question: is Destination Prefix mendatory?
by Alarig Le Lay 22 Apr '20

22 Apr '20

Hi, it seems that for bird, the flowspec destination prefix is mentatory. I have a session with an exabgp and if I send this echo 'announce flow route { match { source 213.167.241.55/32; destination 0.0.0.0/0; } then { discard; } }' > /var/run/exabgp.cmd It works, I have the route: bird> show route all table flowtab4 Table flowtab4: flow4 { dst 0.0.0.0/0; src 213.167.241.55/32; } [bgp_wfiltr1_ipv4 15:44:14.440 from 217.70.176.118] * (100) [i] Type: BGP univ BGP.origin: IGP BGP.as_path: BGP.local_pref: 100 BGP.ext_community: (generic, 0x80060000, 0x0) But, if I send this: echo 'announce flow route { match { source 213.167.241.55/32; } then { discard; } }' > /var/run/exabgp.cmd It doesn’t work, the session is in error state (BGP Error: Malformed attribute list) and the log says "Invalid flow route: Destination prefix is missing". However, https://tools.ietf.org/html/rfc5575#section-4 says We define a "Flow Specification" NLRI type that may include several components such as destination prefix, source prefix, protocol, ports, etc. This NLRI is treated as an opaque bit string prefix by BGP. Each bit string identifies a key to a database entry with which a set of attributes can be associated. As it’s “may”, I would say that it’s not mendatory. The sessions toward ASR9K routers accept the annoucement. Regards, -- Alarig

2 2

BIRD mailing list issue - root cause found: BIRD MTA fails to resend after being greylisted
by Christoph 21 Apr '20

21 Apr '20

Hi, the root cause for the mailing list issues have been found. trubka.network.cz gets greylisted by never tries to delivery the emails again. {{ Oct 4 13:17:46 mx2 postgrey[1652]: action=greylist, reason=new, client_name=trubka.network.cz, client_address=2001:1568:b:145::1 Could you look into your MTA configuration to resolve this issue? thanks, Christoph

2 3

Handling AGGREGATOR in v2.0.7
by Nasato Goto 15 Apr '20

15 Apr '20

Hi all, I found a bit strange behavior of handling AGGREGATOR attributes in BIRD v2.0.7 route server. When BIRD receives a route containing AGGREGATOR attribute from 4byte-AS capable peer, it sends the route with strange AGGREGATOR to 4byte-AS incapable peer. On the other hand, BIRD can sends AS4_AGGREGATOR attribute correctly. Here is a scenario what I did. In the following simple topology, Peer1 and BIRD RS are 4byte-AS capable and Peer2 is 2byte-AS support only. Peer1 --(r1)--> BIRD RS --(r1’)--> Peer2 Peer1 advertise a route r1 which contains AGGREGATOR attribute. (omitting ATOMIC_AGGREGATE here) ------ r1: AGGREGATOR: - Aggregator AS: 650001 (in 4byte) - Aggregator Origin: x.x.x.x ------ Then, the expected route r1’ advertised from RS to Peer2 should be like: ------ r1’: AGGREGATOR: - Aggregator AS: 23456 (AS_TRANS, in 2byte) - Aggregator Origin: x.x.x.x AS4_AGGREGATOR: - Aggregator AS: 650001 (in 4byte) - Aggregator Origin: x.x.x.x ------ But as far as I see, BIRD sends the route including AGGREGATOR like: ------ r1’: AGGREGATOR: - Aggregator AS: 0 (in 2byte) #here - Aggregator Origin: y.y.y.y #and here, not match to original origin x.x.x.x AS4_AGGREGATOR: - Aggregator AS: 650001 (in 4byte) - Aggregator Origin: x.x.x.x ------ This may not confirm to the section 4.2.2 in https://tools.ietf.org/html/rfc6793. And also, when the AS number in original AGGREGATOR is a “mappable” 4byte-AS number, I see that the AS number in AGGREGATOR advertised from BIRD is set as 65535 (0xFFFF). Then I tried a small patch, this fixed my problem. But I’m not sure if it’s appropriate. ------------------------------------------ diff --git a/nest/attrs.h b/nest/attrs.h index 6fb0a8fa..e0399708 100644 --- a/nest/attrs.h +++ b/nest/attrs.h @@ -111,7 +111,7 @@ static inline struct adata * aggregator_to_old(struct linpool *pool, const struct adata *a) { struct adata *d = lp_alloc_adata(pool, 8); - put_u32(d->data, 0xFFFF); + put_u32(d->data, AS_TRANS); memcpy(d->data + 4, a->data + 4, 4); return d; } diff --git a/proto/bgp/attrs.c b/proto/bgp/attrs.c index b8921363..f2a4d5b2 100644 --- a/proto/bgp/attrs.c +++ b/proto/bgp/attrs.c @@ -562,6 +562,7 @@ bgp_encode_aggregator(struct bgp_write_state *s, eattr *a, byte *buf, uint size) /* Prepare 16-bit AGGREGATOR (from 32-bit one) in a temporary buffer */ byte *dst = alloca(6); len = aggregator_32to16(dst, data); + data = dst; } return bgp_put_attr(buf, size, BA_AGGREGATOR, a->flags, data, len); ------------------------------------------ If further information is needed I will be happy to provide it. Best regards, ----- Nasato Goto JPNAP / INTERNET MULTIFEED CO. goto(a)mfeed.ad.jp -----

2 4

High CPU usage with 5.x Linux kernel
by Alarig Le Lay 14 Apr '20

14 Apr '20

Hi, I recently upgraded from 4.19.97 to 5.4.28 and I noticed that bird was using a lot more CPU (about three times). On those two graphs you can see the CPU usage and when I rebooted: https://pix.milkywan.fr/gallery#ugO0qVvx.png,ncr9kHfi.png I rebooted to 4.19.113 and now I’m back to the ~10 % average CPU. My router has 5 dual-stack fullviews (2 are from RRs), a dual-stack OSPF and BFD on OSPF and on the RR sessions. I also upgraded my RRs, but I don’t see any change on them, so the usage might be related to FIB/kernel route insertion. I don’t have other BGP implementation on my network, so it might be a kernel bug and not a bird one. But on the other hand, I was clearly seeing the bird process using a whole CPU core with htop. I can share my .conf for each kernel if it’s helpful. Regards, -- Alarig

1 0

[PATCH] babel: Set onlink flag for IPv4 routes with unreachable next hop
by Toke Høiland-Jørgensen 14 Apr '20

14 Apr '20

If the next hop of a route is not a reachable address, the route should be installed as onlink. This enables a configuration common in mesh networks where the mesh interface is assigned a /32 and babel handles the routing by installing onlink routes. Signed-off-by: Toke Høiland-Jørgensen <toke(a)toke.dk> --- proto/babel/babel.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/proto/babel/babel.c b/proto/babel/babel.c index 88c4711e..4fd88042 100644 --- a/proto/babel/babel.c +++ b/proto/babel/babel.c @@ -640,6 +640,13 @@ babel_announce_rte(struct babel_proto *p, struct babel_entry *e) .nh.iface = r->neigh->ifa->iface, }; + /* If we cannot find a reachable neighbour, set the entry to be onlink. This + * makes it possible to, e.g., assign /32 addresses on a mesh interface and + * have routing work. + */ + if (!neigh_find2(&p->p, &r->next_hop, r->neigh->ifa->iface, 0)) + a0.nh.flags = RNF_ONLINK; + rta *a = rta_lookup(&a0); rte *rte = rte_get_temp(a); rte->u.babel.seqno = r->seqno; -- 2.17.0

3 4